🐛 Source Jira: Fix fetching and update schema for `filters` stream #9079

Zirochkaa · 2021-12-23T09:33:17Z

Bug-fix Request

Reason

Error was in filters stream. I believe that earlier following fields were sent by default without explicitly specifying that we want to receive these fields:

description
owner
jql
viewUrl
searchUrl
favourite
favouritedCount
sharePermissions
isWritable
subscriptions

Right now if someone wants to receive those fields they need to send additional parameter - expand in which put wanted fields (see docs, under QUERY PARAMETERS section).
That was the reason why tests were failing for that stream.

Confirmation

Was reproduced locally

How does the code change in the PR fix the issue?

The code change sends that expand parameter.

Zirochkaa · 2021-12-23T09:34:00Z

/test connector=source-jira

🕑 source-jira https://github.com/airbytehq/airbyte/actions/runs/1614985072
✅ source-jira https://github.com/airbytehq/airbyte/actions/runs/1614985072
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                      Stmts   Miss  Cover
	 ---------------------------------------------
	 source_jira/__init__.py       2      2     0%
	 source_jira/source.py        35     35     0%
	 source_jira/streams.py      532    532     0%
	 ---------------------------------------------
	 TOTAL                       569    569     0%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestFullRefresh.test_sequential_reads because not found in the config
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 18 passed, 2 skipped in 160.97s (0:02:40) ===================

Zirochkaa · 2021-12-23T14:27:18Z

/test connector=source-jira

🕑 source-jira https://github.com/airbytehq/airbyte/actions/runs/1615929919
❌ source-jira https://github.com/airbytehq/airbyte/actions/runs/1615929919
🐛 https://gradle.com/s/uq4w64f5dbwve

Zirochkaa · 2021-12-23T14:46:48Z

/test connector=source-jira

🕑 source-jira https://github.com/airbytehq/airbyte/actions/runs/1615993401
✅ source-jira https://github.com/airbytehq/airbyte/actions/runs/1615993401
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                      Stmts   Miss  Cover
	 ---------------------------------------------
	 source_jira/__init__.py       2      2     0%
	 source_jira/source.py        35     35     0%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-jira/.venv/lib/python3.8/site-packages/coverage/control.py:768: CoverageWarning: No data was collected. (no-data-collected)
	 source_jira/streams.py      532    532     0%
	 ---------------------------------------------
	 TOTAL                       569    569     0%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestFullRefresh.test_sequential_reads because not found in the config
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 18 passed, 2 skipped in 158.79s (0:02:38) ===================

Zirochkaa · 2021-12-23T15:13:53Z

/test connector=source-jira

🕑 source-jira https://github.com/airbytehq/airbyte/actions/runs/1616085729
✅ source-jira https://github.com/airbytehq/airbyte/actions/runs/1616085729
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      6    92%
	 source_acceptance_test/conftest.py                     109    109     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              242     96    60%
	 source_acceptance_test/tests/test_full_refresh.py       38      0   100%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  54     17    69%
	 source_acceptance_test/utils/compare.py                 62     23    63%
	 source_acceptance_test/utils/connector_runner.py       110     48    56%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  979    404    59%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                      Stmts   Miss  Cover
	 ---------------------------------------------
	 source_jira/__init__.py       2      2     0%
	 source_jira/source.py        35     35     0%
	 source_jira/streams.py      532    532     0%
	 source_jira/source.py        35     35     0%/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-jira/.venv/lib/python3.8/site-packages/coverage/control.py:768: CoverageWarning: No data was collected. (no-data-collected)
	   self._warn("No data was collected.", slug="no-data-collected")
	 ---------------------------------------------
	 TOTAL                       569    569     0%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestFullRefresh.test_sequential_reads because not found in the config
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 18 passed, 2 skipped in 157.40s (0:02:37) ===================

Zirochkaa · 2021-12-23T15:38:39Z

/publish connector=connectors/source-jira

🕑 connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/1616166841
✅ connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/1616166841

Zirochkaa self-assigned this Dec 23, 2021

github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Dec 23, 2021

jrhizor temporarily deployed to more-secrets December 23, 2021 09:36 Inactive

Zirochkaa requested review from avida, htrueman, sergei-solonitcyn and yevhenii-ldv December 23, 2021 09:45

Zirochkaa added 2 commits December 23, 2021 16:24

9017 Fix fetching and update schema for filters stream

0f8f6a5

9017 Bump connector's version

d8fe196

Zirochkaa force-pushed the oleh/9017-fix-filters-stream branch from 3a980bd to d8fe196 Compare December 23, 2021 14:27

Zirochkaa temporarily deployed to more-secrets December 23, 2021 14:28 Inactive

jrhizor temporarily deployed to more-secrets December 23, 2021 14:29 Inactive

9017 Update docs

0dd505c

Zirochkaa temporarily deployed to more-secrets December 23, 2021 14:31 Inactive

jrhizor temporarily deployed to more-secrets December 23, 2021 14:48 Inactive

9017 Update docs

1b965f2

Zirochkaa temporarily deployed to more-secrets December 23, 2021 14:51 Inactive

9017 Set additionalProperties to false

a1c5a8d

Zirochkaa temporarily deployed to more-secrets December 23, 2021 15:15 Inactive

jrhizor temporarily deployed to more-secrets December 23, 2021 15:15 Inactive

htrueman approved these changes Dec 23, 2021

View reviewed changes

jrhizor temporarily deployed to more-secrets December 23, 2021 15:40 Inactive

9017 Bump connector's version

7f03e10

Zirochkaa merged commit 7f14731 into master Dec 23, 2021

Zirochkaa deleted the oleh/9017-fix-filters-stream branch December 23, 2021 15:53

Zirochkaa temporarily deployed to more-secrets December 23, 2021 15:53 Inactive

jrhizor mentioned this pull request Dec 27, 2021

Bump Airbyte version from 0.35.1-alpha to 0.35.2-alpha #9119

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Source Jira: Fix fetching and update schema for `filters` stream #9079

🐛 Source Jira: Fix fetching and update schema for `filters` stream #9079

Zirochkaa commented Dec 23, 2021 •

edited

Loading

Zirochkaa commented Dec 23, 2021 •

edited by github-actions bot

Loading

Zirochkaa commented Dec 23, 2021 •

edited by github-actions bot

Loading

Zirochkaa commented Dec 23, 2021 •

edited by github-actions bot

Loading

Zirochkaa commented Dec 23, 2021 •

edited by github-actions bot

Loading

Zirochkaa commented Dec 23, 2021 •

edited by github-actions bot

Loading

🐛 Source Jira: Fix fetching and update schema for filters stream #9079

🐛 Source Jira: Fix fetching and update schema for filters stream #9079

Conversation

Zirochkaa commented Dec 23, 2021 • edited Loading

Bug-fix Request

Reason

Confirmation

How does the code change in the PR fix the issue?

Zirochkaa commented Dec 23, 2021 • edited by github-actions bot Loading

Zirochkaa commented Dec 23, 2021 • edited by github-actions bot Loading

Zirochkaa commented Dec 23, 2021 • edited by github-actions bot Loading

Zirochkaa commented Dec 23, 2021 • edited by github-actions bot Loading

Zirochkaa commented Dec 23, 2021 • edited by github-actions bot Loading

🐛 Source Jira: Fix fetching and update schema for `filters` stream #9079

🐛 Source Jira: Fix fetching and update schema for `filters` stream #9079

Zirochkaa commented Dec 23, 2021 •

edited

Loading

Zirochkaa commented Dec 23, 2021 •

edited by github-actions bot

Loading

Zirochkaa commented Dec 23, 2021 •

edited by github-actions bot

Loading

Zirochkaa commented Dec 23, 2021 •

edited by github-actions bot

Loading

Zirochkaa commented Dec 23, 2021 •

edited by github-actions bot

Loading

Zirochkaa commented Dec 23, 2021 •

edited by github-actions bot

Loading