Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove foreign key from actor_oauth_parameter table #9112

Merged
merged 4 commits into from
Dec 27, 2021

Conversation

subodh1810
Copy link
Contributor

@subodh1810 subodh1810 commented Dec 24, 2021

In the migration V0_32_8_001__AirbyteConfigDatabaseDenormalization we were skipping writing the source oauth parameter and destination oauth parameter in the new normalized table actor_oauth_parameter if the workspace was null but that was a mistake. If the workspace is null it means the param should be used globally
ref :

@subodh1810 subodh1810 self-assigned this Dec 24, 2021
@subodh1810 subodh1810 temporarily deployed to more-secrets December 24, 2021 21:05 Inactive
@subodh1810 subodh1810 temporarily deployed to more-secrets December 24, 2021 22:03 Inactive
@subodh1810 subodh1810 temporarily deployed to more-secrets December 24, 2021 22:15 Inactive
@subodh1810 subodh1810 temporarily deployed to more-secrets December 24, 2021 22:31 Inactive
@subodh1810 subodh1810 temporarily deployed to more-secrets December 24, 2021 22:43 Inactive
Copy link
Contributor

@davinchia davinchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving since I don't want to block you.

PR itself makes sense but I don't entirely understand what the initial issue was and thus how this solves it.

I also wasn't able to find the actor table in https://docs.google.com/document/d/10jX7yhkPfP3_8DwasQNw73y_WVXuyJQ0q1wvB8j7uSY/edit#.

Would appreciate a longer PR description in the future.

@subodh1810 subodh1810 merged commit 0a1dc54 into master Dec 27, 2021
@subodh1810 subodh1810 deleted the remove-foreign-key-actor-oauth branch December 27, 2021 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants