-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google ads added fields and reports #9310
Changes from 1 commit
0ee1ad1
fe5e4ba
5a0808f
eeabecf
75bed83
5494b20
3f5c981
ea95e02
f5ce674
9702a94
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,9 @@ | |
"ad_group_ad.ad.legacy_responsive_display_ad.accent_color": { | ||
"type": ["null", "string"] | ||
}, | ||
"ad_group.id": { | ||
"type": ["null", "string"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @schlattk type must be "integer", not "string". There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @augan-rymkhan let me know if any further changes are needed |
||
}, | ||
"customer.currency_code": { | ||
"type": ["null", "string"] | ||
}, | ||
|
@@ -171,6 +174,9 @@ | |
"segments.day_of_week": { | ||
"type": ["null", "string"] | ||
}, | ||
"segments.keyword.ad_group_criterion": { | ||
"type": ["null", "string"] | ||
}, | ||
"ad_group_ad.ad.expanded_text_ad.description": { | ||
"type": ["null", "string"] | ||
}, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -238,6 +238,24 @@ | |
}, | ||
"campaign.video_brand_safety_suitability": { | ||
"type": ["null", "string"] | ||
}, | ||
"metrics.clicks": { | ||
"type": ["null", "integer"] | ||
}, | ||
"metrics.cost_micros": { | ||
"type": ["null", "integer"] | ||
}, | ||
"metrics.impressions": { | ||
"type": ["null", "number"] | ||
}, | ||
"metrics.video_views": { | ||
"type": ["null", "number"] | ||
}, | ||
"metrics.video_quartile_p100_rate": { | ||
"type": ["null", "number"] | ||
}, | ||
"segments.date": { | ||
"type": ["null", "string"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Better to add |
||
} | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -137,10 +137,6 @@ | |
"metrics.ctr": { | ||
"type": ["null", "number"] | ||
}, | ||
"segments.date": { | ||
"type": ["null", "string"], | ||
"format": "date" | ||
}, | ||
"segments.day_of_week": { | ||
"type": ["null", "string"] | ||
}, | ||
|
@@ -210,6 +206,9 @@ | |
"ad_group_criterion.tracking_url_template": { | ||
"type": ["null", "string"] | ||
}, | ||
"ad_group_criterion.keyword.match_type": { | ||
"type": ["null", "string"] | ||
}, | ||
"ad_group_criterion.url_custom_parameters": { | ||
"type": ["null", "array"], | ||
"items": { | ||
|
@@ -248,6 +247,9 @@ | |
}, | ||
"segments.year": { | ||
"type": ["null", "integer"] | ||
}, | ||
"segments.date": { | ||
"type": ["null", "integer"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @schlattk Why There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @augan-rymkhan ok thanks if you could have another look |
||
} | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
{ | ||
"$schema": "http://json-schema.org/draft-07/schema#", | ||
"type": "object", | ||
"properties": { | ||
"ad_group.id": { | ||
"type": ["null", "integer"] | ||
}, | ||
"campaign.bidding_strategy_type": { | ||
"type": ["null", "string"] | ||
}, | ||
"metrics.clicks": { | ||
"type": ["null", "integer"] | ||
}, | ||
"metrics.cost_micros": { | ||
"type": ["null", "integer"] | ||
}, | ||
"ad_group_criterion.keyword.text": { | ||
"type": ["null", "string"] | ||
}, | ||
"metrics.impressions": { | ||
"type": ["null", "integer"] | ||
}, | ||
"ad_group_criterion.keyword.text": { | ||
"type": ["null", "string"] | ||
}, | ||
"ad_group_criterion.keyword.match_type": { | ||
"type": ["null", "string"] | ||
}, | ||
"ad_group_criterion.criterion_id": { | ||
"type": ["null", "integer"] | ||
}, | ||
"segments.date": { | ||
"type": ["null", "integer"] | ||
}, | ||
"segments.ad_network_type": { | ||
"type": ["null", "integer"] | ||
} | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,6 +23,7 @@ | |
ClickView, | ||
DisplayKeywordPerformanceReport, | ||
DisplayTopicsPerformanceReport, | ||
KeywordView, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @schlattk stream |
||
ShoppingPerformanceReport, | ||
UserLocationReport, | ||
) | ||
|
@@ -74,6 +75,7 @@ def streams(self, config: Mapping[str, Any]) -> List[Stream]: | |
AdGroupAds(api=google_api), | ||
AdGroups(api=google_api), | ||
Accounts(api=google_api), | ||
Campaigns(api=google_api), | ||
Campaigns(**incremental_stream_config), | ||
augan-rymkhan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
ClickView(**incremental_stream_config), | ||
KeywordView(**incremental_stream_config) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No need in |
||
] + custom_query_streams |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -129,7 +129,7 @@ class Accounts(GoogleAdsStream): | |
primary_key = "customer.id" | ||
|
||
|
||
class Campaigns(GoogleAdsStream): | ||
class Campaigns(IncrementalGoogleAdsStream): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Configured stream "campaigns" should be updated in
|
||
""" | ||
Campaigns stream: https://developers.google.com/google-ads/api/fields/v8/campaign | ||
""" | ||
|
@@ -202,3 +202,8 @@ class ClickView(IncrementalGoogleAdsStream): | |
|
||
time_unit = "days" | ||
days_of_data_storage = 90 | ||
|
||
class KeywordView(IncrementalGoogleAdsStream): | ||
""" | ||
KeywordView stream: https://developers.google.com/google-ads/api/fields/v8/keyword_view | ||
""" |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
{ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Configured streams provided in json files should not be placed in the root of the connector.
|
||
"streams": [ | ||
{ | ||
"stream": { | ||
"name": "ad_group_ad_report", | ||
"json_schema": {}, | ||
"supported_sync_modes": ["full_refresh", "incremental"], | ||
"source_defined_cursor": true, | ||
"default_cursor_field": ["segments.date"] | ||
}, | ||
"sync_mode": "incremental", | ||
"destination_sync_mode": "overwrite", | ||
"cursor_field": ["segments.date"] | ||
} | ||
] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
{ | ||
"streams": [ | ||
{ | ||
"stream": { | ||
"name": "campaigns", | ||
"json_schema": {}, | ||
"supported_sync_modes": ["full_refresh"], | ||
"source_defined_primary_key": [["campaign.id"]] | ||
}, | ||
"sync_mode": "full_refresh", | ||
"destination_sync_mode": "overwrite" | ||
} | ||
] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
{ | ||
"streams": [ | ||
{ | ||
"stream": { | ||
"name": "click_view", | ||
"json_schema": {}, | ||
"supported_sync_modes": ["full_refresh", "incremental"], | ||
"source_defined_cursor": true, | ||
"default_cursor_field": ["segments.date"] | ||
}, | ||
"sync_mode": "incremental", | ||
"destination_sync_mode": "overwrite", | ||
"cursor_field": ["segments.date"] | ||
} | ||
] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
{ | ||
"streams": [ | ||
{ | ||
"stream": { | ||
"name": "display_keyword_performance_report", | ||
"json_schema": {}, | ||
"supported_sync_modes": ["full_refresh", "incremental"], | ||
"source_defined_cursor": true, | ||
"default_cursor_field": ["segments.date"] | ||
}, | ||
"sync_mode": "incremental", | ||
"destination_sync_mode": "overwrite", | ||
"cursor_field": ["segments.date"] | ||
} | ||
] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
{ | ||
"streams": [ | ||
{ | ||
"stream": { | ||
"name": "keyword_view", | ||
"json_schema": {}, | ||
"supported_sync_modes": ["full_refresh", "incremental"], | ||
"source_defined_cursor": true, | ||
"default_cursor_field": ["segments.date"] | ||
}, | ||
"sync_mode": "incremental", | ||
"destination_sync_mode": "overwrite", | ||
"cursor_field": ["segments.date"] | ||
} | ||
] | ||
|
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keyword_view
stream was already added.You should update your forked repo from the original repo. And resolve the Merge conflicts.
https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/connectors/source-google-ads/source_google_ads/google_ads.py#L27
https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/connectors/source-google-ads/source_google_ads/streams.py#L206
https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/connectors/source-google-ads/source_google_ads/schemas/keyword_report.json
https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/connectors/source-google-ads/integration_tests/configured_catalog.json#L53