-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google ads added fields and reports #9310
Changes from 4 commits
0ee1ad1
fe5e4ba
5a0808f
eeabecf
75bed83
5494b20
3f5c981
ea95e02
f5ce674
9702a94
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -137,10 +137,6 @@ | |
"metrics.ctr": { | ||
"type": ["null", "number"] | ||
}, | ||
"segments.date": { | ||
"type": ["null", "string"], | ||
"format": "date" | ||
}, | ||
"segments.day_of_week": { | ||
"type": ["null", "string"] | ||
}, | ||
|
@@ -210,6 +206,9 @@ | |
"ad_group_criterion.tracking_url_template": { | ||
"type": ["null", "string"] | ||
}, | ||
"ad_group_criterion.keyword.match_type": { | ||
"type": ["null", "string"] | ||
}, | ||
"ad_group_criterion.url_custom_parameters": { | ||
"type": ["null", "array"], | ||
"items": { | ||
|
@@ -248,6 +247,9 @@ | |
}, | ||
"segments.year": { | ||
"type": ["null", "integer"] | ||
}, | ||
"segments.date": { | ||
"type": ["null", "integer"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @schlattk Why There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @augan-rymkhan ok thanks if you could have another look |
||
} | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -67,6 +67,24 @@ | |
"segments.date": { | ||
"type": ["null", "string"], | ||
"format": "date" | ||
}, | ||
"campaign.bidding_strategy_type": { | ||
"type": ["null", "string"] | ||
}, | ||
"metrics.clicks": { | ||
"type": ["null", "integer"] | ||
}, | ||
"metrics.cost_micros": { | ||
"type": ["null", "integer"] | ||
}, | ||
"metrics.impressions": { | ||
"type": ["null", "integer"] | ||
}, | ||
"ad_group_criterion.criterion_id": { | ||
"type": ["null", "integer"] | ||
}, | ||
"segments.ad_network_type": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @schlattk Error happens because this field was added. message: "Cannot select the following segments because at least one unsupported metric is found in SELECT or WHERE clause: \'segments.ad_network_type\'(unsupported metrics: \'historical_quality_score\')."\n}\nrequest_id: "hBx3G90_bSZ-rVpnBMQlxQ"\n, 'hBx3G90_bSZ-rVpnBMQlxQ')"}} There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It works when There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @augan-rymkhan ok but it is a supported field according to documentation and also it has been running live for a long time without any errors. What do you suggest is the solution? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @schlattk It seems we can not query In docs: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes @augan-rymkhan that appears to be the problem. Ok, I removed the field I think we can most probably do without it in this report. |
||
"type": ["null", "integer"] | ||
} | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,6 +25,7 @@ | |
ClickView, | ||
DisplayKeywordPerformanceReport, | ||
DisplayTopicsPerformanceReport, | ||
KeywordView, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @schlattk stream |
||
GeographicReport, | ||
KeywordReport, | ||
ShoppingPerformanceReport, | ||
|
@@ -111,11 +112,21 @@ def streams(self, config: Mapping[str, Any]) -> List[Stream]: | |
incremental_stream_config = self.get_incremental_stream_config(google_api, config, tz=time_zone) | ||
|
||
streams = [ | ||
<<<<<<< HEAD | ||
AdGroupAds(api=google_api), | ||
AdGroups(api=google_api), | ||
Accounts(api=google_api), | ||
======= | ||
AdGroupAds(**incremental_stream_config), | ||
AdGroups(**incremental_stream_config), | ||
Accounts(**incremental_stream_config), | ||
>>>>>>> master | ||
Campaigns(**incremental_stream_config), | ||
augan-rymkhan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
ClickView(**incremental_stream_config), | ||
<<<<<<< HEAD | ||
KeywordView(**incremental_stream_config) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No need in |
||
] + custom_query_streams | ||
======= | ||
] | ||
|
||
custom_query_streams = [ | ||
|
@@ -139,3 +150,4 @@ def streams(self, config: Mapping[str, Any]) -> List[Stream]: | |
] | ||
) | ||
return streams | ||
>>>>>>> master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@schlattk type must be "integer", not "string".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@augan-rymkhan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@augan-rymkhan let me know if any further changes are needed