-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comprehensive CI tests on min/max supported versions of dependencies #915
Conversation
@weiji14 @lgvaz I spent a lot time figuring out how to make all the dependencies play nicely with each other, that's how I updated the For example, if we don't have the right fastai version, the latter might install another version of both Base on that experience, I think we need to pin the versions for fastai, pytorch-lightning, albumentations Here is my last experiment in updating the
We need to pin the following dependencies:
The mmcv and mmdet compatible versions will be:
MMLabs have a pypi package (
|
Using |
Ok, I've updated the workflow to use mmcv-full=1.3.13 which seems to include the fix according to open-mmlab/mmdetection#5367 (comment). Will see if the tests pass.
They're showing up as two separate items no? Might wait for #919 to get merged since the updated |
pip install torch==${{ matrix.torch-version }} torchvision==${{ matrix.torchvision-version }} -f https://download.pytorch.org/whl/torch_stable.html | ||
pip install mmcv-full==${{ matrix.mmcv-full-version }} -f https://download.openmmlab.com/mmcv/dist/cpu/torch${{ matrix.torch-version }}/index.html | ||
pip install mmdet==${{ matrix.mmdet-version }} | ||
pip install -e ".[all,dev]" | ||
pip install yolov5-icevision --upgrade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MMLabs have a pypi package (
openmim
) that automagically installs the right versions of both mmcv and mmdet without providingtorch
andcuda
versions. That's how I'm using it:pip install openmim -q mim install mmcv-full mim install mmdet
Thanks for chipping in @ai-fast-track! So do you suggest doing something like this? And do I need to add a pip install fastai
line here (before pip install -e .[all,dev]
)?
pip install torch==${{ matrix.torch-version }} torchvision==${{ matrix.torchvision-version }} -f https://download.pytorch.org/whl/torch_stable.html | |
pip install mmcv-full==${{ matrix.mmcv-full-version }} -f https://download.openmmlab.com/mmcv/dist/cpu/torch${{ matrix.torch-version }}/index.html | |
pip install mmdet==${{ matrix.mmdet-version }} | |
pip install -e ".[all,dev]" | |
pip install yolov5-icevision --upgrade | |
pip install torch==${{ matrix.torch-version }} torchvision==${{ matrix.torchvision-version }} -f https://download.pytorch.org/whl/torch_stable.html | |
pip install openmim | |
mim install mmcv-full==${{ matrix.mmcv-full-version }} | |
mim install mmdet==${{ matrix.mmdet-version }} | |
pip install -e ".[all,dev]" | |
pip install yolov5-icevision --upgrade |
Modify CI test matrix to run on two streams - a minimum version stream and maximum version stream. Follow up of #914.
Specifically, the two streams are:
Feel free to suggest modifications and/or include more versions of other dependencies (e.g. those listed at https://github.com/airctic/icevision/blob/0.8.1/setup.cfg#L28-L39). I can also include a 'middle' version stream to test e.g. Pytorch 1.8.0, torchvision 0.9.0, etc if that would be better.
References: