fix: airflow.{fernetKey,webserverSecretKey} overshadow _CMD configs
#508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the two alternate environment variables to be used for setting the fernet and webserver secret keys. The priority support given via the airflow.fernetKey and airflow.webserverSecretKey options prevented the use of these since the variables being set have a higher order of precedence when compared to the _CMD or _SECRET alternatives. Signed-off-by: Alexander O'Donovan-Jones <alexodonovanjones@gmail.com>
Signed-off-by: Alexander O'Donovan-Jones <alexodonovanjones@gmail.com>
|
@aodj thanks for this PR! I have made some changes to your branch so it can be ready to merge in |
thesuperzapper
changed the title
airflow.{fernetKey,webserverSecretKey} overriding _CMD and _SECRET
thesuperzapper
approved these changes
Mar 22, 2022
thesuperzapper
added
the
status/ready-to-merge
thesuperzapper
changed the title
airflow.{fernetKey,webserverSecretKey} overriding _CMD and _SECRETairflow.fernetKey and airflow.webserverSecretKey overshadow _CMD configs
thesuperzapper
changed the title
airflow.fernetKey and airflow.webserverSecretKey overshadow _CMD configsairflow.{fernetKey,webserverSecretKey} overshadow _CMD configs
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issues does your PR fix?
airflow.fernetKeyandairflow.webserverSecretKeyovershadow_CMDconfigs #506What does your PR do?
AIRFLOW__CORE__FERNET_KEYandAIRFLOW__WEBSERVER__SECRET_KEYwhen the values ofairflow.fernetKeyandairflow.webserverSecretKeyare non-empty._CMDand_SECRETvariables, which are currently overshadowed by their non-suffixed versions.Checklist
For all Pull Requests
For releasing ONLY