fix: ScriptedContracts in Origination #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Origination operation has a "script" field. Tezos description says: [https://tezos.gitlab.io/shell/p2p_api.html#origination-tag-109] - size: determined from data - contents: $alpha.scripted.contracts The ScriptedContracts type is matching the definition of $alpha.scripted.contracts [https://tezos.gitlab.io/shell/p2p_api.html#alpha-scripted-contracts] - # bytes in next field, 4 bytes, unsigned 30-bit big-endian integer - code, Variable, bytes - # bytes in next field, 4 bytes, unsigned 30-bit big-endian integer - storage, Variable, bytes Fixed the definition of TezosOriginationOperation to match the TezosRPC specification.
IsaccoSordo
approved these changes
Aug 14, 2024
|
Hi @dianasavvatina, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Changed the type of
TezosOriginationOperation.scriptfromstringtoScriptedContracts.Why:
The
stringtype doesn't match the Tezos RPC specification.Details:
The Origination operation has a
scriptfield with the following parameters: (doc)size: determined from datacontents:$alpha.scripted.contractsThe
ScriptedContractstype is matching the definition of $alpha.scripted.contracts (doc)# bytes in next field, 4 bytes, unsigned 30-bit big-endian integercode, Variable, bytes# bytes in next field, 4 bytes, unsigned 30-bit big-endian integerstorage, Variable, bytesFixed the definition of
TezosOriginationOperationto match the Tezos RPC specification.