Forbid imports of shaded Guava and OkHttp classes

airlift · Aug 8, 2020 · d388f8a · d388f8a
1 parent 8de1efe
commit d388f8a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,3 +1,8 @@
+Airbase 103
+
+* Checkstyle updates:
+  - Forbid imports of shaded Guava and OkHttp classes.
+
 Airbase 102
 
 * Add dependencies:

diff --git a/airbase-policy/src/main/resources/checkstyle/airbase-checks.xml b/airbase-policy/src/main/resources/checkstyle/airbase-checks.xml
@@ -225,6 +225,10 @@
 
         <module name="IllegalImport">
             <property name="illegalPkgs" value=".*\.\$internal" />
+            <!-- Shaded Guava -->
+            <property name="illegalPkgs" value=".*\.com\.google\.common" />
+            <!-- Shaded okhttp3; match "shaded", since "com.example.okhttp3" could be OK HTTP-specific code within com.example -->
+            <property name="illegalPkgs" value=".*\.shaded\.okhttp3" />
             <property name="regexp" value="true" />
         </module>
     </module>