Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate clusterctl rollout into airshipctl #433

Open
lb4368 opened this issue Dec 9, 2020 · 3 comments
Open

Integrate clusterctl rollout into airshipctl #433

lb4368 opened this issue Dec 9, 2020 · 3 comments
Assignees
Labels
7-NiceToHave Relates to issues of lower priority that are not part of critical functionality or have work arounds enhancement New feature or request priority/low Items that are considered non-critical for functionality, such as quality of life improvements size l
Milestone

Comments

@lb4368
Copy link

lb4368 commented Dec 9, 2020

Proposed change
Integrate airshipctl with clusterctl rollout so that we can take advantage of the feature to rollout updates to the cluster currently being managed by airshipctl.

clusterctl rollout

  • clusterctl rollout kubernetes-sigs/cluster-api#3439
  • clusterctl rollout command provides users with a convenient and consistent means through which to rollout an update, monitor the status of an update, rollback to a specific update and view the history of past updates.
  • Currently focused on MachineDeployment with support for KubeadmControlPlane coming later.
  • Long-term goal is to add the command under kubectl rollout.

Integrate with airshipctl cluster rollout

@lb4368 lb4368 added enhancement New feature or request triage Needs evaluation by project members 7-NiceToHave Relates to issues of lower priority that are not part of critical functionality or have work arounds labels Dec 9, 2020
@jezogwza jezogwza added this to the postV2.0 milestone Dec 9, 2020
@lb4368
Copy link
Author

lb4368 commented Dec 9, 2020

@Arvinderpal - I believe you were going to take this one

@jezogwza jezogwza added priority/low Items that are considered non-critical for functionality, such as quality of life improvements and removed triage Needs evaluation by project members labels Dec 9, 2020
@Arvinderpal
Copy link
Contributor

Yes, please assign it to me.

@Arvinderpal
Copy link
Contributor

Update:
With v0.4.0, the rollout command is part of clusterctl. There are a couple of sub-commands, namely status and history that still need to be implemented. They are dependent kubernetes-sigs/cluster-api#3486 which I'm also working on. Progress has been slow due to a lack of reviewers within the CAPI community.

Also, in airship, we have recently switched to using clusterctl as a binary (via KRM funcs). In the original model, clusterctl was consumed as a library and therefore to use these new commands, some level of code integration was needed. We may need to reassess how best to incorporate these commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7-NiceToHave Relates to issues of lower priority that are not part of critical functionality or have work arounds enhancement New feature or request priority/low Items that are considered non-critical for functionality, such as quality of life improvements size l
Projects
None yet
Development

No branches or pull requests

4 participants