Add conditions to MachineDeployment Object

[Arvinderpal]

User Story
As a developer/user/operator I would like to have conditions documenting the operational state of MachineDeployment objects.

Anything else you would like to add:
As required by the condition CAEP, the MachineDeployment objects should also provide a Ready condition describing the overall state of the object.

Tasks:

• Summary ReadyCondition and Node availability condition AvailableCondition ✨ Adds AvailableCondition and ReadyCondition Conditions to MachineDeployment #4625
• MachineSet related conditions: MachinesCreatedCondition, MachinesReadyCondition and ResizedCondition ✨ Add Conditions to MachineSet for Machine Create and Ready #5056
• MachineDeployment scaling related conditions: MachinesSpecUpToDateCondition and ResizedCondition
• Remove the use of Phases
• Cleanup: Change calculateStatus() --> updateStatus() to be consistent with the rest of the code base.

Related: Conditions for KCP

/kind feature

[Arvinderpal]

Ideally, we would have something similar to DeploymentProgressing.

This is more to bring in line with how kubectl rollout status works. With clusterctl rollout status my-md-0 we would also watch the progression of the MD by looking at MachinesReadyCondition. I think that would accomplish something similar.

[Arvinderpal]

/cc @fabriziopandini

[vincepri]

/milestone v0.4.0

[vincepri]

/milestone v0.4.0

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[detiber]

/remove-lifecycle stale

[Arvinderpal]

Can I be assigned this ticket? Not that anyone else is jumping to work on it 😆
I'll need this for the clusterctl rollout status command: #3439

[vincepri]

@Arvinderpal Sure, feel free to take it!

/priority important-soon
/assign @Arvinderpal

[Arvinderpal]

@vincepri @detiber I have the PR ready. PTAL
#4174

[fabriziopandini]

/lifecycle active

[CecileRobertMichon]

/kind release-blocking

[vincepri]

@fabriziopandini to check if the PR is ready to go and double check the release blocking status

[enxebre]

/area api

[vincepri]

/milestone v1.0

[fabriziopandini]

/triage accepted

[k8s-triage-robot]

This issue is labeled with priority/important-soon but has not been updated in over 90 days, and should be re-triaged.
Important-soon issues must be staffed and worked on either currently, or very soon, ideally in time for the next release.

You can:

• Confirm that this issue is still relevant with /triage accepted (org members only)
• Deprioritize it with /priority important-longterm or /priority backlog
• Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

[fabriziopandini]

/triage accepted

[fabriziopandini]

/remove-priority important-soon
/priority backlog

[fabriziopandini]

/help

[k8s-ci-robot]

@fabriziopandini:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[enxebre]

cc @muraee

[k8s-triage-robot]

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

• Confirm that this issue is still relevant with /triage accepted (org members only)
• Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

[sbueringer]

Solution is proposed in #10897

/close

[k8s-ci-robot]

@sbueringer: Closing this issue.

In response to this:

Solution is proposed in #10897

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.