Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move test/test_show.py fixture to conftest.py #1122

Merged
merged 2 commits into from
Mar 10, 2022
Merged

Move test/test_show.py fixture to conftest.py #1122

merged 2 commits into from
Mar 10, 2022

Conversation

dorothykiz1
Copy link
Contributor

xref #1030

@dorothykiz1 dorothykiz1 mentioned this pull request Mar 9, 2022
Closed
@dorothykiz1
Copy link
Contributor Author

dorothykiz1 commented Mar 9, 2022 •
edited
Loading

@datapythonista this PR is ready for your review, I also noticed first, the PyPy 3.8 CI had failed as the PyPy 3.7 CI was still loading, then after it all finally passed, just wondering if it is something to worry about.

@datapythonista datapythonista merged commit 8f5c6af into airspeed-velocity:master Mar 10, 2022
@datapythonista
Copy link
Member

Thanks @dorothykiz1. Would be nice to have some context on how many fixtures we're moving. Can you add the list of the ones that still need to be moved to the issue?

@dorothykiz1
Copy link
Contributor Author

Thanks @datapythonista ,I will do this

@dorothykiz1 dorothykiz1 mentioned this pull request Mar 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dorothykiz1 @datapythonista