-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error message when environment not found #1369
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks this looks great. Could you please prefix the commit with MAINT:
?
Do I really need to? If this won't be merged otherwise I can, but it's a bit of a pain to go back and rewrite commit messages. |
It is the project convention, I can force push it and merge it though. No worries. |
Co-authored-by: Rohit Goswami <r95g10@gmail.com>
2f26e9a
to
ab7bf9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Might be nice (separately) to add a page to the documentation listing the plugins and their installation requirements, but that would probably be more in scope for #1370.
Thanks @dstansby 🚀 |
Inspired by #1353, this improves the error message when an environment type isn't found.
Before:
Unknown environment type 'mamba'.
After:
Unknown environment type 'mamba'. Possible values are ['existing', 'conda', 'virtualenv']