Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when environment not found #1369

Merged
merged 2 commits into from
Jan 27, 2024

Conversation

dstansby
Copy link
Contributor

Inspired by #1353, this improves the error message when an environment type isn't found.

Before: Unknown environment type 'mamba'.
After: Unknown environment type 'mamba'. Possible values are ['existing', 'conda', 'virtualenv']

@dstansby dstansby marked this pull request as ready for review January 17, 2024 14:45
Copy link
Member

@HaoZeke HaoZeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this looks great. Could you please prefix the commit with MAINT: ?

asv/environment.py Outdated Show resolved Hide resolved
@dstansby
Copy link
Contributor Author

Thanks this looks great. Could you please prefix the commit with MAINT: ?

Do I really need to? If this won't be merged otherwise I can, but it's a bit of a pain to go back and rewrite commit messages.

@HaoZeke
Copy link
Member

HaoZeke commented Jan 27, 2024

Thanks this looks great. Could you please prefix the commit with MAINT: ?

Do I really need to? If this won't be merged otherwise I can, but it's a bit of a pain to go back and rewrite commit messages.

It is the project convention, I can force push it and merge it though. No worries.

Copy link
Member

@HaoZeke HaoZeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Might be nice (separately) to add a page to the documentation listing the plugins and their installation requirements, but that would probably be more in scope for #1370.

@HaoZeke HaoZeke merged commit 2f45881 into airspeed-velocity:master Jan 27, 2024
10 of 12 checks passed
@HaoZeke
Copy link
Member

HaoZeke commented Jan 27, 2024

Thanks @dstansby 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants