Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add performance increased/decreased message to asv continuous output #799

Merged
merged 3 commits into from
May 12, 2019
Merged

ENH: Add performance increased/decreased message to asv continuous output #799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81c85ee
Changing continuous status message.
rok Mar 28, 2019
5e9d954
Adding test.
rok Mar 28, 2019
9cb2f31
Adding change description.
rok Mar 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ Bug Fixes

Other Changes and Additions
^^^^^^^^^^^^^^^^^^^^^^^^^^^

- In case of significant changes ``asv continuous`` message now reports
if performance decreased or increased.

0.3.1 (2018-10-20)
------------------
Expand Down
2 changes: 2 additions & 0 deletions asv/commands/continuous.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,10 @@ def results_iter(commit_hash):
color_print("")
if worsened:
color_print("SOME BENCHMARKS HAVE CHANGED SIGNIFICANTLY.", 'red')
color_print("PERFORMANCE DECREASED.", 'red')
elif improved:
color_print("SOME BENCHMARKS HAVE CHANGED SIGNIFICANTLY.", 'green')
color_print("PERFORMANCE INCREASED.", 'green')
else:
color_print("BENCHMARKS NOT SIGNIFICANTLY CHANGED.", 'green')

Expand Down
1 change: 1 addition & 0 deletions test/test_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ def test_continuous(capfd, basic_conf):

text, err = capfd.readouterr()
assert "SOME BENCHMARKS HAVE CHANGED SIGNIFICANTLY" in text
assert "PERFORMANCE INCREASED" in text or "PERFORMANCE DECREASED" in text
assert "+ 1 6 6.00 params_examples.track_find_test(2)" in text
assert "params_examples.ClassOne" in text

Expand Down