Fix PEP-8 violations reported by flake8 on asv folder

.github/workflows/ci.yml

@@ -11,6 +11,9 @@ jobs:
 
       - name: Install dependencies
         run: pip install flake8
+
+      - name: flake8 all repo only show erros
+        run: flake8 . || true # preventing CI failing while flake8 issues exist
 
-      - name: flake8
-        run: flake8 . || true # preventing CI failing while flake8 issues exist
+      - name: flake8 validating correct file(s)
+        run: flake8 asv/step_detect.py asv/runner.py asv/results.py asv/repo.py asv/main.py

asv/main.py

@@ -10,9 +10,7 @@
 import six
 
 from . import commands
-from .config import Config
 from .console import log
-from .plugin_manager import plugin_manager
 from . import util
 
 

asv/repo.py

@@ -97,7 +97,7 @@ def get_range_spec(self, commit_a, commit_b):
 
     def get_new_range_spec(self, latest_result, branch=None):
         """
-        Returns a formatted string giving the results between the 
+        Returns a formatted string giving the results between the
         latest result and the newest hash in a given branch.
         If no branch given, use the 'master' branch.
         """
@@ -288,6 +288,7 @@ def get_branch_commits(self, branch):
     def get_new_branch_commits(self, branches, existing):
         self._raise_error()
 
+
 def get_repo(conf):
     """
     Get a Repo subclass for the given configuration.

asv/results.py

@@ -12,7 +12,6 @@
 import itertools
 import hashlib
 import datetime
-import collections
 
 import six
 from six.moves import zip as izip
@@ -41,7 +40,7 @@ def iter_results_paths(results):
                 raise util.UserError("malformed {0}".format(machine_json))
         except util.UserError as err:
             machine_json_err = "Skipping results: {0}".format(six.text_type(err))
-        except IOError as err:
+        except IOError:
             machine_json_err = "Skipping results: could not load {0}".format(
                 machine_json)
         else:
@@ -990,7 +989,7 @@ def do_formatting(num_column_params):
 
         for j, values in enumerate(itertools.product(*row_params)):
             row_results = [util.human_value(x[0], benchmark['unit'], err=x[1])
-                           for x in result[j*column_items:(j+1)*column_items]]
+                           for x in result[j * column_items:(j + 1) * column_items]]
             row = [_format_param_value(value) for value in values] + row_results
             rows.append(row)
 
@@ -1005,7 +1004,7 @@ def do_formatting(num_column_params):
 
     # Determine how many parameters can be fit to columns
     if max_width is None:
-        max_width = util.get_terminal_width() * 3//4
+        max_width = util.get_terminal_width() * 3 // 4
 
     text = do_formatting(0)
     for j in range(1, len(benchmark['params'])):

asv/runner.py

@@ -8,7 +8,6 @@
 import json
 import os
 import sys
-import re
 import time
 import tempfile
 import itertools
@@ -23,7 +22,6 @@
 
 from .console import log
 from .results import Results, format_benchmark_result
-from . import statistics
 from . import util
 
 
@@ -206,7 +204,7 @@ def iter_run_items():
 
                     if run_round > rounds:
                         if (not append_samples and
-                                run_round == run_rounds[-1] and
+                            run_round == run_rounds[-1] and
                                 name in existing_results):
                             # We need to remove samples here so that
                             # append_samples=False has an effect on all
@@ -314,7 +312,8 @@ def iter_run_items():
                 # Mark benchmark as failed
                 partial_info_time = None
                 log.warning('{0} skipped (setup_cache failed)'.format(name))
-                stderr = 'asv: setup_cache failed\n\n{}'.format(failed_setup_cache[setup_cache_key])
+                stderr = 'asv: setup_cache failed\n\n{}'.format(
+                    failed_setup_cache[setup_cache_key])
                 res = fail_benchmark(benchmark, stderr=stderr)
                 results.add_result(benchmark, res,
                                    selected_idx=selected_idx,
@@ -766,7 +765,7 @@ def _stdout_reader(self):
             out = self.server_proc.stdout.read()
             self.server_proc.stdout.close()
             out = out.decode('utf-8', 'replace')
-        except Exception as exc:
+        except Exception:
             import traceback
             out = traceback.format_exc()
 

asv/statistics.py

@@ -243,6 +243,7 @@ def quantile(x, q):
 
 _mann_whitney_u_memo = {}
 
+
 def mann_whitney_u(x, y, method='auto'):
     """
     Mann-Whitney U test
@@ -333,7 +334,7 @@ def mann_whitney_u_cdf(m, n, u, memo=None):
         memo = {}
     cdf = 0
     for uu in range(u + 1):
-         cdf += mann_whitney_u_pmf(m, n, uu, memo)
+        cdf += mann_whitney_u_pmf(m, n, uu, memo)
     return cdf
 
 
@@ -387,7 +388,7 @@ def binom_pmf(n, k, p):
     logp = math.log(p)
     log1mp = math.log(1 - p)
     return math.exp(lgamma(1 + n) - lgamma(1 + n - k) - lgamma(1 + k)
-                        + k*logp + (n - k)*log1mp)
+                    + k*logp + (n - k)*log1mp)
 
 
 _BERNOULLI = [1.0, -0.5, 0.166666666667, 0.0, -0.0333333333333, 0.0, 0.0238095238095]
@@ -656,4 +657,3 @@ def ppf(self, cdf):
         cdfx = min(cdf * self._cdf_norm, self._cdf_norm)
         beta = self._ppf_unnorm(cdfx)
         return beta * self._y_scale + self.mle
-