Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace radio buttons with clickable buttons in Mesop UI #302

Merged
merged 5 commits into from
Oct 2, 2024

Conversation

davorrunje
Copy link
Contributor

@davorrunje davorrunje commented Oct 2, 2024

Description

The list of changes:

  • replaces radio buttons with clickable buttons in Mesop UI
  • adds Error message type for errors in running workflows
  • adds exceptions with proper message for missing imports

Type of change

  • New feature (a non-breaking change that adds functionality)

Checklist

  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • I have included code examples to illustrate the modifications

@davorrunje davorrunje marked this pull request as draft October 2, 2024 09:13
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 64.28571% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
fastagency/ui/mesop/message.py 52.94% 5 Missing and 3 partials ⚠️
fastagency/ui/mesop/base.py 0.00% 4 Missing ⚠️
fastagency/helpers.py 60.00% 1 Missing and 1 partial ⚠️
fastagency/base.py 83.33% 1 Missing ⚠️
Files with missing lines Coverage Δ
fastagency/ui/mesop/data_model.py 100.00% <100.00%> (ø)
fastagency/ui/mesop/styles.py 100.00% <100.00%> (ø)
fastagency/base.py 92.30% <83.33%> (-0.49%) ⬇️
fastagency/helpers.py 60.00% <60.00%> (ø)
fastagency/ui/mesop/base.py 57.97% <0.00%> (ø)
fastagency/ui/mesop/message.py 55.08% <52.94%> (+0.71%) ⬆️

... and 2 files with indirect coverage changes

@davorrunje davorrunje marked this pull request as ready for review October 2, 2024 11:47
@davorrunje davorrunje changed the title Replace radio buttons with pushable buttons in Mesop UI Replace radio buttons with clickable buttons in Mesop UI Oct 2, 2024
@davorrunje davorrunje added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit a60a820 Oct 2, 2024
20 of 21 checks passed
@davorrunje davorrunje deleted the mesop-add-button-to-multiple-choice branch October 2, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants