Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: unable to parse OpenAPI spec #303

Merged
merged 16 commits into from
Oct 3, 2024

Conversation

sternakt
Copy link
Collaborator

@sternakt sternakt commented Oct 2, 2024

Description

Fixes #301

Type of change

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • I have included code examples to illustrate the modifications

@sternakt sternakt marked this pull request as ready for review October 3, 2024 10:52
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 82.85714% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
fastagency/api/openapi/security.py 86.95% 2 Missing and 1 partial ⚠️
fastagency/api/openapi/security_schema_visitor.py 50.00% 1 Missing and 1 partial ⚠️
fastagency/api/openapi/client.py 50.00% 0 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
fastagency/helpers.py 94.28% <100.00%> (+1.18%) ⬆️
fastagency/api/openapi/client.py 85.61% <50.00%> (-0.11%) ⬇️
fastagency/api/openapi/security_schema_visitor.py 80.00% <50.00%> (+2.22%) ⬆️
fastagency/api/openapi/security.py 84.26% <86.95%> (+1.91%) ⬆️

... and 1 file with indirect coverage changes

fastagency/api/openapi/client.py Outdated Show resolved Hide resolved
fastagency/api/openapi/client.py Outdated Show resolved Hide resolved
fastagency/api/openapi/client.py Outdated Show resolved Hide resolved
@davorrunje davorrunje changed the title 301 bug unable to parse openapi spec Fix: unable to parse OpenAPI spec Oct 3, 2024
@davorrunje davorrunje added this pull request to the merge queue Oct 3, 2024
Merged via the queue into main with commit e4f4a2d Oct 3, 2024
22 checks passed
@davorrunje davorrunje deleted the 301-bug-unable-to-parse-openapi-spec branch October 3, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: unable to parse OpenAPI spec
2 participants