Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mesop version and remove mesop patch #449

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

kumaranvpl
Copy link
Collaborator

Description

Fixes #443

Type of change

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • I have included code examples to illustrate the modifications

@kumaranvpl kumaranvpl requested a review from davorrunje October 21, 2024 07:50
@kumaranvpl kumaranvpl marked this pull request as draft October 21, 2024 07:51
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
fastagency/ui/mesop/timer.py 66.66% 1 Missing ⚠️
Files with missing lines Coverage Δ
fastagency/ui/mesop/timer.py 46.15% <66.66%> (-13.85%) ⬇️

... and 3 files with indirect coverage changes

@kumaranvpl kumaranvpl marked this pull request as ready for review October 21, 2024 08:24
@davorrunje davorrunje added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit 0cb6012 Oct 21, 2024
21 of 22 checks passed
@davorrunje davorrunje deleted the remove-mesop-patch branch October 21, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Mesop patch and upgrade Mesop package to the new version
2 participants