[fix] Small fix on Translations.get #564
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DrBu7cher Thanks for this PR, a very good idea! Maybe we should add a dedicated warning-log in this case, so the user knows what's wrong? Anyways, it would be important to have a unittest covering this, so it's not destroyed by a another change. |
bw-flagship
requested changes
Aug 30, 2023
| @@ -13,7 +13,8 @@ class Translations { | |||
|
|
|||
| /// If we failed to find the key as a nested key, then fall back | |||
| /// to looking it up like normal. | |||
| returnValue ??= _translations?[key]; | |||
| var maybeValue = _translations?[key]; | |||
There was a problem hiding this comment.
Now we do the lookup all the time, even if it's not needed because returnValue != null
| @@ -13,7 +13,8 @@ class Translations { | |||
|
|
|||
| /// If we failed to find the key as a nested key, then fall back | |||
| /// to looking it up like normal. | |||
| returnValue ??= _translations?[key]; | |||
| var maybeValue = _translations?[key]; | |||
| if (maybeValue is String) returnValue ??= maybeValue; | |||
There was a problem hiding this comment.
we need a unittest for the new behavior
jonasbadstuebner
force-pushed
the
develop
branch
from
2cf1f0e
to
041eebe
Compare
jonasbadstuebner
force-pushed
the
develop
branch
from
041eebe
to
bcf8f05
Compare
|
Good ideas, I will come back to that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got an error like this:
from
Translations.get.I had a JSON for translation like
{ "error": { "unknown": "An unknown error occurred", "unauthenticated": "You need to log in first" } }etc.
My code was trying to translate like
tr(errorString)whereerrorStringwas"error"and this led to the lookup in lib/src/translations.dart#L16 to try and put the resulting Map ({ "unknown": "An unknown error occurred", "unauthenticated": "You need to log in first" }) into a String?.
This PR fixes the problem and just gives
[🌎 Easy Localization] [WARNING] Localization key [error] not foundas expected.I did not check in any other places, if this could happen. If an error occurs somewhere else, I will open a new PR.
By the way, when will you release the next time? The last release on pub.dev was 10 months ago...?