-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static type for EasyLocalization.assetLoader (#524) #598
Open
alexeyinkin
wants to merge
5
commits into
aissat:develop
Choose a base branch
from
alexeyinkin:issue524_asset-loader-static-type
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Static type for EasyLocalization.assetLoader (#524) #598
alexeyinkin
wants to merge
5
commits into
aissat:develop
from
alexeyinkin:issue524_asset-loader-static-type
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeyinkin
commented
Jun 26, 2023
- Resolves Static typing for AssetLoader #524
bw-flagship
reviewed
Jun 26, 2023
@@ -65,8 +65,7 @@ class EasyLocalization extends StatefulWidget { | |||
/// Class loader for localization files. | |||
/// You can use custom loaders from [Easy Localization Loader](https://github.com/aissat/easy_localization_loader) or create your own class. | |||
/// @Default value `const RootBundleAssetLoader()` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
- One can use the loaders from that package, after Delete local AssetLoader class, update dependencies (#46) easy_localization_loader#50 is merged and published.
- One can still create their own class.
- The default is still
const RootBundleAssetLoader()
.
bw-flagship
approved these changes
Jul 11, 2023
aissat
approved these changes
Sep 1, 2023
@alexeyinkin I suppose this is ready to merge after resolving the conflicts, right? |
@bw-flagship yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.