Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 4.0.0 #618

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

Version 4.0.0 #618

wants to merge 11 commits into from

Conversation

aissat
Copy link
Owner

@aissat aissat commented Sep 10, 2023

Hello everyone,

I have a suggestion for updating the next version of our project. I've written code to explain my idea and would greatly appreciate assistance in refining and implementing it.

v 3.0.0

void main() async {
  WidgetsFlutterBinding.ensureInitialized();
  await EasyLocalization.ensureInitialized();
  
  runApp(
    EasyLocalization(
      supportedLocales: [Locale('en', 'US'), Locale('de', 'DE')],
      path: 'assets/translations', 
      child: MyApp()
    ),
  );
}

v 4.0.0

void main() async {
  WidgetsFlutterBinding.ensureInitialized();
 await EasyLocalization.ensureInitialized(assetLoader: RootBundleAssetLoader(path: 'resources/langs/json'));
 // or await EasyLocalization.ensureInitialized(); //  assetLoader if null has default value
  
  runApp(
    EasyLocalization(
      child: MyApp()
    ),
  );
}

Task:

  • update docs
  • update tests
  • update example

@aissat aissat changed the title version 4.0.0 [draft] version 4.0.0 Sep 10, 2023
@aissat aissat linked an issue Sep 10, 2023 that may be closed by this pull request
@bw-flagship
Copy link
Collaborator

Maybe the readme needs an update? (The section "Configure App")

The changelog as well

@aissat
Copy link
Owner Author

aissat commented Sep 22, 2023

Maybe the readme needs an update? (The section "Configure App")

The changelog as well

Yeah, I agree working on code and have many test breaks try to fix it, when code ready will push it
want to you give me your opinion, @bw-flagship I am very appreciated for your help, thanks man

@aissat aissat added the help wanted Extra attention is needed label Sep 25, 2023
@aissat aissat marked this pull request as draft September 25, 2023 15:31
@spiritinlife
Copy link
Collaborator

spiritinlife commented Sep 25, 2023

Is there a benefit in moving the asset loader to the ensureInitialized? I am not sure I see it.

@aissat aissat marked this pull request as ready for review September 29, 2023 10:44
@aissat aissat changed the title [draft] version 4.0.0 Version 4.0.0 Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

version 4.0.0 [🌎 Easy Localization] [WARNING] Localization key [key] not found
3 participants