Special cases of Merging values into a list #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #689 it might be hard to understand why certain values are not visible in the app, if the value was overwritten by a different source.
I adapted the
addAllRecursivefunction to warn the user when a key is overwritten.Also, when a single entry is overwritten with a map of entries (or the other way around) a warning is presented that also indicates how many keys were lost. Since possibly many keys might get lost, this sounded like a reasonable action to perform.
Feel free to comment or make suggestions.
@bw-flagship please have a look