Fix FileLock.acquire_ctx only releasing on errors

aiudirog · Jul 1, 2021 · ae7537e · ae7537e
1 parent e2351fc
commit ae7537e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/aiuti/filelock.py b/aiuti/filelock.py
@@ -200,7 +200,7 @@ def acquire_ctx(self,
             raise TimeoutError("Failed to acquire file lock:", self._lock_file)
         try:
             yield
-        except BaseException:  # noqa
+        finally:
             self.release()
 
     def release(self, force: bool = False) -> None:

diff --git a/aiuti/tests/test_filelock.py b/aiuti/tests/test_filelock.py
@@ -66,7 +66,7 @@ def test_acquire_ctx(flock: FileLock) -> None:
     """Same as test_simple but using acquire_ctx."""
     with flock.acquire_ctx() as lock:
         assert flock.is_locked
-        assert flock is lock
+        assert lock is None
     assert not flock.is_locked