Support setting Kafka tiered storage topic configs #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`remote.storage.enable`, `local.retention.ms`, `local.retention.bytes`.
eliax1996
approved these changes
Sep 15, 2023
| tags=tags, | ||
| ) | ||
| print(response["message"]) | ||
|
|
||
| def _remote_storage_enable(self) -> bool | None: | ||
| if self.args.remote_storage_enable and self.args.remote_storage_disable: | ||
| raise argx.UserError("Only set at most one of --remote-storage-enable and --remote-storage-disable") |
There was a problem hiding this comment.
Schrödinger remote storage mode on 😄
There was a problem hiding this comment.
In this case probably isn't worth but we could always add a param to the annotation to do something like the following in case of N mutually exclusive options:
group = parser.add_mutually_exclusive_group()
group.add_argument('-a', action='store_true')
group.add_argument('-b', action='store_true')
I think not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remote.storage.enable,local.retention.ms,local.retention.bytes.