Add custom files API support #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
van-ess0
force-pushed
the
van_ess0_custom_files_api_support
branch
from
2b19d82 to
d8a6bd9
Compare
mteiste
previously requested changes
Oct 25, 2023
Prime541
reviewed
Oct 26, 2023
van-ess0
force-pushed
the
van_ess0_custom_files_api_support
branch
from
d8a6bd9 to
6a4fa10
Compare
van-ess0
force-pushed
the
van_ess0_custom_files_api_support
branch
2 times, most recently
from
a08839b to
60ad2bf
Compare
heikju
previously requested changes
Nov 17, 2023
|
It would also be nice to see tests for this. The test coverage for client is not great, but at least we would have an opportunity here to make it slightly better. |
van-ess0
force-pushed
the
van_ess0_custom_files_api_support
branch
from
60ad2bf to
6647a30
Compare
van-ess0
force-pushed
the
van_ess0_custom_files_api_support
branch
from
6647a30 to
01b8787
Compare
van-ess0
force-pushed
the
van_ess0_custom_files_api_support
branch
5 times, most recently
from
b3091a5 to
028e00a
Compare
Add custom files CRUD support Reduce client.verify complexity
van-ess0
force-pushed
the
van_ess0_custom_files_api_support
branch
from
028e00a to
15c4ad1
Compare
mteiste
requested changes
Dec 19, 2023
| @arg.service_name | ||
| @arg("--file_id", help="A file ID, usually an uuid4 string", required=True) | ||
| @arg("--target_filepath", help="Where to save the file downloaded") | ||
| @arg("--stdout_write", help="Write to the stdout instead of file", action="store_true") |
There was a problem hiding this comment.
Not sure if this flag makes sense. E.g from the face of it (if I read this correctly) the default if target_filepath is not given is to write to stdout, so the question is what is the use case for getting the file but not writing it to anywhere?
There was a problem hiding this comment.
I see it like fetch file | grep foo | sed 's/o/i/' >> new_file.txt
mteiste
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds custom file support for Aiven services