Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: Aiven for Metrics getting started #148

Merged
merged 4 commits into from
Apr 15, 2024
Merged

add: Aiven for Metrics getting started #148

merged 4 commits into from
Apr 15, 2024

Conversation

harshini-rangaswamy
Copy link
Contributor

@harshini-rangaswamy harshini-rangaswamy commented Apr 4, 2024 •
edited
Loading

Describe your changes

Checklist

  • The first paragraph of the page is on one line.
  • The other lines have a line break at 90 characters.
  • I checked the output.
  • I applied the style guide.
  • My links start with /docs/.

@harshini-rangaswamy harshini-rangaswamy marked this pull request as ready for review April 4, 2024 07:39
@harshini-rangaswamy harshini-rangaswamy self-assigned this Apr 4, 2024
@harshini-rangaswamy harshini-rangaswamy added review/SME An SME must review the PR. review/awaitingRelease All reviews are completed. labels Apr 4, 2024
@harshini-rangaswamy harshini-rangaswamy marked this pull request as draft April 4, 2024 07:40
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Apr 4, 2024 •
edited
Loading

Deploying aiven-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: a4a7176
Status: ✅  Deploy successful!
Preview URL: https://6666f2f3.aiven-docs.pages.dev
Branch Preview URL: https://harshini-thanos-get-started.aiven-docs.pages.dev

View logs

@harshini-rangaswamy harshini-rangaswamy added service/thanos-metrics review/TW A TW must review the PR. Comes after review/SME. and removed review/awaitingRelease All reviews are completed. labels Apr 4, 2024
axeoman
axeoman requested changes Apr 12, 2024
View reviewed changes
Copy link

@axeoman axeoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, service-type is different, though

docs/products/metrics/get-started.md Outdated Show resolved Hide resolved
@harshini-rangaswamy harshini-rangaswamy removed the review/SME An SME must review the PR. label Apr 15, 2024
@harshini-rangaswamy harshini-rangaswamy marked this pull request as ready for review April 15, 2024 08:08
@harshini-rangaswamy harshini-rangaswamy merged this pull request into harshini-thanos-overview Apr 15, 2024
4 checks passed
@harshini-rangaswamy harshini-rangaswamy deleted the harshini-thanos-get-started branch April 15, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axeoman axeoman axeoman approved these changes

@ArthurFlag ArthurFlag ArthurFlag approved these changes

Assignees

@harshini-rangaswamy harshini-rangaswamy

Labels
review/TW A TW must review the PR. Comes after review/SME. service/thanos-metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harshini-rangaswamy @axeoman @ArthurFlag