Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clarify OS ACL scope in docs #281

Merged
merged 6 commits into from
Aug 12, 2024
Merged

fix: clarify OS ACL scope in docs #281

merged 6 commits into from
Aug 12, 2024

Conversation

harshini-rangaswamy
Copy link
Contributor

@harshini-rangaswamy harshini-rangaswamy commented Jun 19, 2024 •
edited

Describe your changes

This PR updates the documentation to clarify that ACLs apply only to indices and do not control access to other OpenSearch APIs, including OpenSearch Dashboards.
Issue reported in MA-2772.

Checklist

  • The first paragraph of the page is on one line.
  • The other lines have a line break at 90 characters.
  • I checked the output.
  • I applied the style guide.
  • My links start with /docs/.

@github-actions github-actions bot added the tech Relates to technical updates of the docs platform. label Jun 19, 2024
@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented Jun 19, 2024 •
edited

Deploying aiven-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2613233
Status: ✅  Deploy successful!
Preview URL: https://16cc846f.aiven-docs.pages.dev
Branch Preview URL: https://harshini-os-acl.aiven-docs.pages.dev

View logs

@harshini-rangaswamy harshini-rangaswamy self-assigned this Jun 19, 2024
@harshini-rangaswamy harshini-rangaswamy marked this pull request as ready for review June 19, 2024 11:05
@harshini-rangaswamy harshini-rangaswamy requested a review from a team as a code owner June 19, 2024 11:05
@harshini-rangaswamy harshini-rangaswamy removed the tech Relates to technical updates of the docs platform. label Jun 19, 2024
@github-actions github-actions bot added the tech Relates to technical updates of the docs platform. label Jun 20, 2024
@harshini-rangaswamy harshini-rangaswamy added the review/SME An SME must review the PR. label Jul 3, 2024
@harshini-rangaswamy harshini-rangaswamy added review/TW A TW must review the PR. Comes after review/SME. and removed review/SME An SME must review the PR. labels Aug 12, 2024
staceysalamon-aiven
staceysalamon-aiven approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@staceysalamon-aiven staceysalamon-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice rewrites 👏 Found just a small typo and made a very minor suggestion.

docs/products/opensearch/concepts/users-access-controls.md Show resolved Hide resolved
docs/products/opensearch/howto/control_access_to_content.md Show resolved Hide resolved
docs/products/opensearch/howto/control_access_to_content.md Show resolved Hide resolved
@harshini-rangaswamy harshini-rangaswamy merged commit cc25c9f into main Aug 12, 2024
4 checks passed
@harshini-rangaswamy harshini-rangaswamy deleted the harshini-OS-ACL branch August 12, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staceysalamon-aiven staceysalamon-aiven staceysalamon-aiven approved these changes

@mteiste mteiste mteiste approved these changes

Assignees

@harshini-rangaswamy harshini-rangaswamy

Labels
review/TW A TW must review the PR. Comes after review/SME. service/opensearch tech Relates to technical updates of the docs platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@harshini-rangaswamy @mteiste @staceysalamon-aiven