Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Kafka tiered storage GA #311

Merged
merged 18 commits into from
Aug 7, 2024
Merged

fix: Kafka tiered storage GA #311

merged 18 commits into from
Aug 7, 2024

Conversation

harshini-rangaswamy
Copy link
Contributor

@harshini-rangaswamy harshini-rangaswamy commented Jul 1, 2024 •
edited

Describe your changes

  • Removed Early Availability tags from Kafka tiered storage content.
  • Updated the Pricing section in the overview topic to include details about tiered storage charges.

Checklist

  • The first paragraph of the page is on one line.
  • The other lines have a line break at 90 characters.
  • I checked the output.
  • I applied the style guide.
  • My links start with /docs/.

@harshini-rangaswamy harshini-rangaswamy changed the title udpate: Kafka tiered storage GA fix: Kafka tiered storage GA Jul 1, 2024
@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented Jul 1, 2024 •
edited

Deploying aiven-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: b5b67a6
Status: ✅  Deploy successful!
Preview URL: https://c9712bfd.aiven-docs.pages.dev
Branch Preview URL: https://harshini-kafka-ts-ga.aiven-docs.pages.dev

View logs

@harshini-rangaswamy harshini-rangaswamy self-assigned this Jul 1, 2024
@harshini-rangaswamy harshini-rangaswamy added the review/SME An SME must review the PR. label Jul 1, 2024
@harshini-rangaswamy harshini-rangaswamy marked this pull request as ready for review July 1, 2024 15:38
@harshini-rangaswamy harshini-rangaswamy requested a review from a team as a code owner July 1, 2024 15:38
jeqo
jeqo reviewed Jul 2, 2024
View reviewed changes
Copy link

@jeqo jeqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshini-rangaswamy looks good! Adding some suggestions to clarify certain parts of the document.

docs/products/kafka/concepts/kafka-tiered-storage.md Outdated Show resolved Hide resolved
docs/products/kafka/concepts/kafka-tiered-storage.md Outdated Show resolved Hide resolved
docs/products/kafka/concepts/kafka-tiered-storage.md Outdated Show resolved Hide resolved
docs/products/kafka/concepts/tiered-storage-how-it-works.md Show resolved Hide resolved
@harshini-rangaswamy harshini-rangaswamy added the review/TW A TW must review the PR. Comes after review/SME. label Jul 3, 2024
jeqo
jeqo approved these changes Jul 3, 2024
View reviewed changes
Copy link

@jeqo jeqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @harshini-rangaswamy !

@harshini-rangaswamy harshini-rangaswamy removed the review/TW A TW must review the PR. Comes after review/SME. label Jul 3, 2024
@github-actions github-actions bot added the tech Relates to technical updates of the docs platform. label Jul 3, 2024
@harshini-rangaswamy harshini-rangaswamy added the review/TW A TW must review the PR. Comes after review/SME. label Jul 8, 2024
wojcik-dorota
wojcik-dorota reviewed Jul 8, 2024
View reviewed changes
Copy link
Contributor

@wojcik-dorota wojcik-dorota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor ideas for improvement

wojcik-dorota
wojcik-dorota reviewed Jul 10, 2024
View reviewed changes
docs/products/kafka/concepts/tiered-storage-guarantees.md Outdated Show resolved Hide resolved
docs/products/kafka/concepts/tiered-storage-limitations.md Outdated Show resolved Hide resolved
docs/products/kafka/concepts/tiered-storage-limitations.md Outdated Show resolved Hide resolved
docs/products/kafka/concepts/kafka-tiered-storage.md Outdated Show resolved Hide resolved
docs/products/kafka/concepts/tiered-storage-how-it-works.md Outdated Show resolved Hide resolved
docs/products/kafka/concepts/tiered-storage-how-it-works.md Outdated Show resolved Hide resolved
docs/products/kafka/concepts/tiered-storage-how-it-works.md Outdated Show resolved Hide resolved
docs/products/kafka/concepts/tiered-storage-guarantees.md Outdated Show resolved Hide resolved
docs/products/kafka/concepts/tiered-storage-limitations.md Outdated Show resolved Hide resolved
docs/products/kafka/concepts/tiered-storage-limitations.md Outdated Show resolved Hide resolved
wojcik-dorota
wojcik-dorota reviewed Jul 10, 2024
View reviewed changes
docs/products/kafka/howto/kafka-tiered-storage-get-started.md Outdated Show resolved Hide resolved
docs/products/kafka/howto/kafka-tiered-storage-get-started.md Outdated Show resolved Hide resolved
docs/products/kafka/howto/kafka-tiered-storage-get-started.md Outdated Show resolved Hide resolved
docs/products/kafka/howto/enable-kafka-tiered-storage.md Outdated Show resolved Hide resolved
docs/products/kafka/howto/enable-kafka-tiered-storage.md Show resolved Hide resolved
docs/products/kafka/howto/configure-topic-tiered-storage.md Show resolved Hide resolved
docs/products/kafka/howto/configure-topic-tiered-storage.md Show resolved Hide resolved
docs/products/kafka/howto/configure-topic-tiered-storage.md Outdated Show resolved Hide resolved
docs/products/kafka/howto/configure-topic-tiered-storage.md Outdated Show resolved Hide resolved
docs/products/kafka/howto/configure-topic-tiered-storage.md Outdated Show resolved Hide resolved
wojcik-dorota
wojcik-dorota reviewed Jul 10, 2024
View reviewed changes
docs/products/kafka/howto/create-topic.md Outdated Show resolved Hide resolved
docs/products/kafka/howto/create-topic.md Show resolved Hide resolved
docs/products/kafka/howto/create-topic.md Outdated Show resolved Hide resolved
docs/products/kafka/howto/create-topic.md Outdated Show resolved Hide resolved
docs/products/kafka/howto/create-topic.md Show resolved Hide resolved
docs/products/kafka/howto/create-topic.md Outdated Show resolved Hide resolved
docs/products/kafka/howto/create-topic.md Outdated Show resolved Hide resolved
docs/products/kafka/howto/create-topic.md Outdated Show resolved Hide resolved
wojcik-dorota
wojcik-dorota approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@wojcik-dorota wojcik-dorota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, submitting some ideas for possible improvements

docs/products/kafka/howto/create-topics-automatically.md Outdated Show resolved Hide resolved
docs/products/kafka/howto/create-topics-automatically.md Outdated Show resolved Hide resolved
docs/products/kafka/howto/create-topics-automatically.md Outdated Show resolved Hide resolved
docs/products/kafka/howto/create-topics-automatically.md Show resolved Hide resolved
@harshini-rangaswamy harshini-rangaswamy added review/awaitingRelease All reviews are completed. and removed review/SME An SME must review the PR. review/TW A TW must review the PR. Comes after review/SME. labels Jul 11, 2024
@harshini-rangaswamy harshini-rangaswamy force-pushed the harshini-kafka-ts-ga branch 2 times, most recently from c744db8 to 06e3bcf Compare July 31, 2024 08:44
@harshini-rangaswamy harshini-rangaswamy merged commit 0655220 into main Aug 7, 2024
4 checks passed
@harshini-rangaswamy harshini-rangaswamy deleted the harshini-kafka-ts-ga branch August 7, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeqo jeqo jeqo approved these changes

@wojcik-dorota wojcik-dorota wojcik-dorota approved these changes

Assignees

@harshini-rangaswamy harshini-rangaswamy

Labels
review/awaitingRelease All reviews are completed. service/kafka tech Relates to technical updates of the docs platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@harshini-rangaswamy @jeqo @wojcik-dorota