Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add(clickhouse): credentials integration #4

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

wojcik-dorota
Copy link
Contributor

@wojcik-dorota wojcik-dorota commented Jan 26, 2024

Copy link

cloudflare-pages bot commented Jan 26, 2024

Deploying aiven-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9449801
Status: ✅  Deploy successful!
Preview URL: https://af1d1441.aiven-docs.pages.dev
Branch Preview URL: https://dorota-clickhouse-named-coll.aiven-docs.pages.dev

View logs

@wojcik-dorota wojcik-dorota force-pushed the dorota-clickhouse-named-collections branch 2 times, most recently from 1c036c9 to 14418e9 Compare January 26, 2024 16:10
@wojcik-dorota wojcik-dorota marked this pull request as ready for review January 26, 2024 16:13
@wojcik-dorota wojcik-dorota changed the title [WiP] clickhouse: add clickhouse credentials integrations docs clickhouse: add clickhouse credentials integrations docs Jan 26, 2024
@wojcik-dorota wojcik-dorota changed the title clickhouse: add clickhouse credentials integrations docs add(clickhouse): credentials integration Jan 26, 2024
@wojcik-dorota wojcik-dorota force-pushed the dorota-clickhouse-named-collections branch from 14418e9 to b5f2c4f Compare January 26, 2024 16:33
@wojcik-dorota wojcik-dorota self-assigned this Jan 29, 2024
@wojcik-dorota wojcik-dorota force-pushed the dorota-clickhouse-named-collections branch from b5f2c4f to 70ace64 Compare January 29, 2024 15:34
@wojcik-dorota wojcik-dorota added review/awaitingRelease All reviews are completed. review/SME An SME must review the PR. labels Jan 31, 2024
@wojcik-dorota wojcik-dorota force-pushed the dorota-clickhouse-named-collections branch from 5dff4c4 to 161731f Compare February 8, 2024 07:01
@wojcik-dorota wojcik-dorota force-pushed the dorota-clickhouse-named-collections branch from 161731f to 97f286e Compare February 21, 2024 14:35
@wojcik-dorota wojcik-dorota force-pushed the dorota-clickhouse-named-collections branch from 97f286e to 740e77a Compare June 5, 2024 12:22
@wojcik-dorota wojcik-dorota requested a review from a team as a code owner June 5, 2024 12:22
@wojcik-dorota wojcik-dorota force-pushed the dorota-clickhouse-named-collections branch 3 times, most recently from eb06287 to 9d6c059 Compare June 6, 2024 13:03
@github-actions github-actions bot added the tech Relates to technical updates of the docs platform. label Jun 6, 2024
@wojcik-dorota wojcik-dorota requested review from aris-aiven and removed request for ArthurFlag July 19, 2024 10:06
@wojcik-dorota wojcik-dorota force-pushed the dorota-clickhouse-named-collections branch from 4bc87fd to 43febf4 Compare July 19, 2024 11:22
@wojcik-dorota wojcik-dorota force-pushed the dorota-clickhouse-named-collections branch from 43febf4 to 8bab197 Compare July 19, 2024 11:57
aris-aiven

This comment was marked as resolved.

@wojcik-dorota wojcik-dorota added the review/TW A TW must review the PR. Comes after review/SME. label Jul 31, 2024
ArthurFlag

This comment was marked as resolved.

@wojcik-dorota wojcik-dorota removed review/SME An SME must review the PR. review/awaitingRelease All reviews are completed. labels Aug 5, 2024
Copy link
Member

@ArthurFlag ArthurFlag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@wojcik-dorota wojcik-dorota added review/awaitingRelease All reviews are completed. and removed review/TW A TW must review the PR. Comes after review/SME. labels Aug 7, 2024
aris-aiven

This comment was marked as resolved.

@aris-aiven
Copy link
Contributor

aris-aiven commented Aug 8, 2024

Another thing that would be nice here is linking the "Copy data between services" article (https://6e0767dd.aiven-docs.pages.dev/docs/products/clickhouse/howto/copy-data-across-instances) to the managed credentials.
Mentioning that users don't need to paste their passwords in the SQL statement will be appreciated by the more security conscious.

I was thinking of a paragraph like:

If you have a managed credential integration (link to doc) enabled, you may instead use

SELECT * FROM remoteSecure(`service_my-remote-cluster`, db.remote_engine_table) LIMIT 3;

@wojcik-dorota
Copy link
Contributor Author

Another thing that would be nice here is linking the "Copy data between services" article (https://6e0767dd.aiven-docs.pages.dev/docs/products/clickhouse/howto/copy-data-across-instances) to the managed credentials. Mentioning that users don't need to paste their passwords in the SQL statement will be appreciated by the more security conscious.

I was thinking of a paragraph like:

If you have a managed credential integration (link to doc) enabled, you may instead use

SELECT * FROM remoteSecure(`service_my-remote-cluster`, db.remote_engine_table) LIMIT 3;

Thanks @aris-aiven ! Your comments have been addressed :-)

Copy link
Contributor

@aris-aiven aris-aiven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@ArthurFlag ArthurFlag force-pushed the dorota-clickhouse-named-collections branch from 3023f87 to 9449801 Compare August 21, 2024 09:46
@ArthurFlag ArthurFlag merged commit cd9d5aa into main Aug 21, 2024
4 checks passed
@ArthurFlag ArthurFlag deleted the dorota-clickhouse-named-collections branch August 21, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review/awaitingRelease All reviews are completed. service/clickhouse tech Relates to technical updates of the docs platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants