-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Get information for the current session's user #353
Added support for Get information for the current session's user #353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Thanks for your contribution!
If there is no particular reason to go with this client, I recommend to try our generated. Here is the method you are implementing https://github.com/aiven/go-client-codegen/blob/259be870943791d517994df16b18e601f0278ebe/handler/user/user.go#L107
It is experimental, but since it is generated it is more accurately than this one.
Hi @byashimov, Thank you for your detailed feedback. In our project, we have used the Go package If we could consider this PR, it would be greatly appreciated.
I have updated the
Removed the test file.
Updated the Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey. Thanks for the updates.
Please take a look at these:
- there is no
viewed_indicators
field https://api.aiven.io/doc/#tag/Users/operation/UserInfo - should remove pointers from required field
I recommend to copy this struct https://github.com/aiven/go-client-codegen/blob/main/handler/user/user.go#L718
It was generated from the spec
Hello @byashimov, thank you for your suggestions. I've made the changes accordingly. Could you please take another look? |
Thank you @ParthaI for the contribution! |
Get information for the current session's user: https://api.aiven.io/doc/#tag/Users/operation/UserInfo