Apply Aiven-specific changes on top of upstream 4.0.13 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rat checks if all files have license information. During the build however, multiple new files appear and rat check fails for them.
We do not use init.d, systemd ignores limits in limits.d, the file in /etc/default we do not need as well.
This is necessary to install cassandra 3 and 4 side-by-side in the test environment.
We need to remove some additional files in lib/sigar-bin or we'll get an error when running strip on them. Fedora 35 related change. [SRENA-268]
Instruct the system to allocate the gid/uid for cassandra user a little deeper inside the available id range. This helps to avoid clashes with other uids in some cases.
We never use the default configuration and directories, there's no need to create them; the user is created externally anyways.
The data will be provided by Astacus, streaming from other nodes is not necessary.
It's more convenient to set it there in Astacus. Option semantics is preserved, the value specified in Java properties has priority.
We decorate standard PasswordAuthenticator with a few platform specific features, that don't change the externally observable behavior - so it's absolutely compatible with PasswordAuthenticator. A few tools and client libraries do not support custom authenticators. For example: ZDM Proxy. They fail whenever they see anything but PasswordAuthenticator nevertheless they are in fact completely compatible. So we want to stop advertising our custom authenticator and pretend that it's a standard PasswordAuthenticator.
… rpc_address column patch by Chang Liu; reviewed by Alexei Zotov and Stefan Miklosovic for CASSANDRA-11181
To ensure that the related tests can relably check their assertions, the replication factor uptuning is disabled in the test class setup.
|
Just leaving a note here that test results upload is failing and the latest version for the GH Action is https://github.com/EnricoMi/publish-unit-test-result-action (v2) |
aris-aiven
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Resolved conflicts
Test history
Initial run
https://github.com/aiven/cassandra/runs/26315726900
Second run
https://github.com/aiven/cassandra/runs/26320855845