Apply aiven specific patches on top of upstream 1.2.0 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add environment variable to configure default pool size.
Not to be upstreamed, upstream SHOULD provide configuration for all
pools but currently there's hardcoded default sized pools for
e.g. tag{de,en}coders and some other places. With this default, we
can change it from 4096 to something else as we wish.
- Add environment variable with (optional) pool size whitelist.
Even with default pool size changed to e.g. 4096->64, lots of large
pools are still either hardcoded in codebase, or in configuration
defaults.
|
@tsharju Are we still planning on updating from upstream in the near future? The M3 team is planning to cut v1.4.0 soon, which will include a change that I made that will fix an error we encountered when Vmalert uses M3 as its data source ( |
|
@ryansammonaiven Sure, I decided to leave 1.3.0 not updated as it mainly contained patches I made that are already in our patched 1.2.0 version. But once 1.4.0 becomes available I believe we'll try to get that available asap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes our custom patches and applies them on top of M3 1.2.0 to a new release branch
aiven-1.2.