ENG-1094: Validate prompt variables #317
Merged
+53
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiago-aixplain
changed the title
aixplain/modules/agent/__init__.py
Outdated
Comment on lines
242
to
254
| variables = re.findall(r"(?<!{){([^}]+)}(?!})", self.description) | ||
| input_data = {"input": FileFactory.to_link(query)} | ||
| for variable in variables: | ||
| if isinstance(data, dict): | ||
| assert ( | ||
| variable in data or variable in parameters | ||
| ), f"Variable '{variable}' not found in data or parameters. This variable is required by the agent according to its description ('{self.description}')." | ||
| input_data[variable] = data.pop(variable) if variable in data else parameters.pop(variable) | ||
| else: | ||
| assert ( | ||
| variable in parameters | ||
| ), f"Variable '{variable}' not found in parameters. This variable is required by the agent according to its description ('{self.description}')." | ||
| input_data[variable] = parameters.pop(variable) |
There was a problem hiding this comment.
We should add this piece of code to a method and call it here and in the team agent class. Also, we could test separately in the unit tests.
lucas-aixplain
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.