forked from deriv-com/deriv-app
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat new flow mf account #34
Merged
likhith-deriv
merged 48 commits into
aizad-deriv:new-flow-for-MF-Clients
from
likhith-deriv:feat--new_flow_mf_account
Sep 7, 2022
Merged
Feat new flow mf account #34
likhith-deriv
merged 48 commits into
aizad-deriv:new-flow-for-MF-Clients
from
likhith-deriv:feat--new_flow_mf_account
Sep 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t--new_flow_mf_account
…t--new_flow_mf_account
…t--new_flow_mf_account
…t--new_flow_mf_account
…t--new_flow_mf_account
…t--new_flow_mf_account
…t--new_flow_mf_account
…t--new_flow_mf_account
…t--new_flow_mf_account
…t--new_flow_mf_account
…t--new_flow_mf_account
* text|edit_note_self_exclusion_message_box * test fix * regexp in tests fix * accident text deleted * popup message text fix * text fixes * test text query fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”>
… are locked (deriv-com#4644) * Ignore IDV verification if client is high risk * Fix formatting * Fix cfd-poi issue due to client store unavailability * Fix formatting * Merge with master * Fix formatting * Merge with master * Revert "Merge with master" This reverts commit 4bead99. * Fix merge issues * Chain extra condition to cover wrong status returned from BE * Fix: wrong component shown when manual upload is triggered
…s to TS (deriv-com#6361) * perf(cashier routes): convert csahier routes to TS * perf(cashier routes): convert error-component to TS * refactor(error-dialog, types): refactor error-dialog types, move error type to shared types * perf(cashier): convert cashier to TS * perf(types): refactor types * refactor(routes with sub routes): refactor default subroute * refactor(types): add/refactor server error type * test: refactor pathname * refactor(route types): refactor route types * fix: fix ts error in React.Suspense
…6343) * perf(cashier withdraw): convert withdrawal-verification-email to TS * perf: add data-testid for checklist action * perf(cashier withdraw): convert withdrawal-locked to TS * perf(types): add types for TClinetStore * perf(cashier withdraw): convert withdraw to TS * perf(cashier withdraw): convert crypto-withdraw-receipt to TS * perf(cashier withdraw): convert crypto-withdraw-form to TS * perf(cashier withdraw): convert withdrawal to TS * refactor(cashier withdraw): refactor array syntax (ts) * test(cashier withdraw): remove eslint disables for tests
…thdraw all his allowable withdrawal amount (deriv-com#6032) * fix(cashier): ✨ handle `PACommisionWithdrawalLimit` state in `CashierLocked` * test(cashier): ✅ add test case to `CashierLocked` for `PACommisionWithdrawalLimit` * Trigger Build
* chore: update appstore tsconfig * chore: update appstore tsconfig * chore: add react and types/react packages to appstore * refactor: remove unnecessary includes * refactor: change from reexports to import -> export
…#6276) * chores: add typescript configuration on reports * fix: remove extra paths * fix: revert removing packages
* refactor(p2p-cashier): migrate p2p-cashier component to TS * commit * perf(types): add types for notification store * perf(types): add types for ui store * perf(types): convert p2p-cashier to TS * refactor(types): change RootStore type to TRootStore * test(p2p-cashier): test fix (change wrapper order fro p2p-cashier component) * refactor(types): refactor current_focus type * test(p2p-cashier): remove eslint disables
* refactor: converted on-ramp module into typescript * refactor: included type related to store in on-ramp * ts fix in on-ramp-provider-card.spec.tsx * added path in tsconfig * added path in tsconfig * added type for react-router-dom * added ts related change required for migrating all components (deriv-com#5760) * changed the name of data-testid in on-ramp component * ts-migration-crypto-fiat-converter (deriv-com#5796) * Trigger build * Update package-lock * ts-migration-cashier-notifications (deriv-com#5765) * implemented review comments and updated branch as per latest upstream branch * bahar/funds_protection_component-ts-migration (deriv-com#5756) * funds_protection_component-ts-migration * remove_extra_type_file * fix_merge_issue * hamid/migrate-transfer-confirm-to-ts (deriv-com#5815) * Migrate TransferConfirm to TS * Rename component in test file * Replace Confirm with TransferConfirm in PAs * Enhance Tests * ts-migration-page-404 (deriv-com#5766) * corrected imports in on-ramp pages * coreected setSideNotes type in on-ramp file * arranged the order of imports in on-ramp * refactor: add menu-option type to types folder in cashier * replaced type for FormEvent in on-ramp from Types * added types from TRootstore * added types of TClientStore, TUiStore and TCommonStore in on-ramp Co-authored-by: Nijil Nirmal <nijil@deriv.com> Co-authored-by: Bahar <bahar@firstsource.tech> Co-authored-by: Hamid <hamid@re-work.dev>
* Migrate Account Transfer to TS * Enhance type names * Remove eslint ignore line * Remove generic type from useState * trigger tests * Fix test errors * Change data-testid name
* fix: circle ci issue * fix: circle ci issue
…-com#6306) * build: add typescript to all packages * build: move typescript to devdependency * add some TS configs to eslint file * fix: conflicts
* checking circle/ci test * removed test changes * fix: updated tsconfig and fixed some errors * fix: updated tsconfig and added globals.d.ts * chore: removed experimentalsDecorators from local config
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
…t--new_flow_mf_account
aizad-deriv
pushed a commit
that referenced
this pull request
Nov 1, 2022
Aizad / Fix CFD height css issue
aizad-deriv
added a commit
that referenced
this pull request
Nov 29, 2022
…5831) * added verified modal component * feat: incorporated welcome modal * fix: integrated new user flow * added styles to modal risk tolerance warning and cooldown warninig * change border bottom stylings * code cleanup * fix cooldown warning modal styling and added to handleondecline * feat: redirect user to POI * remove margin at the bottom for risk tolerance modal * added trading experience modal, ic-eu-check icon and fix stylings for verified account modal * added completed assessment modal for existing user trading assessment flow * feat: integrated new user flow with API * minified svg * fix: incorporated error modals * ref: Code refactor * fix: Added Cool down modal * fix: removed console statements * ref: API request update * replace icon in complete assessment modal with IcCheckmarkCircle * ref: removed commented code * remove ic-verification-success icon from icons.js * removed icon * feat: Added logic to display cooldown modal * test: verified functionality of new MF flow * feat: incorporated welcome modal * removed consoles * feat: Integrated exisitng user flow * feat: integrated exisiting user flow * Added todos * readded ic verification success to modal * change function of risk tolerance modal and added displayNextPage * feat: incorporated existing user flow * ref: Code refactor in assessment form * fix: Responsive CSS styles * fix: lint errors * fix: precommit file * code refactor * added stylings for responsive for mf new users signup * ref: Modified the payload structure to be in sync with BE * resolved: remove isMobile inside of risk-tolerance-modal * resolved: remove isMobile inside of risk-tolerance-modal * fix: Modified API call for Financial assessment section for All users * fix dropdown option select issue * resolved review comments * reverted changes * fix button in test modal for mobile view * fix: account switcher * feat: Move to next question * fix: reverted css removal * fix resolve issues: added .jsx, rename components for dropdown and radio, change logic for enabling next section and remove comments * remove es-lint * resolved duplicated keys in accordion.jsx and autocomplete.jsx * resolved: change units from px to rem * changed units from px to rem account-wizard.scss * resolved: logic at trading-assessment-dropdown, shorten name in ui-store * added new assessment section in profile settings * fix: remove trading assessment from appstore * added questions onto the settings page * added trading-assessment form and stylings to both desktop and mobile * feat: incorporated disable-withdrawal-modal * feat: incorporated notification * feat: re-ordered the notification list * feat: incorporated withdrawal disable for desktop * feat: incorporated notification for mobile * fix: added stylings as per figma * added functionalities to the form including submit functionalities aswell as modals * fix issues: initial value not shownfor some fieldset * added trading assessment into webpack and add changes to trading assessment * Refactored Trade assessment code (#23) * fix: resolved issues with index * ref: refactored trade assessment code * fix: added unique key * Feat new flow mf account (#24) * fix: resolved issues with index * ref: refactored trade assessment code * fix: added unique key * fix: refactored response pick * Feat: added disable checks for assessments (#25) * fix: resolved issues with index * ref: refactored trade assessment code * fix: added unique key * fix: refactored response pick * feat: added check to disable financial and trade assessment for not risk clients * feat: incorporated notification (#26) * fix: resolved issues with index * ref: refactored trade assessment code * fix: added unique key * fix: refactored response pick * feat: added check to disable financial and trade assessment for not risk clients * feat: made changes to dialog * changed the modal text (#27) * fix: resolved issues with index * ref: refactored trade assessment code * fix: added unique key * fix: refactored response pick * feat: added check to disable financial and trade assessment for not risk clients * feat: made changes to dialog * fix: modified text content * added reinitialize * edit dropdown component and remove useeffect focus * Fixed risk client check (#28) * fix: resolved issues with index * ref: refactored trade assessment code * fix: added unique key * fix: refactored response pick * feat: added check to disable financial and trade assessment for not risk clients * feat: made changes to dialog * fix: modified text content * fix: risk status flag * Feat new flow mf account (#29) * fix: resolved issues with index * ref: refactored trade assessment code * fix: added unique key * fix: refactored response pick * feat: added check to disable financial and trade assessment for not risk clients * feat: made changes to dialog * fix: modified text content * fix: risk status flag * fix: css issues * added financial assessment banner for high risk clients aswell as normalize values for financial-assessment * remove commented line * remove trading experience section from view for mf clients * added is_risk_client into banner conditions and fix client store error * remove is_risk_client into banner conditions * Empty-Commit * Syncing with upstream (#30) * fix: resolved issues with index * ref: refactored trade assessment code * fix: added unique key * fix: refactored response pick * feat: added check to disable financial and trade assessment for not risk clients * feat: made changes to dialog * fix: modified text content * fix: risk status flag * fix: css issues * fix: added missing store state * resolved comments in: trading-assessment-config, select-native, trading-assessment-existing-user, trading-experience-modal,account-wizard, real-account-signup,account-wizard and client-store. * Feat new flow mf account (#31) * fix: resolved issues with index * ref: refactored trade assessment code * fix: added unique key * fix: refactored response pick * feat: added check to disable financial and trade assessment for not risk clients * feat: made changes to dialog * fix: modified text content * fix: risk status flag * fix: css issues * fix: added missing store state * fix: modified conditions * fix: added new flag to check * added setFinancialAndTradingAssessment inside of client-store * added loading screen component to trading-assessment * Feat new flow mf account (#32) * fix: resolved issues with index * ref: refactored trade assessment code * fix: added unique key * fix: refactored response pick * feat: added check to disable financial and trade assessment for not risk clients * feat: made changes to dialog * fix: modified text content * fix: risk status flag * fix: css issues * fix: added missing store state * fix: modified conditions * fix: added new flag to check * resolved conflict in ui-store * replaced is_svg with is_mf in financial-assessment.jsx * fix logic banner on financial-assessment and added cfd score inside of client-store * Feat new flow mf account (#33) * fix: resolved issues with index * ref: refactored trade assessment code * fix: added unique key * fix: refactored response pick * feat: added check to disable financial and trade assessment for not risk clients * feat: made changes to dialog * fix: modified text content * fix: risk status flag * fix: css issues * fix: added missing store state * fix: modified conditions * fix: added new flag to check * resolved conflict in ui-store * fix: added missing store * fix: status * Feat new flow mf account (#34) * fix: resolved issues with index * ref: refactored trade assessment code * fix: added unique key * fix: refactored response pick * feat: added check to disable financial and trade assessment for not risk clients * feat: made changes to dialog * fix: modified text content * fix: risk status flag * fix: css issues * fix: added missing store state * fix: modified conditions * fix: added new flag to check * resolved conflict in ui-store * fix bug (deriv-com#6154) * yauheni/ 70488/ edit note in self-exclusion message box (deriv-com#6044) * text|edit_note_self_exclusion_message_box * test fix * regexp in tests fix * accident text deleted * popup message text fix * text fixes * test text query fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Akmal / Ignore IDV verification if client is high risk && withdrawals are locked (deriv-com#4644) * Ignore IDV verification if client is high risk * Fix formatting * Fix cfd-poi issue due to client store unavailability * Fix formatting * Merge with master * Fix formatting * Merge with master * Revert "Merge with master" This reverts commit 4bead99. * Fix merge issues * Chain extra condition to cover wrong status returned from BE * Fix: wrong component shown when manual upload is triggered * fix:tax_number_validation (deriv-com#6259) * george / rm65047 / convert routes, cashier, error-component components to TS (deriv-com#6361) * perf(cashier routes): convert csahier routes to TS * perf(cashier routes): convert error-component to TS * refactor(error-dialog, types): refactor error-dialog types, move error type to shared types * perf(cashier): convert cashier to TS * perf(types): refactor types * refactor(routes with sub routes): refactor default subroute * refactor(types): add/refactor server error type * test: refactor pathname * refactor(route types): refactor route types * fix: fix ts error in React.Suspense * george / rm65033 / ts migration of withdraw UI components (deriv-com#6343) * perf(cashier withdraw): convert withdrawal-verification-email to TS * perf: add data-testid for checklist action * perf(cashier withdraw): convert withdrawal-locked to TS * perf(types): add types for TClinetStore * perf(cashier withdraw): convert withdraw to TS * perf(cashier withdraw): convert crypto-withdraw-receipt to TS * perf(cashier withdraw): convert crypto-withdraw-form to TS * perf(cashier withdraw): convert withdrawal to TS * refactor(cashier withdraw): refactor array syntax (ts) * test(cashier withdraw): remove eslint disables for tests * update deriv go redirection link (deriv-com#6386) * Farzin/68320/Update cashier withdrawal locked status if PA already withdraw all his allowable withdrawal amount (deriv-com#6032) * fix(cashier): ✨ handle `PACommisionWithdrawalLimit` state in `CashierLocked` * test(cashier): ✅ add test case to `CashierLocked` for `PACommisionWithdrawalLimit` * Trigger Build * Jim/73479/appstore-workspace-ts-fix (deriv-com#6208) * chore: update appstore tsconfig * chore: update appstore tsconfig * chore: add react and types/react packages to appstore * refactor: remove unnecessary includes * refactor: change from reexports to import -> export * Niloofar Sadeghi / Trader Typescript configuration issue (deriv-com#6275) * fix: trader typscript configuration issue * fix: tsc errors on trader * Niloofar Sadeghi / Add typescript configuration on reports (deriv-com#6276) * chores: add typescript configuration on reports * fix: remove extra paths * fix: revert removing packages * george / rm65041 / migrate p2p-cashier component to TS (deriv-com#6177) * refactor(p2p-cashier): migrate p2p-cashier component to TS * commit * perf(types): add types for notification store * perf(types): add types for ui store * perf(types): convert p2p-cashier to TS * refactor(types): change RootStore type to TRootStore * test(p2p-cashier): test fix (change wrapper order fro p2p-cashier component) * refactor(types): refactor current_focus type * test(p2p-cashier): remove eslint disables * Vinu/Ts onramp cashier (deriv-com#5727) * refactor: converted on-ramp module into typescript * refactor: included type related to store in on-ramp * ts fix in on-ramp-provider-card.spec.tsx * added path in tsconfig * added path in tsconfig * added type for react-router-dom * added ts related change required for migrating all components (deriv-com#5760) * changed the name of data-testid in on-ramp component * ts-migration-crypto-fiat-converter (deriv-com#5796) * Trigger build * Update package-lock * ts-migration-cashier-notifications (deriv-com#5765) * implemented review comments and updated branch as per latest upstream branch * bahar/funds_protection_component-ts-migration (deriv-com#5756) * funds_protection_component-ts-migration * remove_extra_type_file * fix_merge_issue * hamid/migrate-transfer-confirm-to-ts (deriv-com#5815) * Migrate TransferConfirm to TS * Rename component in test file * Replace Confirm with TransferConfirm in PAs * Enhance Tests * ts-migration-page-404 (deriv-com#5766) * corrected imports in on-ramp pages * coreected setSideNotes type in on-ramp file * arranged the order of imports in on-ramp * refactor: add menu-option type to types folder in cashier * replaced type for FormEvent in on-ramp from Types * added types from TRootstore * added types of TClientStore, TUiStore and TCommonStore in on-ramp Co-authored-by: Nijil Nirmal <nijil@deriv.com> Co-authored-by: Bahar <bahar@firstsource.tech> Co-authored-by: Hamid <hamid@re-work.dev> * hamid/65036/migrate-account-transfer-to-ts (deriv-com#6305) * Migrate Account Transfer to TS * Enhance type names * Remove eslint ignore line * Remove generic type from useState * trigger tests * Fix test errors * Change data-testid name * Niloofar Sadeghi / Account typscript configuration issue (deriv-com#6273) * fix: account typscript configuration issue * text: remove include comment on account tsconfig * fix: added missing store * Niloofar Sadeghi / Circleci issue (deriv-com#6402) * fix: circle ci issue * fix: circle ci issue * Niloofar Sadeghi / Add typescript to each workspace dependency (deriv-com#6306) * build: add typescript to all packages * build: move typescript to devdependency * add some TS configs to eslint file * fix: conflicts * Shayan/74388/fix ts config on cfd (deriv-com#6351) * checking circle/ci test * removed test changes * fix: updated tsconfig and fixed some errors * fix: updated tsconfig and added globals.d.ts * chore: removed experimentalsDecorators from local config * translations: 📚 sync translations with crowdin (deriv-com#6405) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * fix: status Co-authored-by: Eduard Hrachou <107860964+eduard-deriv@users.noreply.github.com> Co-authored-by: yauheni-kryzhyk-deriv <103182683+yauheni-kryzhyk-deriv@users.noreply.github.com> Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com> Co-authored-by: amina-deriv <84661147+amina-deriv@users.noreply.github.com> Co-authored-by: George Usynin <103181646+george-usynin-binary@users.noreply.github.com> Co-authored-by: Carol Sachdeva <58209918+carol-binary@users.noreply.github.com> Co-authored-by: Farzin Mirzaie <72082844+farzin-fs@users.noreply.github.com> Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> Co-authored-by: Niloofar Sadeghi <93518187+niloo-fs@users.noreply.github.com> Co-authored-by: vinu-deriv <100689171+vinu-deriv@users.noreply.github.com> Co-authored-by: Nijil Nirmal <nijil@deriv.com> Co-authored-by: Bahar <bahar@firstsource.tech> Co-authored-by: Hamid <hamid@re-work.dev> Co-authored-by: Shayan Khaleghparast <100833613+iman-fs@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * fix select-native placeholder prop and remove success modal from existing user TA settings page * disabled financial assessment submenu on mobile * change css for financial-banner on FA page * Feat new flow mf account (#35) * fix: resolved issues with index * ref: refactored trade assessment code * fix: added unique key * fix: refactored response pick * feat: added check to disable financial and trade assessment for not risk clients * feat: made changes to dialog * fix: modified text content * fix: risk status flag * fix: css issues * fix: added missing store state * fix: modified conditions * fix: added new flag to check * resolved conflict in ui-store * fix bug (deriv-com#6154) * yauheni/ 70488/ edit note in self-exclusion message box (deriv-com#6044) * text|edit_note_self_exclusion_message_box * test fix * regexp in tests fix * accident text deleted * popup message text fix * text fixes * test text query fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Akmal / Ignore IDV verification if client is high risk && withdrawals are locked (deriv-com#4644) * Ignore IDV verification if client is high risk * Fix formatting * Fix cfd-poi issue due to client store unavailability * Fix formatting * Merge with master * Fix formatting * Merge with master * Revert "Merge with master" This reverts commit 4bead99. * Fix merge issues * Chain extra condition to cover wrong status returned from BE * Fix: wrong component shown when manual upload is triggered * fix:tax_number_validation (deriv-com#6259) * george / rm65047 / convert routes, cashier, error-component components to TS (deriv-com#6361) * perf(cashier routes): convert csahier routes to TS * perf(cashier routes): convert error-component to TS * refactor(error-dialog, types): refactor error-dialog types, move error type to shared types * perf(cashier): convert cashier to TS * perf(types): refactor types * refactor(routes with sub routes): refactor default subroute * refactor(types): add/refactor server error type * test: refactor pathname * refactor(route types): refactor route types * fix: fix ts error in React.Suspense * george / rm65033 / ts migration of withdraw UI components (deriv-com#6343) * perf(cashier withdraw): convert withdrawal-verification-email to TS * perf: add data-testid for checklist action * perf(cashier withdraw): convert withdrawal-locked to TS * perf(types): add types for TClinetStore * perf(cashier withdraw): convert withdraw to TS * perf(cashier withdraw): convert crypto-withdraw-receipt to TS * perf(cashier withdraw): convert crypto-withdraw-form to TS * perf(cashier withdraw): convert withdrawal to TS * refactor(cashier withdraw): refactor array syntax (ts) * test(cashier withdraw): remove eslint disables for tests * update deriv go redirection link (deriv-com#6386) * Farzin/68320/Update cashier withdrawal locked status if PA already withdraw all his allowable withdrawal amount (deriv-com#6032) * fix(cashier): ✨ handle `PACommisionWithdrawalLimit` state in `CashierLocked` * test(cashier): ✅ add test case to `CashierLocked` for `PACommisionWithdrawalLimit` * Trigger Build * Jim/73479/appstore-workspace-ts-fix (deriv-com#6208) * chore: update appstore tsconfig * chore: update appstore tsconfig * chore: add react and types/react packages to appstore * refactor: remove unnecessary includes * refactor: change from reexports to import -> export * Niloofar Sadeghi / Trader Typescript configuration issue (deriv-com#6275) * fix: trader typscript configuration issue * fix: tsc errors on trader * Niloofar Sadeghi / Add typescript configuration on reports (deriv-com#6276) * chores: add typescript configuration on reports * fix: remove extra paths * fix: revert removing packages * george / rm65041 / migrate p2p-cashier component to TS (deriv-com#6177) * refactor(p2p-cashier): migrate p2p-cashier component to TS * commit * perf(types): add types for notification store * perf(types): add types for ui store * perf(types): convert p2p-cashier to TS * refactor(types): change RootStore type to TRootStore * test(p2p-cashier): test fix (change wrapper order fro p2p-cashier component) * refactor(types): refactor current_focus type * test(p2p-cashier): remove eslint disables * Vinu/Ts onramp cashier (deriv-com#5727) * refactor: converted on-ramp module into typescript * refactor: included type related to store in on-ramp * ts fix in on-ramp-provider-card.spec.tsx * added path in tsconfig * added path in tsconfig * added type for react-router-dom * added ts related change required for migrating all components (deriv-com#5760) * changed the name of data-testid in on-ramp component * ts-migration-crypto-fiat-converter (deriv-com#5796) * Trigger build * Update package-lock * ts-migration-cashier-notifications (deriv-com#5765) * implemented review comments and updated branch as per latest upstream branch * bahar/funds_protection_component-ts-migration (deriv-com#5756) * funds_protection_component-ts-migration * remove_extra_type_file * fix_merge_issue * hamid/migrate-transfer-confirm-to-ts (deriv-com#5815) * Migrate TransferConfirm to TS * Rename component in test file * Replace Confirm with TransferConfirm in PAs * Enhance Tests * ts-migration-page-404 (deriv-com#5766) * corrected imports in on-ramp pages * coreected setSideNotes type in on-ramp file * arranged the order of imports in on-ramp * refactor: add menu-option type to types folder in cashier * replaced type for FormEvent in on-ramp from Types * added types from TRootstore * added types of TClientStore, TUiStore and TCommonStore in on-ramp Co-authored-by: Nijil Nirmal <nijil@deriv.com> Co-authored-by: Bahar <bahar@firstsource.tech> Co-authored-by: Hamid <hamid@re-work.dev> * hamid/65036/migrate-account-transfer-to-ts (deriv-com#6305) * Migrate Account Transfer to TS * Enhance type names * Remove eslint ignore line * Remove generic type from useState * trigger tests * Fix test errors * Change data-testid name * Niloofar Sadeghi / Account typscript configuration issue (deriv-com#6273) * fix: account typscript configuration issue * text: remove include comment on account tsconfig * fix: added missing store * Niloofar Sadeghi / Circleci issue (deriv-com#6402) * fix: circle ci issue * fix: circle ci issue * Niloofar Sadeghi / Add typescript to each workspace dependency (deriv-com#6306) * build: add typescript to all packages * build: move typescript to devdependency * add some TS configs to eslint file * fix: conflicts * Shayan/74388/fix ts config on cfd (deriv-com#6351) * checking circle/ci test * removed test changes * fix: updated tsconfig and fixed some errors * fix: updated tsconfig and added globals.d.ts * chore: removed experimentalsDecorators from local config * translations: 📚 sync translations with crowdin (deriv-com#6405) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * fix: status * hamid/75726/missing-grey-box-side-note (deriv-com#6410) * Fix sidenote in mobile view of account-transfer * Remove duplicate title * Add sideNote title Co-authored-by: Eduard Hrachou <107860964+eduard-deriv@users.noreply.github.com> Co-authored-by: yauheni-kryzhyk-deriv <103182683+yauheni-kryzhyk-deriv@users.noreply.github.com> Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com> Co-authored-by: amina-deriv <84661147+amina-deriv@users.noreply.github.com> Co-authored-by: George Usynin <103181646+george-usynin-binary@users.noreply.github.com> Co-authored-by: Carol Sachdeva <58209918+carol-binary@users.noreply.github.com> Co-authored-by: Farzin Mirzaie <72082844+farzin-fs@users.noreply.github.com> Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> Co-authored-by: Niloofar Sadeghi <93518187+niloo-fs@users.noreply.github.com> Co-authored-by: vinu-deriv <100689171+vinu-deriv@users.noreply.github.com> Co-authored-by: Nijil Nirmal <nijil@deriv.com> Co-authored-by: Bahar <bahar@firstsource.tech> Co-authored-by: Hamid <hamid@re-work.dev> Co-authored-by: Shayan Khaleghparast <100833613+iman-fs@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * fix: failing test cases * addded success button for TA, change modal for TA, and add new state in ui store * remove footer message in mobile and fix scoll offset for both mobile and desktop in FA * fix warning modal behavior on TA * resolved: replaced { with ( in risk-tolerance-warning-modal.jsx, removed default props in mobile-dialog.jsx * resolved: refactor code at trading-assessmnet-form.jsx and financial-assessment.jsx * resolved: add setFinancialAndTradingAssessment in proptypes. * resolved: change background-color name * resolved: remove curly brackets and return statment and replaced with regular brackets. Remove size prop in Text * resolved: change conditions to not show financial assessment tab in mobile view * resolved: added is_trading_assessment_for_existing_user_enabled in Proptypes * fix: incorporated review comments * fix: incorporated review comments * resolved: added is_svg based on compliance requirements * resolved: replace with suggested stylings * resolved: updated hide placeholder prop inside of select native component * fix: localize issue * renamed the icon * refactor: ♻️ incorporated review comments * resolved: change position of text and value in config file * fix: 🎨 removed index based key for child elements * fix: fix typo in testwarning modal and remove duplicate modals in trading assessment * fix: remove banner after financial assessment change and remove notification from trading screen * fix: 🐛 incorrect display of notification * fix: refactor warning modal in trading-assessment * resolved: change component key * resolved: change is_risk_client --> is_risky_client based on comment * fix: circle ci fail test * feat: ✨ moved employment field to personal details incase of MF clients * Revert "likhith/moved employment field to personal details incase of MF clients" (#37) * likhith/moved employment status field (#38) * feat: ✨ moved employment status field * Create CNAME * Delete CNAME * feat: 💄 added style to highlight next section button * perf: 💄 incorporated fied changes * feat: 🐛 title case * feat: 🔥 removed unwanted state * feat: ♻️ reverted code changes of diff package * feat: 🐛 added key prop to iterating component * fix: 🐛 removed decorators * feat: ♻️ incorporated review comments * feat: ♻️ incorporated review comments * feat: ♻️ removed extensions * feat: ♻️ incorporated review comments * feat: ♻️ Added comments to explain code logic * feat: ♻️ reordered imports * feat: ♻️ incorporated styling changes * feat: 🐛 navigate the user to next question * feat: 🐛 resolved logout error * fix: add warning icon to cooldown warning modal * fix: display correct cool down modal for new client signup * feat: 🐛 missing warning when trading assessment values are changed * fix: submit button not triggered in mozilla * fix: 🚑 logic fix to trigger click event in mozilla * fix: resolve memory leak for risk modal * fix: move employment fieldset at the bottom * fix: added space to remove overlapping text on fieldset * fix: 🎨 reused component * fix: 🎨 reused component * fix: next and previous button fix * fix: change employement status field in personal details page * ci: fix circle ci issues Co-authored-by: Likhith Kolayari <likhith@regentmarkets.com> Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> Co-authored-by: Eduard Hrachou <107860964+eduard-deriv@users.noreply.github.com> Co-authored-by: yauheni-kryzhyk-deriv <103182683+yauheni-kryzhyk-deriv@users.noreply.github.com> Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com> Co-authored-by: amina-deriv <84661147+amina-deriv@users.noreply.github.com> Co-authored-by: George Usynin <103181646+george-usynin-binary@users.noreply.github.com> Co-authored-by: Carol Sachdeva <58209918+carol-binary@users.noreply.github.com> Co-authored-by: Farzin Mirzaie <72082844+farzin-fs@users.noreply.github.com> Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> Co-authored-by: Niloofar Sadeghi <93518187+niloo-fs@users.noreply.github.com> Co-authored-by: vinu-deriv <100689171+vinu-deriv@users.noreply.github.com> Co-authored-by: Nijil Nirmal <nijil@deriv.com> Co-authored-by: Bahar <bahar@firstsource.tech> Co-authored-by: Hamid <hamid@re-work.dev> Co-authored-by: Shayan Khaleghparast <100833613+iman-fs@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> Co-authored-by: Matin shafiei <matin@deriv.com> Co-authored-by: System Administrator <root@Likhith-Kolayaris-MacBook-Pro-C02G8AT9MD6M.local>
aizad-deriv
pushed a commit
that referenced
this pull request
Mar 15, 2023
* Initial commit * added mobile view * feat: ✨ added info hints and mobile view * feat: ➕ displays vanilla options under trade types * feat: 🚧 incorporated mobile view * feat: 💄 added icons * feat: 💄 incorporated new UI changes * feat: 💄 added required styling * feat: 🎨 incorporated the changes for report section (#34) * feat: ✨ description changes * feat: ✨ incorporated strike field changes * feat: 🎨 fixed the title for mobile view stake field * feat: ✨ incorporated mobile view * feat: 🔥 removed master changes * feat: 🎨 incorporated payout button change * feat: purchase button text css * feat: ✨ disabled barrier drag for vanilla * fix: 🐛 strike field design fix * feat: 💄 incorporated info hint message for Payout button * fix: 🐛 title change * fix: 🐛 payout per point value fix * feat: ✨ incorporated barrier validation condition for vanilla * feat: ✨ computing min-max stake values * refactor: ♻️ incorporated review comments * feat: add vanilla contract card for desktop * feat: add vanilla contract card for contract details * feat: change label to strike for vanilla contracts in contract details * feat: use bid price for contract value * feat: add vanilla option card for recent positions * feat: ✨ incorporated condition to show contract audit * feat: ✨ incorporated strike and Payout per point values in open position * feat: ✨ incorporated chart floating message change for vanilla trade * fix: enable collapsible button for vanilla contracts * feat: 🎨 incorporated chart long code message for vanilla * feat: ⚡ incorporated contract card for mobile * feat: ✨ incorporated chart markers for mobile and desktop * feat: ✨ incorporated currency unit for Payout per point * feat: 🎨 color refactor * feat: add responsive vanilla options card * fix: strike formatting * feat: add vanilla trade types component * feat: implement new design for vanilla trade types * fix: sort ui store * fix: sort trade store * fix: UI changes for vanilla option trade params * feat: new design for trade parameters on mobile * fix: remove unused variable * fix: strike spot area * feat: change design for vanilla option open positions for mobile * fix: refactor code * fix: merge issue * feat: ♻️ incorporated review comments * fix: review comments * refactor: ♻️ incorporated review comments * refactor: ♻️ incorporated view port sizes * fix: remove comments * fix: unlocalized strings * fix: populate barrier options on error response * fix: 🐛 report title fix * fix: daily VO contracts to show in recent positions * fix: update to latest content * fix: content issues * feat: add sorting logic for trade types * fix: 🐛 resolved input validation failed error * fix: incorrect label for vanilla calls * fix: the icon is incorrect for some of the trades * fix: 🐛 strike price is empty when there is duration change * fix: 🐛 strike price dropdown is empty for day duration change * fix: 🐛 modified stake boundary calculation for vanilla opts * fix: callout not showing in contract details * fix: 🐛 removed unused code snip * fix: 🐛 capture stake boundary on error * fix: merge conflicts * fix: 🐛 ensuring correct boundary is set based on type of Vanilla contract * fix: 🐛 set strike vlaue and list on error response * fix: remove currency based rounding for usd amounts * fix: payout rounding value * fix: format numbers based on currency in p&l callout * fix: change colors for vanilla closed contracts * fix: 🐛 call proposal API on strike change * feat: changed vanilla trade description * feat: content change * fix: 🐛 added missing label * fix: align profit label only when it appears on the screen * fix: 🐛 corrected field name * fix: 🐛 refactored code to support additional configs * fix: change icon colors in dark mode * fix: 🐛 incorporated + sign in reports * fix: 🐛 resolved issue with double error message * fix: exit spot placement on y-axis * feat: modified the content as per figma * fix: tooltip alignment for strike description * fix: size units * feat: change content everywhere according to latest design * feat: 🎨 added tooltip for stake * feat: incorporated styles to stake tooltip * fix: 🐛 fixed the type issue * chore: ♻️ incorporated naming conventions * feat: change paddings and profit/loss label positioning in mobile * feat: content update as per figma * fix: incorrect profit logic for prematurely sold contracts * feat: change mobile modal to tooltip * feat: 💄 set the layout for vanilla trade --------- Co-authored-by: Likhith Kolayari <likhith@regentmarkets.com> Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com>
aizad-deriv
pushed a commit
that referenced
this pull request
Mar 28, 2023
* Merge '67492_accumulators_purchase' into 'maryia/67492/task_add_accumulators' * Maryia/75617/add_accu_to_trade_params (#3) * initialized ACCU trade params for responsive * added LabeledQuantityInputMobile & improved AccumulatorsAmountMobile * feat: added Accumulator radio group for growth_rate * feat: finalized Accumulator growth_rates radio group for mobile * feat: responsive- added Take profit to trade params & aligned purchase button icon * feat: improved mobile trade params for ACCU * feat: finalized trade params for ACCU * maryia/72761/task_add_recent_positions_drawer (#4) * feat: initialized ACCU contract card in recent positions * feat: initialized ProgressSliderSolidLine for ACCU * feat: updated recent positions card for ACCU for open/lost/won states * chore: improvements for ACCU card in responsive recent positions * chore: added TickCounterProgressBar component * feat: added TickCounterBar and reverted ProgressSlider & ProgressSliderMobile * chore: reverted original Recent positions drawer width * chore: improved TickCounterBar styling * maryia/76528/task_implement_contract_details_drawer (#5) * chore: updated Details in contract card for ACCU + styling * feat: implemented ACCU contract card in contract details + improved recent positions * chore: updated icons for ACCU trade type & contract category * maryia/72769/add_ticks_history_stats_widget (#6) * feat: init version of TicksHistoryStatsWidget for ACCU * chore: TicksHistoryStats * chore: improved tick history styling * chore: added more styles & animated progress dots under latest counter * feat: finalized desktop ticks history stats for dtrader page * feat: added ticks history to contract details page * improved ticks history stats for desktop & initialized it for responsive * made responsive stats non-expandable * maryia/77261/task_manual_for_history_widget (#8) * chore: discarded getUpdatedTicksHistoryStats as BE will send 15 exact values instead of 100+latest * feat: added AccumulatorsStatsManualModal * feat: finalized AccumulatorsStatsManualModal for desktop & responsive * chore: added getUpdatedTicksHistoryStats to process arrays of counters with epochs expected from BE * feat: added expanded AccumulatorsStats dialog for responsive * chore: contract card styling improvements + using ACCU tick_count as max_ticks_number * chore: improved AccumulatorsStats to load after tick counters have loaded * maryia/75621/task_add_tests_and_restyle_contract_card (#9) * chore: improved ACCU contract type icon & label styling in contract card * chore: added tests for accumulator.js helper function * chore: added tests for Accumulator.jsx * maryia/75621/part_2_task_accu_barriers (#10) * chore: updated dummy data * chore: fixed history stats styles & added tests for AccumulatorsStats * chore: improved AccumulatorsStats and its tests * chore: updated contract card & open positions * maryia/75621/add barriers for stay in contract on trader page (#12) * chore: test out passing trade data to all-markers for drawing barriers without contract + improvements * feat: added barriers for accumulators without open contract * feat: added markers and barriers for stay in contract on trader page * chore: adjusted open contract profit label (#13) * yauheni/77994/trader add break out contract type (#14) * yauheni/77994/trader add break out contract type * regexp fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * yauheni/78429/update styles of tick history widget (#15) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * chore: prepared data for connecting API (#16) * Maryia/78473/part 2 prepare for api + improvements (#18) * chore: improved barriers without contract and open contract label * chore: prepared data for api connection * chore: added price tags for barriers in contract details (#19) * feat: initialized AccumulatorsProfitLossTooltip (#20) * yauheni/78477/update params with buttons for responsive (#17) * yauheni/78477/update params with buttons for responsive * fix styles accordingly to design * buttons gap fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * yauheni/resolve build errors (#21) * yauheni/resolve build errors * optional property for is_checkbox_hidden Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Yauheni/78633/update styles for tick history widget (#22) * yauheni/resolve build errors * yauheni/78633/update styles for tick history widget * yauheni/78633/update styles for tick history widget responsive Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * maryia/78839/complete_sold_labels (#23) * chore: added tolltips for all sold positions & won/lost coloring * feat: finalized AccumulatorsProfitLossTooltip * maryia/improvements for stats and tooltip (#24) * chore: accumulators stats improvements * improvements * maryia/improvements for sold contract label * maryia/78574/add_barriers_to_contract_details * maryia/79085/remove_break_out_history_from_stats_widget (#26) * maryia/79085/remove_break_out_history_from_stats * chore: made purchaseButtonsOverlay flexible * chore: added tests for PurchaseButtonsOverlay * Yauheni/77995/update trade params for stayin breakout (#25) * yauheni/77995/update trade params for stayin breakout * take profit alimngment * buttons styles, take profit alingment * maryia/78574/add_barriers_to_contract_details * stake font and icon fix, go_tp_reports button styles * update contract store from parent Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: maryia-binary <maryia@binary.com> * maryia/fix: styles & fonts for responsive trade types * Maryia/79549/part 1: update tick markers for ACCU in contract details + improvements (#27) * maryia/79549/add_tick_markers_contract_details * chore: improvements for styles in responsive trade types desc * yauheni/79530/remove breakout contract (#28) * yauheni/79530/remove breakout contract * proposal data fields fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * maryia/styling improvements * maryia/fix: forcing Div100vh to re-render when height_offset for responsive has changed * maryia/fix: observables + markers * maryia/chore: prevented barriers, labels and markers from going outside axes (#30) * maryia/79969/set_default_chart_type_and_interval_to_Area_and_1_tick * maryia/chore: changed trade type name to Accumulators * maryia/80163/set growth rate based on default value from BE contracts_for response * yauheni/80091/hide chart mode icon for accumulators (#33) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * maryia/80166/connect_to_available_API (#34) * chore: connected api without contracts_for for now * chore: updated proposal * chore: updated tests for new proposal * maryia/80163/add-growth-rate-to-purchase-button * maryia/refactored purchase button growth_rate text * maryia/chore: removed unused code for outside barriers * maryia/fix: barrier shade color for ongoing contract * feat: restore chart mode set for non accumulators contract after switching (#37) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * yauheni/80158/update ui according to latest design (design flow 1-2) (#36) * icon accumulator change * purchase btn, stats fix * fix styles, flow 1 * accumulator design flow 2 Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Maryia/80686/feat: profit text animation for ongoing contract (#39) * fix: showing profit text next to current spot for open contract * chore: animated profit text * feat: added animated profit text for ongoing contract * test: fixed a test * chore: removed unused variable * fix: maryia/80686/profit text color * fix: maryia/using default growth rate only if no stored growth rate * feat: allow accumulators only for demo account (#40) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Yauheni/80158/update UI according to latest design part 2 (#38) * accu design chart position fix * accu page for reports rendering * reports card design fix * reports card design fix2 * updated design fix * pseudoelement colon fix * emphasizing value fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * maryia/80687/ticks_contract_details (#41) * fix: tick markers in contract details & take profit logics * feat: showing only 10 last ticks for accumulators ongoing contract * chore: display all trade types when list is not empty * style: typo * chore: maryia/added opacity to profit text + connected contracts_for + refactoring * chore: improved tick stream for ACCU in contract details + stats alignment * chore: maryia/handled undefined profit & updated opacity animation timing * chore: temporary dummy api connection * fix: maryia/hide profit if undefined, display if number * revert: dummi api * feat: implement last design part 1 (#43) * feat: implement last design part 1 * fix: test text fix * refactor: stats style for mobile fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Maryia/82425/task highlight crossing tick (#42) * feat: hightlighting crossing tick * feat: sync highlighting of crossing tick based on ticks_history_stats * Maryia/83069/task: replace image with video manual (#44) * feat: replaced manual image with video + responsive stats improvement * test: fixed a test * fix: entry tick marker in dtrader * style: removed extra margin-bottom * feat: implement last design part 2 (#45) * feat: implement last design part 2 * fix: initial growth_rate added * refactor: growth_rate from contract_for delete Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * refactor: accu sold contract tooltip animation change (deriv-com#49) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Maryia/82257/Contract Details tick markers + AccumulatorsProfitLossText refactoring (deriv-com#48) * chore: saving canvas context before accu barriers are drawn and restoring when finished drawing * fix: endtime, avoid fetching history in replay, avoid 0 profit animation * chore: forcing chart reload when start_epoch changes to earlier epoch + refactored profit-text * refactor: accumulators-profit-loss-text * refactor: tooltip style and tests (deriv-com#51) * refactor: tooltip style and tests * refactor: accumulator info text * refactor: profit tooltip text test add * refactor: radiogroupwithinfomobile test added * refactor: tickhistorycounter tests added * refactor: tickcounterbar test added Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Maryia/83311/Refactoring, tests, TS migration (deriv-com#50) * refactor: purchase-buttons-overlay.spec.js from enzyme to jest * style: removed extra variable * refactor: from accumulator.js with chai to accumulator.spec.js with jest * refactor: removed unused dummy data * test: added tests for accumulators-stats-manual-modal.jsx * chore: improved accumulators-stats-manual-modal * refactor: incapsulated AccumulatorsChartElements in trade.jsx * fix: maryia/circleci eslint error * feat: maryia/added dark theme video manual for stats + fix for circleci * test: maryia/added tests for AccumulatorsInfoDisplay & LabeledQuantityInputMobile * chore: maryia/ address review comments + updated videos * fix: maryia/open positions: auto-select Accumulators if has open ACCU contracts * refactor: accumulatorschartelements test added (deriv-com#52) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * style: maryia/apply review suggestions * style: maryia/apply review suggestions * refactor: maryia/refactoring + small improvements & adjustments * chore: add built icons file * fix: circleci tests + improvements * chore: refactoring + added loader before video manual first loads * refactor: improvements + addressed review comments * yauheni/qa checks refactoring 1 (deriv-com#53) * refactor: open recent position after buying contract for mobile * fix: accu card curent stake name field * fix: popover accumulator radio group text and alignment * fix: open position accumulate column name Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * fix: last truncated counter in responsive (deriv-com#54) * Maryia/83807/stake validation (part 1) (deriv-com#55) * fix: set growth_rate based on accumulator_range_list (growth_rate_range) received in contracts_for * fix: app crash caused by proposal error * chore: removed unused classname * fix: growth rate title alignment (deriv-com#56) * fix: growht rate title alignment * refactor: category wrapper odd style Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * maryia/83807/fix: stake validation for ACCU broken because of barriers being set (deriv-com#57) * fix: stake validation for ACCU broken because of barriers being set * fix: prevent app crash in profit table for unknown contracts * fix: check if selected growth_rate is available on symbol change (deriv-com#58) * fix: able to buy multiply contract / growth rate fix BO change (deriv-com#59) * fix: able to buy multiply contract / growth rate fix BO change * refactor: last contract check delete Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * revert: maryia/revert change of last_contract computed * fix: accumulator is shown for real account (deriv-com#60) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * feat: make cursor not allowd for overlay (deriv-com#61) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * chore: built icons.js * revert: maryia/ unnecessary bot file change * refactor: contract categories in contract-type-widget.jsx * refactor: according to pr review comments * refactor: open positions + add keys to fix console warning * fix: disable accu for real account, disable button having bought one contract (deriv-com#62) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * refactor: purchase.jsx * refactor: according to pr reviews * refactor: able to buy contract per every available underlying (deriv-com#63) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Trigger Build * yauheni/85032/ fix chart issue with dots and circles Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * fix: exit spot styles * refactor: make barrier values string as on BE * fix: unable accumulators for real * maryia/refactor_accu_branch (deriv-com#66) * refactor: remove unused file * refactor: refactor createTickMarkers * refactor: introduce a local variable * fix: 86705/ticks are not displayed correctly on chart in contract details * maryia/86953/build: bump up deriv-charts version to 1.1.0 + improvement (deriv-com#68) * build: bump up deriv-charts version * chore: show profit only when barriers are received * test: updated mocked props * build: maryia/removed extra package-lock.jsons * evgeniy /87215/87226/ info description / glitch while switching account (deriv-com#70) * fix: description * fix: disable trade params while switching account --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * henry/87329/fix: FE not showing error message when accu trading is suspended (deriv-com#72) * fix: FE not showing error message when accu trading is suspended * test: empty commit --------- Co-authored-by: HENRY <henry@regentmarkets.com> * refactor: glitching fix and deleted odd css (deriv-com#73) * refactor: glitching fix and deleted odd css * fix: code refactor --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Maryia/86616/feat: calculating accu barriers based on ticks from ticks_history (deriv-com#71) * feat: calculating accu barriers based on ticks from ticks_history * chore: rounded & refactored accu barriers * refactor: added getAccumulatorBarriers for barrier calculation + fixed a test * chore: improved barriers calculations * refactor: getAccumulatorBarriers docs * refactor: getAccumulatorBarriers * fix: showing barriers only when having have barriers & always showing barrier lines in C.Details * build: updated package-lock & icons + fixed conflicts + linting * fix: max stake validation is missing (deriv-com#81) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * fix: maryia/87948/chart empty issue + profit text effects clean-up * henry/87958/feat: Add Dropdown for rates in Accumulator (deriv-com#86) * feat: Add Dropdown for rates in Accumulator * chore: code cleanup * Update packages/reports/src/Containers/open-positions.jsx Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> --------- Co-authored-by: HENRY <henry@regentmarkets.com> Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> * Maryia/86616/make 2 last ticks bold + refactoring (deriv-com#84) * chore: make prelast & last tick bold * chore: adjust styles for previous and last markers in c.details * refactor: getSupportedContracts & getContractTypeDisplay in configs * refactor: open-positions * refactor: chart-markers slyles * style: updated All rates casing * build: update package-lock * Henry/87958/feat add all rates dropdown accumulator (deriv-com#89) * feat: Add Dropdown for rates in Accumulator * chore: code cleanup * Update packages/reports/src/Containers/open-positions.jsx Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> * chore: remove console log * fix: Change Open positions total for multiplier and accumulator to flex --------- Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> * refactor: open-positions * fix: remove unused eslint disable * revert: package-lock * fix: sell button disappearing in mobile accumulators (deriv-com#92) * Henry/89489/fix sell button missing accumulator (deriv-com#95) * fix: sell button disappearing in mobile accumulators * fix: fix cut off buy button issue * fix: remove commented out code * maryia/89432/fix: show barriers for current symbol correctly (deriv-com#94) * fix: show barriers for current symbol * refactor: show barriers for current symbol only * Maryia/test: added tests for getAccumulatorBarriers function (deriv-com#99) * test: added tests for getAccumulatorBarriers function * test: added tests for getAccumulatorBarriers function * test: renamed test cases for getAccumulatorBarriers function * Maryia/89927_2/fix: ticks_history not forgotten because of chart mode & granularity change (deriv-com#101) * fix: logics for changing chart mode & granularity caused ticks_history streaming for previous symbol * fix: update chart mode just once when switching contract type * fix: maryia/fixed logics for chart mode switching * refactor: maryia/address review comments * Merge branch master of github.com:binary-com/deriv-app into maryia/67492/task_add_accumulators * Update vanilla-options-card-body.jsx * fix: vanillas + accumulators adjustments * fix: maryia/restore overriden accu change * fix: maryia/vanillas+accumulators adjustment * fix: maryia/ improvements + refactoring to address review comments * fix: maryia/ update c.details chart when end_epoch is defined * fix: reset accu barriers data on every contract type change * fix: revert ui-store to master * fix: chart mode change when switching to symbol without accu * fix: purchase button styling for accumulators (deriv-com#109) Co-authored-by: Henry Hein <henryhein@Henry-Heins-MacBook-Pro-T90XTJ00Q4.local> --------- Co-authored-by: Maryia <103177211+maryia-binary@users.noreply.github.com> Co-authored-by: yauheni-kryzhyk-deriv <103182683+yauheni-kryzhyk-deriv@users.noreply.github.com> Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com> Co-authored-by: henry-deriv <118344354+henry-deriv@users.noreply.github.com> Co-authored-by: HENRY <henry@regentmarkets.com> Co-authored-by: Matin shafiei <matin@deriv.com> Co-authored-by: Henry Hein <henryhein@Henry-Heins-MacBook-Pro-T90XTJ00Q4.local> Co-authored-by: hirad-deriv <hirad@re-work.dev>
aizad-deriv
added a commit
that referenced
this pull request
May 17, 2023
* refactor: initial commit * revert: revert changes * chore: ts-migration for positions-card.tsx (#5) * chore: reports-table-row to tsx (#10) * chore: migrating error-components to tsx (#8) * chore: migrating error-components to tsx * fix: added partial to type * chore: migrate calendar-icon to tsx (#11) * chore: migrate calendar-icon to tsx * fix: updated extensions * chore: migrate list-item to tsx (#12) * chore: migrate currency-wrapper to ts (#17) * chore: migrate empty-portfolio-message to ts (#18) * chore: migrating reports meta to tsx (#23) * chore: migrate amount-cell to ts (#16) * chore: migrate amount-cell to ts * fix: delete component because it is unused * chore: migrating EmptyTradeHistoryMessage to tsx (#19) * chore: migrating EmptyTradeHistoryMessage to tsx * fix: remove extension * fix: migrated sidelist to tsx (#13) * fix: migrated sidelist to tsx * fix: circle-ci error * fix: sidelist types * chore: migrate composite calendar mobile to typescript (#26) * chore: migrate composite calendar mobile to typescript * fix: remove component extension from the name * refactor: ♻️ removed unused component (#30) * chore: migrate index file to typescript (#27) * refactor: ♻️ migrate component to tsx (#29) * chore: two-month-picker to tsx with one calendar component (#15) * chore: migrate account statistics to ts (#14) * chore: migrate account statistics to ts * fix: typo in comment * Akmal / chore: migrate routes config to typescript (#31) * chore: migrate routes config to typescript * fix: change type for component * Akmal / chore: migrate data-table-constants to typescript (#33) * chore: migrate data-table-constants to typescript * fix: refactor types * chore: migrate loading component to typescript (#36) * Aizad/73988/msir ts (#21) * chore: migrate market-symbol-icon-row to ts * fix: remove commented lines * fix: remove classname from IconTradeTypes * fix: removed action prop * Sergei / chore: migrate open-positions to tsx (#40) * chore: convert open-positions to tsx * fix: add React.PropsWithChildren to tabs.tsx * fix: change Tabs type * fix: add/change some types and fix some undefined values * refactor: use Return Early pattern for contract-card-sell component * chore: delete commented lines * chore: add moment as dev dependency * chore: commit to check circleCI * fix: change back tabs.tsx * fix: change React.Fragment to null * Akmal / chore: convert helpers to typescript (#28) * chore: convert elpers to typescript * fix: types * chore: migrate placeholder to tsx (#42) * chore: migate placeholder to tsx * fix: destructure props and remove React.propswithchildre * Sergei / 73980 / chore: ts migration of route-with-sub-routes (#45) * chore: ts migration of route-with-sub-routes * refactor: add common types to separate files * fix: get back composite-calendar * refactor: change path from absolute to relative for Types * Sergei / 73979 / chore: ts migration of binary-routes (deriv-com#46) * chore: ts migration of binary-routes.jsx * chore: add TPassthrough type and add key as index when route.path is undefined * chore: add export for TBinaryRoutes type * refactor: use types from common types * Aizad/73977/binary link ts (#41) * chore: migrate routes folder to tsx * fix: change type for component * fix: migrated test cases to tsx * chore: migrate binary-links to tsx * fix: change back function names * fix: resolved conflict issues * fix: testcases * chore: migrated filter component and fix some issues with composite-c… (#20) * chore: migrated filter component and fix some issues with composite-calendar * fix: change export to CalendarIcon on index.js and added RootStore type to filter-components * fix: change TRootStore to RootStore * fix: replace RootStore to TRootStore * fix: expand object for filtered_date_range * Sergei / chore: ts migration of routes (#38) * chore: ts migration of routes * chore: change RootStore type * Aizad/73994/pss ts (deriv-com#48) * chore: migrate progress-slider-stream to tsx * fix: imported TContractInfo inside deriv/shared/ * Sergei / chore: migrate statements to tsx (#39) * chore: ts migration of statements * chore: change RootStore type * chore: change local TRootStore with module property * fix: return class RootStore to Stores/index.ts * chore: change core_store type * chore: migrated indicative cell to tsx (#44) * chore: migrated indicative cell to tsx * fix: added types to usestate * fix: change type * fix: change function type to boolean * fix: imported TContractInfo from shared file into indicative-cell * fix: test * fix: mockstore * fix: format-response.ts * fix: mockstore * Aizad/73978/routes ts (deriv-com#50) * Merge branch 'Improvement/72232/Reports_TS_migration' of github.com:mahdiyeh-deriv/deriv-app into ts-migration * chore: finalising routes folder migration for Reports package 📦 * Akmal / chore: migrate app.jsx to typescript (#37) * chore: migrate app.jsx to typescript * chore: utilize TRootStore type * chore: replace type * Akmal / chore: migrate composite calendar to typescript (#25) * chore: migrate composite calendar to typescript * chore: refactor composite calendar and related components to properly use moment * chore: move out index changes * feat: resolve conflicts * feat: add deriv stores package * Kate/73995/TS migration of Reports (deriv-com#51) * refactor: migrate reports component into ts * refactor: add useStore hook * refactor: delete extra react fragment Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> --------- Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> * redeploy: rerun tests * refactor: remove named import from react * chore: migrate statement to tsx (deriv-com#47) * chore: migrate statement to tsx * fix: use Statement props from api-types than declaring it in ts file * fix: imported TAccountStatistics inside statement * fix: made changes based on comments * fix: refactor based on suggestions * fix: types in packages/shared/src/utils/shortcode/shortcode.ts * fix: regex to prevent sonarcloud bug * chore: change index.js to index.ts * Rostislav / 73993 / Task - TS migration of ProfitTable (#34) * refactor: init pr * refactor: profit_loss_cell tsx'd * refactor: profit_loss_cell import problem resolved * refactor: profit_loss_cell import another problem fix * refactor: the migration is more or less finished * refactor: a few extra changes * refactor: prev commit accidental changes removed * refactor: TProfitTable type changed a bit * refactor: moved types to common-prop.type.ts * refactor: getSupportedContracts and getUnsupportedContracts moved to shared * refactor: contract.tsx completely replaced by imports from @deriv/shared * refactor: added alias for Types * refactor: applied suggested changes * fix: regex for sonarcloud * fix: remove props from the name of type declaration * fix: resolve comments * fix: fix comments v2 * fix: remove usestate * fix: date-time test * fix: comments v3 * thisyahlen/fix: trade table for mobile (deriv-com#52) * fix: trade table for mobile * fix: trade table error * fix: statement input validation error on date_from * fix: setdate unix * fix: responsive input validation error * fix: remove unix from store --------- Co-authored-by: aizad-deriv <103104395+aizad-deriv@users.noreply.github.com> Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com> Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> Co-authored-by: Sergei Baranovski <120570511+sergei-deriv@users.noreply.github.com> Co-authored-by: kate-deriv <121025168+kate-deriv@users.noreply.github.com> Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> Co-authored-by: Rostik Kayko <119863957+rostislav-deriv@users.noreply.github.com> Co-authored-by: Thisyahlen Nair <thisyahlen@regentmarkets.com> Co-authored-by: thisyahlen <104053934+thisyahlen-deriv@users.noreply.github.com> Co-authored-by: hirad-deriv <hirad@re-work.dev>
aizad-deriv
added a commit
that referenced
this pull request
May 26, 2023
* matin/chore: update branch (#8026) * thisyahlen/chore: new account verification modal for purchase authentication (#7936) * chore: new account verification modal for purchase authentication * fix: height and width * fix: modal footer css * fix: css mobile title * thisyahlen/fix: remove financial mt5 for norway and japan (#7846) * fix: remove financial mt5 for norway and japan * fix: resolved comments * fix: rename restricetd countries * fix: compare accounts table * fix: fix compare accounts table for norway/japan * fix: remove synthetic bvi for norway and japan * Jim/88166/delay in real account creation flow after clicking add account button in the account creation popup (#7926) * chore: remove duplicate get_settings api request * chore: set account_settings in client-store if undefined * chore: remove unnecessary else block * refactor: convert if expression to ternary * chore: set account_settings in client store instead of creating a local variable * fix: :sparkles: allows users to enter accented name characters (#7832) * fix: :sparkles: allows users to enter accented name characters * chore: :wastebasket: removes unused 'letter_symbol' variable * fix: :bug: allows accented characters in name for existing users * docs: :pencil2: comment on the regex used for name validation * resused regex function Co-authored-by: Yashim Wong <yashim@regentmarkets.com> * fix: :memo: imported reused regex function * fix: :memo: comment on regex function used --------- Co-authored-by: Yashim Wong <yashim@regentmarkets.com> * Evgeniy / 89431 / no error message for idv duplicated document numbers (#7743) * fix: no error message for idv duplicated document numbers * feat: idv testing document whitelist * refactor: function rename, code and test fix * refactor: code style change, review fixes --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Hamid/90702/account switchers to wrong deriv account when performing deposit via bank wire (#7933) * chore: icon changes after build * fix: redirect user to non-eu account instead eu after cashier deposit switch account * Ameerul /Task 89855 Add a checkbox to select/deselect a payment method when creating or updating a sell ad and making a sell order (#7824) * chore: added checkbox to payment method card * fix: added logic to disable checkbox and show checkbox in certain tabs only * Maryia/80948/fix: avoid rate limit error by storing counter after sending verification email in Withdrawal (#7218) * fix: instantiating useVerifyEmail object once for each email verification case to avoid settimeout leak in useCountdown * chore: store verify_email_sent_count in store instead of locally * test: fix test for email-verification-empty-state.tsx * fix: avoid counter reset by storing and using the time an email was last sent * chore: a workaround for VerifyEmailRequest type declared with an extra required field in api-types * chore: remove api-types workaround * build: update @deriv/api-types to 1.0.85 * revert: api-types version upgrade * revert: package-lock * revert: modal-manager.jsx * revert: modal-manager.jsx * thisyahlen/fix: error when switch to mf (#7778) * fix: error when switch to mf * fix: addressed comments * fix: addressed comments v2 * chore: fix tooltip language not updating on change language (#7871) * chore: fix tooltip language not updating on change language * fix: added checks for currency in trade store * fix: added delete amount validation rules in reaction * fix: remove delete rule in reaction * fix: remove mistake * fix: typo * Aizad/89113/sidebar platform fix (#7697) * chore: fix mobile sidebar platform for eu * fix: codecov error * fix: codecov error * chore: update packages * Nada/88951/change chat url (#7798) * fix: get chat url from p2p_order_create instead of p2p_chat_create * fix: fixed issue with order details page * fix: chat channel url empty issue fixed for p2p_order_create response * fix: function added to store * fix: added timeout for setting chat_channel in order details * fix: pr comments fixed * fix: increased time out * fix: removed delay for going to details page from list * thisyahlen/fix: top up mt5 demo (#7665) * fix: top up demo * fix: deriv x as well * redeploy: a * chore: update pdf in acuity download modal (#7567) * fix: filter currencies by name (#7493) * fix: changed pop up message for no recommendations (#7693) * Aizad/89700/onboarding btn fix (#7813) * chore: disable cursor on account switcher button onboarding * fix: Add the same behavior for Options and Multipliers section Trade Button * fix: added default class and refactor scss * Nada/89550/remove validation ad amount (#7753) * fix: removed error validation for amount greater than user's balance * fix: added popup for creating ad greater than balance * fix: pr comments fixed * fix: reuse common modal for visibility errors * Aizad/88786/mt5 redirection modal fix (#7663) * chore: fix mt5 redirection modal closing on trade * fix: modal and dialog close seperately after clicking outside * fix: re-add dialog_status condition back to redirect-notice-modal * fix: reverted the previous changes * fix: remove useclickoutside for page overlay * fix: update deriv/api package to latest version * fix: updated package version to match with master * Merge branch 'develop' of github.com:binary-com/deriv-app into aizad/88786/mt5-redirection-modal-fix * fix: codecov and circleci * fix: upgrade package * fix: theme switch in poroduction (#7781) * translations: 📚 sync translations with crowdin (#7989) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * yashim/chore: remove indonesia from production (#7999) * chore: remove trading experience incomplete (#8005) * chore: remove trading experience incomplete * fix: remove is cfd score available * thisyahlen/hotfix: wrong restriction message for austria (#8006) * hotfix: wrong restriction message for austria * fix: Empty-Commit * Revert "thisyahlen/hotfix: wrong restriction message for austria (#8006)" (#8013) This reverts commit 56baec7d879efd25f05249323911641ce069ab63. * Revert "Jim/88166/delay in real account creation flow after clicking add account button in the account creation popup (#7926)" (#8016) This reverts commit 8bb13518f4cebd42bc3d2a602807d7c1b6aa5b6a. * fix: :bug: fetches latest personal details every time intead of cached value (#8002) * Revert "Maryia/80948/fix: avoid rate limit error by storing counter a… (#8020) * Revert "Maryia/80948/fix: avoid rate limit error by storing counter after sending verification email in Withdrawal (#7218)" This reverts commit cc0065d02761a33502405d35a47a45696292858d. * revert: reverted setIsCFDScoreAvailable from client.store * Revert "fix: :bug: fetches latest personal details every time intead of cached value (#8002)" (#8022) This reverts commit ff497c14ec9fe0b831031b0d9bae1532f9c47456. --------- Co-authored-by: thisyahlen <104053934+thisyahlen-deriv@users.noreply.github.com> Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> Co-authored-by: Shaheer <122449658+shaheer-deriv@users.noreply.github.com> Co-authored-by: Yashim Wong <yashim@regentmarkets.com> Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com> Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: Hamid <hamid@deriv.com> Co-authored-by: ameerul-deriv <103412909+ameerul-deriv@users.noreply.github.com> Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> Co-authored-by: Aizad Ridzo <103104395+aizad-deriv@users.noreply.github.com> Co-authored-by: nada-deriv <122768621+nada-deriv@users.noreply.github.com> Co-authored-by: Farrah Mae Ochoa <82315152+farrah-deriv@users.noreply.github.com> Co-authored-by: rupato-deriv <97010868+rupato-deriv@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> Co-authored-by: Yashim Wong <yashim@deriv.com> Co-authored-by: vinu-deriv <100689171+vinu-deriv@users.noreply.github.com> * hamza/90127/91316/sub-feat: swapfree onboarding screen addition v1.0 (#7961) * feat: swapfree onboarding screen addition v1.0 * fix: name changes and Title updated as per design * Syncing Master with the Feature Brnach of Swapfree (#8056) * thisyahlen/chore: new account verification modal for purchase authentication (#7936) * chore: new account verification modal for purchase authentication * fix: height and width * fix: modal footer css * fix: css mobile title * thisyahlen/fix: remove financial mt5 for norway and japan (#7846) * fix: remove financial mt5 for norway and japan * fix: resolved comments * fix: rename restricetd countries * fix: compare accounts table * fix: fix compare accounts table for norway/japan * fix: remove synthetic bvi for norway and japan * Jim/88166/delay in real account creation flow after clicking add account button in the account creation popup (#7926) * chore: remove duplicate get_settings api request * chore: set account_settings in client-store if undefined * chore: remove unnecessary else block * refactor: convert if expression to ternary * chore: set account_settings in client store instead of creating a local variable * fix: :sparkles: allows users to enter accented name characters (#7832) * fix: :sparkles: allows users to enter accented name characters * chore: :wastebasket: removes unused 'letter_symbol' variable * fix: :bug: allows accented characters in name for existing users * docs: :pencil2: comment on the regex used for name validation * resused regex function Co-authored-by: Yashim Wong <yashim@regentmarkets.com> * fix: :memo: imported reused regex function * fix: :memo: comment on regex function used --------- Co-authored-by: Yashim Wong <yashim@regentmarkets.com> * Evgeniy / 89431 / no error message for idv duplicated document numbers (#7743) * fix: no error message for idv duplicated document numbers * feat: idv testing document whitelist * refactor: function rename, code and test fix * refactor: code style change, review fixes --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Hamid/90702/account switchers to wrong deriv account when performing deposit via bank wire (#7933) * chore: icon changes after build * fix: redirect user to non-eu account instead eu after cashier deposit switch account * Ameerul /Task 89855 Add a checkbox to select/deselect a payment method when creating or updating a sell ad and making a sell order (#7824) * chore: added checkbox to payment method card * fix: added logic to disable checkbox and show checkbox in certain tabs only * Maryia/80948/fix: avoid rate limit error by storing counter after sending verification email in Withdrawal (#7218) * fix: instantiating useVerifyEmail object once for each email verification case to avoid settimeout leak in useCountdown * chore: store verify_email_sent_count in store instead of locally * test: fix test for email-verification-empty-state.tsx * fix: avoid counter reset by storing and using the time an email was last sent * chore: a workaround for VerifyEmailRequest type declared with an extra required field in api-types * chore: remove api-types workaround * build: update @deriv/api-types to 1.0.85 * revert: api-types version upgrade * revert: package-lock * revert: modal-manager.jsx * revert: modal-manager.jsx * thisyahlen/fix: error when switch to mf (#7778) * fix: error when switch to mf * fix: addressed comments * fix: addressed comments v2 * chore: fix tooltip language not updating on change language (#7871) * chore: fix tooltip language not updating on change language * fix: added checks for currency in trade store * fix: added delete amount validation rules in reaction * fix: remove delete rule in reaction * fix: remove mistake * fix: typo * Aizad/89113/sidebar platform fix (#7697) * chore: fix mobile sidebar platform for eu * fix: codecov error * fix: codecov error * chore: update packages * Nada/88951/change chat url (#7798) * fix: get chat url from p2p_order_create instead of p2p_chat_create * fix: fixed issue with order details page * fix: chat channel url empty issue fixed for p2p_order_create response * fix: function added to store * fix: added timeout for setting chat_channel in order details * fix: pr comments fixed * fix: increased time out * fix: removed delay for going to details page from list * thisyahlen/fix: top up mt5 demo (#7665) * fix: top up demo * fix: deriv x as well * redeploy: a * chore: update pdf in acuity download modal (#7567) * fix: filter currencies by name (#7493) * fix: changed pop up message for no recommendations (#7693) * Aizad/89700/onboarding btn fix (#7813) * chore: disable cursor on account switcher button onboarding * fix: Add the same behavior for Options and Multipliers section Trade Button * fix: added default class and refactor scss * Nada/89550/remove validation ad amount (#7753) * fix: removed error validation for amount greater than user's balance * fix: added popup for creating ad greater than balance * fix: pr comments fixed * fix: reuse common modal for visibility errors * Aizad/88786/mt5 redirection modal fix (#7663) * chore: fix mt5 redirection modal closing on trade * fix: modal and dialog close seperately after clicking outside * fix: re-add dialog_status condition back to redirect-notice-modal * fix: reverted the previous changes * fix: remove useclickoutside for page overlay * fix: update deriv/api package to latest version * fix: updated package version to match with master * Merge branch 'develop' of github.com:binary-com/deriv-app into aizad/88786/mt5-redirection-modal-fix * fix: codecov and circleci * fix: upgrade package * fix: theme switch in poroduction (#7781) * translations: 📚 sync translations with crowdin (#7989) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * yashim/chore: remove indonesia from production (#7999) * chore: remove trading experience incomplete (#8005) * chore: remove trading experience incomplete * fix: remove is cfd score available * thisyahlen/hotfix: wrong restriction message for austria (#8006) * hotfix: wrong restriction message for austria * fix: Empty-Commit * Revert "thisyahlen/hotfix: wrong restriction message for austria (#8006)" (#8013) This reverts commit 56baec7d879efd25f05249323911641ce069ab63. * Revert "Jim/88166/delay in real account creation flow after clicking add account button in the account creation popup (#7926)" (#8016) This reverts commit 8bb13518f4cebd42bc3d2a602807d7c1b6aa5b6a. * fix: :bug: fetches latest personal details every time intead of cached value (#8002) * Revert "Maryia/80948/fix: avoid rate limit error by storing counter a… (#8020) * Revert "Maryia/80948/fix: avoid rate limit error by storing counter after sending verification email in Withdrawal (#7218)" This reverts commit cc0065d02761a33502405d35a47a45696292858d. * revert: reverted setIsCFDScoreAvailable from client.store * Revert "fix: :bug: fetches latest personal details every time intead of cached value (#8002)" (#8022) This reverts commit ff497c14ec9fe0b831031b0d9bae1532f9c47456. * Adrienne / Prefetched email verification modal (#8027) * chore: prefetched email verification modal * chore: added settimoeut * chore: used eager mode * chore: import model directly * chore: reverted direct imports * chore: added settimeout * translations: 📚 sync translations with crowdin (#8031) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * translations: 📚 sync translations with crowdin (#8040) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> Co-authored-by: yashim-deriv <yashim@deriv.com> * Maryia/67492/task_add_accumulators (#6406) * Merge '67492_accumulators_purchase' into 'maryia/67492/task_add_accumulators' * Maryia/75617/add_accu_to_trade_params (#3) * initialized ACCU trade params for responsive * added LabeledQuantityInputMobile & improved AccumulatorsAmountMobile * feat: added Accumulator radio group for growth_rate * feat: finalized Accumulator growth_rates radio group for mobile * feat: responsive- added Take profit to trade params & aligned purchase button icon * feat: improved mobile trade params for ACCU * feat: finalized trade params for ACCU * maryia/72761/task_add_recent_positions_drawer (#4) * feat: initialized ACCU contract card in recent positions * feat: initialized ProgressSliderSolidLine for ACCU * feat: updated recent positions card for ACCU for open/lost/won states * chore: improvements for ACCU card in responsive recent positions * chore: added TickCounterProgressBar component * feat: added TickCounterBar and reverted ProgressSlider & ProgressSliderMobile * chore: reverted original Recent positions drawer width * chore: improved TickCounterBar styling * maryia/76528/task_implement_contract_details_drawer (#5) * chore: updated Details in contract card for ACCU + styling * feat: implemented ACCU contract card in contract details + improved recent positions * chore: updated icons for ACCU trade type & contract category * maryia/72769/add_ticks_history_stats_widget (#6) * feat: init version of TicksHistoryStatsWidget for ACCU * chore: TicksHistoryStats * chore: improved tick history styling * chore: added more styles & animated progress dots under latest counter * feat: finalized desktop ticks history stats for dtrader page * feat: added ticks history to contract details page * improved ticks history stats for desktop & initialized it for responsive * made responsive stats non-expandable * maryia/77261/task_manual_for_history_widget (#8) * chore: discarded getUpdatedTicksHistoryStats as BE will send 15 exact values instead of 100+latest * feat: added AccumulatorsStatsManualModal * feat: finalized AccumulatorsStatsManualModal for desktop & responsive * chore: added getUpdatedTicksHistoryStats to process arrays of counters with epochs expected from BE * feat: added expanded AccumulatorsStats dialog for responsive * chore: contract card styling improvements + using ACCU tick_count as max_ticks_number * chore: improved AccumulatorsStats to load after tick counters have loaded * maryia/75621/task_add_tests_and_restyle_contract_card (#9) * chore: improved ACCU contract type icon & label styling in contract card * chore: added tests for accumulator.js helper function * chore: added tests for Accumulator.jsx * maryia/75621/part_2_task_accu_barriers (#10) * chore: updated dummy data * chore: fixed history stats styles & added tests for AccumulatorsStats * chore: improved AccumulatorsStats and its tests * chore: updated contract card & open positions * maryia/75621/add barriers for stay in contract on trader page (#12) * chore: test out passing trade data to all-markers for drawing barriers without contract + improvements * feat: added barriers for accumulators without open contract * feat: added markers and barriers for stay in contract on trader page * chore: adjusted open contract profit label (#13) * yauheni/77994/trader add break out contract type (#14) * yauheni/77994/trader add break out contract type * regexp fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * yauheni/78429/update styles of tick history widget (#15) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * chore: prepared data for connecting API (#16) * Maryia/78473/part 2 prepare for api + improvements (#18) * chore: improved barriers without contract and open contract label * chore: prepared data for api connection * chore: added price tags for barriers in contract details (#19) * feat: initialized AccumulatorsProfitLossTooltip (#20) * yauheni/78477/update params with buttons for responsive (#17) * yauheni/78477/update params with buttons for responsive * fix styles accordingly to design * buttons gap fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * yauheni/resolve build errors (#21) * yauheni/resolve build errors * optional property for is_checkbox_hidden Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Yauheni/78633/update styles for tick history widget (#22) * yauheni/resolve build errors * yauheni/78633/update styles for tick history widget * yauheni/78633/update styles for tick history widget responsive Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * maryia/78839/complete_sold_labels (#23) * chore: added tolltips for all sold positions & won/lost coloring * feat: finalized AccumulatorsProfitLossTooltip * maryia/improvements for stats and tooltip (#24) * chore: accumulators stats improvements * improvements * maryia/improvements for sold contract label * maryia/78574/add_barriers_to_contract_details * maryia/79085/remove_break_out_history_from_stats_widget (#26) * maryia/79085/remove_break_out_history_from_stats * chore: made purchaseButtonsOverlay flexible * chore: added tests for PurchaseButtonsOverlay * Yauheni/77995/update trade params for stayin breakout (#25) * yauheni/77995/update trade params for stayin breakout * take profit alimngment * buttons styles, take profit alingment * maryia/78574/add_barriers_to_contract_details * stake font and icon fix, go_tp_reports button styles * update contract store from parent Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: maryia-binary <maryia@binary.com> * maryia/fix: styles & fonts for responsive trade types * Maryia/79549/part 1: update tick markers for ACCU in contract details + improvements (#27) * maryia/79549/add_tick_markers_contract_details * chore: improvements for styles in responsive trade types desc * yauheni/79530/remove breakout contract (#28) * yauheni/79530/remove breakout contract * proposal data fields fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * maryia/styling improvements * maryia/fix: forcing Div100vh to re-render when height_offset for responsive has changed * maryia/fix: observables + markers * maryia/chore: prevented barriers, labels and markers from going outside axes (#30) * maryia/79969/set_default_chart_type_and_interval_to_Area_and_1_tick * maryia/chore: changed trade type name to Accumulators * maryia/80163/set growth rate based on default value from BE contracts_for response * yauheni/80091/hide chart mode icon for accumulators (#33) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * maryia/80166/connect_to_available_API (#34) * chore: connected api without contracts_for for now * chore: updated proposal * chore: updated tests for new proposal * maryia/80163/add-growth-rate-to-purchase-button * maryia/refactored purchase button growth_rate text * maryia/chore: removed unused code for outside barriers * maryia/fix: barrier shade color for ongoing contract * feat: restore chart mode set for non accumulators contract after switching (#37) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * yauheni/80158/update ui according to latest design (design flow 1-2) (#36) * icon accumulator change * purchase btn, stats fix * fix styles, flow 1 * accumulator design flow 2 Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Maryia/80686/feat: profit text animation for ongoing contract (#39) * fix: showing profit text next to current spot for open contract * chore: animated profit text * feat: added animated profit text for ongoing contract * test: fixed a test * chore: removed unused variable * fix: maryia/80686/profit text color * fix: maryia/using default growth rate only if no stored growth rate * feat: allow accumulators only for demo account (#40) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Yauheni/80158/update UI according to latest design part 2 (#38) * accu design chart position fix * accu page for reports rendering * reports card design fix * reports card design fix2 * updated design fix * pseudoelement colon fix * emphasizing value fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * maryia/80687/ticks_contract_details (#41) * fix: tick markers in contract details & take profit logics * feat: showing only 10 last ticks for accumulators ongoing contract * chore: display all trade types when list is not empty * style: typo * chore: maryia/added opacity to profit text + connected contracts_for + refactoring * chore: improved tick stream for ACCU in contract details + stats alignment * chore: maryia/handled undefined profit & updated opacity animation timing * chore: temporary dummy api connection * fix: maryia/hide profit if undefined, display if number * revert: dummi api * feat: implement last design part 1 (#43) * feat: implement last design part 1 * fix: test text fix * refactor: stats style for mobile fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Maryia/82425/task highlight crossing tick (#42) * feat: hightlighting crossing tick * feat: sync highlighting of crossing tick based on ticks_history_stats * Maryia/83069/task: replace image with video manual (#44) * feat: replaced manual image with video + responsive stats improvement * test: fixed a test * fix: entry tick marker in dtrader * style: removed extra margin-bottom * feat: implement last design part 2 (#45) * feat: implement last design part 2 * fix: initial growth_rate added * refactor: growth_rate from contract_for delete Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * refactor: accu sold contract tooltip animation change (#49) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Maryia/82257/Contract Details tick markers + AccumulatorsProfitLossText refactoring (#48) * chore: saving canvas context before accu barriers are drawn and restoring when finished drawing * fix: endtime, avoid fetching history in replay, avoid 0 profit animation * chore: forcing chart reload when start_epoch changes to earlier epoch + refactored profit-text * refactor: accumulators-profit-loss-text * refactor: tooltip style and tests (#51) * refactor: tooltip style and tests * refactor: accumulator info text * refactor: profit tooltip text test add * refactor: radiogroupwithinfomobile test added * refactor: tickhistorycounter tests added * refactor: tickcounterbar test added Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Maryia/83311/Refactoring, tests, TS migration (#50) * refactor: purchase-buttons-overlay.spec.js from enzyme to jest * style: removed extra variable * refactor: from accumulator.js with chai to accumulator.spec.js with jest * refactor: removed unused dummy data * test: added tests for accumulators-stats-manual-modal.jsx * chore: improved accumulators-stats-manual-modal * refactor: incapsulated AccumulatorsChartElements in trade.jsx * fix: maryia/circleci eslint error * feat: maryia/added dark theme video manual for stats + fix for circleci * test: maryia/added tests for AccumulatorsInfoDisplay & LabeledQuantityInputMobile * chore: maryia/ address review comments + updated videos * fix: maryia/open positions: auto-select Accumulators if has open ACCU contracts * refactor: accumulatorschartelements test added (#52) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * style: maryia/apply review suggestions * style: maryia/apply review suggestions * refactor: maryia/refactoring + small improvements & adjustments * chore: add built icons file * fix: circleci tests + improvements * chore: refactoring + added loader before video manual first loads * refactor: improvements + addressed review comments * yauheni/qa checks refactoring 1 (#53) * refactor: open recent position after buying contract for mobile * fix: accu card curent stake name field * fix: popover accumulator radio group text and alignment * fix: open position accumulate column name Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * fix: last truncated counter in responsive (#54) * Maryia/83807/stake validation (part 1) (#55) * fix: set growth_rate based on accumulator_range_list (growth_rate_range) received in contracts_for * fix: app crash caused by proposal error * chore: removed unused classname * fix: growth rate title alignment (#56) * fix: growht rate title alignment * refactor: category wrapper odd style Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * maryia/83807/fix: stake validation for ACCU broken because of barriers being set (#57) * fix: stake validation for ACCU broken because of barriers being set * fix: prevent app crash in profit table for unknown contracts * fix: check if selected growth_rate is available on symbol change (#58) * fix: able to buy multiply contract / growth rate fix BO change (#59) * fix: able to buy multiply contract / growth rate fix BO change * refactor: last contract check delete Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * revert: maryia/revert change of last_contract computed * fix: accumulator is shown for real account (#60) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * feat: make cursor not allowd for overlay (#61) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * chore: built icons.js * revert: maryia/ unnecessary bot file change * refactor: contract categories in contract-type-widget.jsx * refactor: according to pr review comments * refactor: open positions + add keys to fix console warning * fix: disable accu for real account, disable button having bought one contract (#62) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * refactor: purchase.jsx * refactor: according to pr reviews * refactor: able to buy contract per every available underlying (#63) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Trigger Build * yauheni/85032/ fix chart issue with dots and circles Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * fix: exit spot styles * refactor: make barrier values string as on BE * fix: unable accumulators for real * maryia/refactor_accu_branch (#66) * refactor: remove unused file * refactor: refactor createTickMarkers * refactor: introduce a local variable * fix: 86705/ticks are not displayed correctly on chart in contract details * maryia/86953/build: bump up deriv-charts version to 1.1.0 + improvement (#68) * build: bump up deriv-charts version * chore: show profit only when barriers are received * test: updated mocked props * build: maryia/removed extra package-lock.jsons * evgeniy /87215/87226/ info description / glitch while switching account (#70) * fix: description * fix: disable trade params while switching account --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * henry/87329/fix: FE not showing error message when accu trading is suspended (#72) * fix: FE not showing error message when accu trading is suspended * test: empty commit --------- Co-authored-by: HENRY <henry@regentmarkets.com> * refactor: glitching fix and deleted odd css (#73) * refactor: glitching fix and deleted odd css * fix: code refactor --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Maryia/86616/feat: calculating accu barriers based on ticks from ticks_history (#71) * feat: calculating accu barriers based on ticks from ticks_history * chore: rounded & refactored accu barriers * refactor: added getAccumulatorBarriers for barrier calculation + fixed a test * chore: improved barriers calculations * refactor: getAccumulatorBarriers docs * refactor: getAccumulatorBarriers * fix: showing barriers only when having have barriers & always showing barrier lines in C.Details * build: updated package-lock & icons + fixed conflicts + linting * fix: max stake validation is missing (#81) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * fix: maryia/87948/chart empty issue + profit text effects clean-up * henry/87958/feat: Add Dropdown for rates in Accumulator (#86) * feat: Add Dropdown for rates in Accumulator * chore: code cleanup * Update packages/reports/src/Containers/open-positions.jsx Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> --------- Co-authored-by: HENRY <henry@regentmarkets.com> Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> * Maryia/86616/make 2 last ticks bold + refactoring (#84) * chore: make prelast & last tick bold * chore: adjust styles for previous and last markers in c.details * refactor: getSupportedContracts & getContractTypeDisplay in configs * refactor: open-positions * refactor: chart-markers slyles * style: updated All rates casing * build: update package-lock * Henry/87958/feat add all rates dropdown accumulator (#89) * feat: Add Dropdown for rates in Accumulator * chore: code cleanup * Update packages/reports/src/Containers/open-positions.jsx Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> * chore: remove console log * fix: Change Open positions total for multiplier and accumulator to flex --------- Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> * refactor: open-positions * fix: remove unused eslint disable * revert: package-lock * fix: sell button disappearing in mobile accumulators (#92) * Henry/89489/fix sell button missing accumulator (#95) * fix: sell button disappearing in mobile accumulators * fix: fix cut off buy button issue * fix: remove commented out code * maryia/89432/fix: show barriers for current symbol correctly (#94) * fix: show barriers for current symbol * refactor: show barriers for current symbol only * Maryia/test: added tests for getAccumulatorBarriers function (#99) * test: added tests for getAccumulatorBarriers function * test: added tests for getAccumulatorBarriers function * test: renamed test cases for getAccumulatorBarriers function * Maryia/89927_2/fix: ticks_history not forgotten because of chart mode & granularity change (#101) * fix: logics for changing chart mode & granularity caused ticks_history streaming for previous symbol * fix: update chart mode just once when switching contract type * fix: maryia/fixed logics for chart mode switching * refactor: maryia/address review comments * Merge branch master of github.com:binary-com/deriv-app into maryia/67492/task_add_accumulators * Update vanilla-options-card-body.jsx * fix: vanillas + accumulators adjustments * fix: maryia/restore overriden accu change * fix: maryia/vanillas+accumulators adjustment * fix: maryia/ improvements + refactoring to address review comments * fix: maryia/ update c.details chart when end_epoch is defined * fix: reset accu barriers data on every contract type change * fix: revert ui-store to master * fix: chart mode change when switching to symbol without accu * fix: purchase button styling for accumulators (#109) Co-authored-by: Henry Hein <henryhein@Henry-Heins-MacBook-Pro-T90XTJ00Q4.local> --------- Co-authored-by: Maryia <103177211+maryia-binary@users.noreply.github.com> Co-authored-by: yauheni-kryzhyk-deriv <103182683+yauheni-kryzhyk-deriv@users.noreply.github.com> Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com> Co-authored-by: henry-deriv <118344354+henry-deriv@users.noreply.github.com> Co-authored-by: HENRY <henry@regentmarkets.com> Co-authored-by: Matin shafiei <matin@deriv.com> Co-authored-by: Henry Hein <henryhein@Henry-Heins-MacBook-Pro-T90XTJ00Q4.local> Co-authored-by: hirad-deriv <hirad@re-work.dev> * Amina /77701_make signup form fields immutable if they are immutable from BE (#7544) * adding validation * changeablle fields from client store * mutate address fields * fix: test case * fix: test case * fix: spec_file * fix: making employment status immutable * fix: trading assessment * fix: trading assessment * fix: trading assessment * fix: test case after merge conflict * fix: hide idv section when client is age verified * fix: remove idv_disallowed check * chore: merge master * fix: add new status --------- Co-authored-by: hirad-deriv <hirad@re-work.dev> * translations: 📚 sync translations with crowdin (#8048) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * translations: 📚 sync translations with crowdin (#8049) Co-authored-by: yashim-deriv <yashim@deriv.com> Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * translations: 📚 sync translations with crowdin (#8050) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> --------- Co-authored-by: thisyahlen <104053934+thisyahlen-deriv@users.noreply.github.com> Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> Co-authored-by: Shaheer <122449658+shaheer-deriv@users.noreply.github.com> Co-authored-by: Yashim Wong <yashim@regentmarkets.com> Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com> Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: Hamid <hamid@deriv.com> Co-authored-by: ameerul-deriv <103412909+ameerul-deriv@users.noreply.github.com> Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> Co-authored-by: Aizad Ridzo <103104395+aizad-deriv@users.noreply.github.com> Co-authored-by: nada-deriv <122768621+nada-deriv@users.noreply.github.com> Co-authored-by: Farrah Mae Ochoa <82315152+farrah-deriv@users.noreply.github.com> Co-authored-by: rupato-deriv <97010868+rupato-deriv@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> Co-authored-by: Yashim Wong <yashim@deriv.com> Co-authored-by: vinu-deriv <100689171+vinu-deriv@users.noreply.github.com> Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> Co-authored-by: Maryia <103177211+maryia-binary@users.noreply.github.com> Co-authored-by: yauheni-kryzhyk-deriv <103182683+yauheni-kryzhyk-deriv@users.noreply.github.com> Co-authored-by: henry-deriv <118344354+henry-deriv@users.noreply.github.com> Co-authored-by: HENRY <henry@regentmarkets.com> Co-authored-by: Matin shafiei <matin@deriv.com> Co-authored-by: Henry Hein <henryhein@Henry-Heins-MacBook-Pro-T90XTJ00Q4.local> Co-authored-by: hirad-deriv <hirad@re-work.dev> Co-authored-by: amina-deriv <84661147+amina-deriv@users.noreply.github.com> * feat: demo account creation and payload updated v1.0 (#8058) * feat: demo account creation and payload updated v1.0 * feat: demo fix Trade Popup * feat: demo and real popup fixed with deriv api-types type missing v1.2 * fix: real Get more content modal updated * fix: modal title for demo and svg account * fix: modal title for demo and svg account v1.3 * fix: get more button fix real v1.4 * fix: juridisction modal * fix: transfer icon cashier updated * fix: transfer icon cashier updated v1.2 * fix: modal unmount selected account type on close * chore: Demo text added v1.0 * fix: test coverage * fix: title for demo top up * fix: Demo added in the title for demo * fix: cfd account card * fix: juridisction content change * fix: juridisction content change + leverage fix * refactor: type checks and reviewed suggestions * refactor: hook with test cases added as per review comment * refactor: function added and switch case changed to localize to support different language scenario * Feat sub 90127 syncing the master with swapfree development (#8196) * thisyahlen/chore: new account verification modal for purchase authentication (#7936) * chore: new account verification modal for purchase authentication * fix: height and width * fix: modal footer css * fix: css mobile title * thisyahlen/fix: remove financial mt5 for norway and japan (#7846) * fix: remove financial mt5 for norway and japan * fix: resolved comments * fix: rename restricetd countries * fix: compare accounts table * fix: fix compare accounts table for norway/japan * fix: remove synthetic bvi for norway and japan * Jim/88166/delay in real account creation flow after clicking add account button in the account creation popup (#7926) * chore: remove duplicate get_settings api request * chore: set account_settings in client-store if undefined * chore: remove unnecessary else block * refactor: convert if expression to ternary * chore: set account_settings in client store instead of creating a local variable * fix: :sparkles: allows users to enter accented name characters (#7832) * fix: :sparkles: allows users to enter accented name characters * chore: :wastebasket: removes unused 'letter_symbol' variable * fix: :bug: allows accented characters in name for existing users * docs: :pencil2: comment on the regex used for name validation * resused regex function Co-authored-by: Yashim Wong <yashim@regentmarkets.com> * fix: :memo: imported reused regex function * fix: :memo: comment on regex function used --------- Co-authored-by: Yashim Wong <yashim@regentmarkets.com> * Evgeniy / 89431 / no error message for idv duplicated document numbers (#7743) * fix: no error message for idv duplicated document numbers * feat: idv testing document whitelist * refactor: function rename, code and test fix * refactor: code style change, review fixes --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Hamid/90702/account switchers to wrong deriv account when performing deposit via bank wire (#7933) * chore: icon changes after build * fix: redirect user to non-eu account instead eu after cashier deposit switch account * Ameerul /Task 89855 Add a checkbox to select/deselect a payment method when creating or updating a sell ad and making a sell order (#7824) * chore: added checkbox to payment method card * fix: added logic to disable checkbox and show checkbox in certain tabs only * Maryia/80948/fix: avoid rate limit error by storing counter after sending verification email in Withdrawal (#7218) * fix: instantiating useVerifyEmail object once for each email verification case to avoid settimeout leak in useCountdown * chore: store verify_email_sent_count in store instead of locally * test: fix test for email-verification-empty-state.tsx * fix: avoid counter reset by storing and using the time an email was last sent * chore: a workaround for VerifyEmailRequest type declared with an extra required field in api-types * chore: remove api-types workaround * build: update @deriv/api-types to 1.0.85 * revert: api-types version upgrade * revert: package-lock * revert: modal-manager.jsx * revert: modal-manager.jsx * thisyahlen/fix: error when switch to mf (#7778) * fix: error when switch to mf * fix: addressed comments * fix: addressed comments v2 * chore: fix tooltip language not updating on change language (#7871) * chore: fix tooltip language not updating on change language * fix: added checks for currency in trade store * fix: added delete amount validation rules in reaction * fix: remove delete rule in reaction * fix: remove mistake * fix: typo * Aizad/89113/sidebar platform fix (#7697) * chore: fix mobile sidebar platform for eu * fix: codecov error * fix: codecov error * chore: update packages * Nada/88951/change chat url (#7798) * fix: get chat url from p2p_order_create instead of p2p_chat_create * fix: fixed issue with order details page * fix: chat channel url empty issue fixed for p2p_order_create response * fix: function added to store * fix: added timeout for setting chat_channel in order details * fix: pr comments fixed * fix: increased time out * fix: removed delay for going to details page from list * thisyahlen/fix: top up mt5 demo (#7665) * fix: top up demo * fix: deriv x as well * redeploy: a * chore: update pdf in acuity download modal (#7567) * fix: filter currencies by name (#7493) * fix: changed pop up message for no recommendations (#7693) * Aizad/89700/onboarding btn fix (#7813) * chore: disable cursor on account switcher button onboarding * fix: Add the same behavior for Options and Multipliers section Trade Button * fix: added default class and refactor scss * Nada/89550/remove validation ad amount (#7753) * fix: removed error validation for amount greater than user's balance * fix: added popup for creating ad greater than balance * fix: pr comments fixed * fix: reuse common modal for visibility errors * Aizad/88786/mt5 redirection modal fix (#7663) * chore: fix mt5 redirection modal closing on trade * fix: modal and dialog close seperately after clicking outside * fix: re-add dialog_status condition back to redirect-notice-modal * fix: reverted the previous changes * fix: remove useclickoutside for page overlay * fix: update deriv/api package to latest version * fix: updated package version to match with master * Merge branch 'develop' of github.com:binary-com/deriv-app into aizad/88786/mt5-redirection-modal-fix * fix: codecov and circleci * fix: upgrade package * fix: theme switch in poroduction (#7781) * translations: 📚 sync translations with crowdin (#7989) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * yashim/chore: remove indonesia from production (#7999) * chore: remove trading experience incomplete (#8005) * chore: remove trading experience incomplete * fix: remove is cfd score available * thisyahlen/hotfix: wrong restriction message for austria (#8006) * hotfix: wrong restriction message for austria * fix: Empty-Commit * Revert "thisyahlen/hotfix: wrong restriction message for austria (#8006)" (#8013) This reverts commit 56baec7d879efd25f05249323911641ce069ab63. * Revert "Jim/88166/delay in real account creation flow after clicking add account button in the account creation popup (#7926)" (#8016) This reverts commit 8bb13518f4cebd42bc3d2a602807d7c1b6aa5b6a. * fix: :bug: fetches latest personal details every time intead of cached value (#8002) * Revert "Maryia/80948/fix: avoid rate limit error by storing counter a… (#8020) * Revert "Maryia/80948/fix: avoid rate limit error by storing counter after sending verification email in Withdrawal (#7218)" This reverts commit cc0065d02761a33502405d35a47a45696292858d. * revert: reverted setIsCFDScoreAvailable from client.store * Revert "fix: :bug: fetches latest personal details every time intead of cached value (#8002)" (#8022) This reverts commit ff497c14ec9fe0b831031b0d9bae1532f9c47456. * Adrienne / Prefetched email verification modal (#8027) * chore: prefetched email verification modal * chore: added settimoeut * chore: used eager mode * chore: import model directly * chore: reverted direct imports * chore: added settimeout * translations: 📚 sync translations with crowdin (#8031) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * translations: 📚 sync translations with crowdin (#8040) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> Co-authored-by: yashim-deriv <yashim@deriv.com> * Maryia/67492/task_add_accumulators (#6406) * Merge '67492_accumulators_purchase' into 'maryia/67492/task_add_accumulators' * Maryia/75617/add_accu_to_trade_params (#3) * initialized ACCU trade params for responsive * added LabeledQuantityInputMobile & improved AccumulatorsAmountMobile * feat: added Accumulator radio group for growth_rate * feat: finalized Accumulator growth_rates radio group for mobile * feat: responsive- added Take profit to trade params & aligned purchase button icon * feat: improved mobile trade params for ACCU * feat: finalized trade params for ACCU * maryia/72761/task_add_recent_positions_drawer (#4) * feat: initialized ACCU contract card in recent positions * feat: initialized ProgressSliderSolidLine for ACCU * feat: updated recent positions card for ACCU for open/lost/won states * chore: improvements for ACCU card in responsive recent positions * chore: added TickCounterProgressBar component * feat: added TickCounterBar and reverted ProgressSlider & ProgressSliderMobile * chore: reverted original Recent positions drawer width * chore: improved TickCounterBar styling * maryia/76528/task_implement_contract_details_drawer (#5) * chore: updated Details in contract card for ACCU + styling * feat: implemented ACCU contract card in contract details + improved recent positions * chore: updated icons for ACCU trade type & contract category * maryia/72769/add_ticks_history_stats_widget (#6) * feat: init version of TicksHistoryStatsWidget for ACCU * chore: TicksHistoryStats * chore: improved tick history styling * chore: added more styles & animated progress dots under latest counter * feat: finalized desktop ticks history stats for dtrader page * feat: added ticks history to contract details page * improved ticks history stats for desktop & initialized it for responsive * made responsive stats non-expandable * maryia/77261/task_manual_for_history_widget (#8) * chore: discarded getUpdatedTicksHistoryStats as BE will send 15 exact values instead of 100+latest * feat: added AccumulatorsStatsManualModal * feat: finalized AccumulatorsStatsManualModal for desktop & responsive * chore: added getUpdatedTicksHistoryStats to process arrays of counters with epochs expected from BE * feat: added expanded AccumulatorsStats dialog for responsive * chore: contract card styling improvements + using ACCU tick_count as max_ticks_number * chore: improved AccumulatorsStats to load after tick counters have loaded * maryia/75621/task_add_tests_and_restyle_contract_card (#9) * chore: improved ACCU contract type icon & label styling in contract card * chore: added tests for accumulator.js helper function * chore: added tests for Accumulator.jsx * maryia/75621/part_2_task_accu_barriers (#10) * chore: updated dummy data * chore: fixed history stats styles & added tests for AccumulatorsStats * chore: improved AccumulatorsStats and its tests * chore: updated contract card & open positions * maryia/75621/add barriers for stay in contract on trader page (#12) * chore: test out passing trade data to all-markers for drawing barriers without contract + improvements * feat: added barriers for accumulators without open contract * feat: added markers and barriers for stay in contract on trader page * chore: adjusted open contract profit label (#13) * yauheni/77994/trader add break out contract type (#14) * yauheni/77994/trader add break out contract type * regexp fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * yauheni/78429/update styles of tick history widget (#15) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * chore: prepared data for connecting API (#16) * Maryia/78473/part 2 prepare for api + improvements (#18) * chore: improved barriers without contract and open contract label * chore: prepared data for api connection * chore: added price tags for barriers in contract details (#19) * feat: initialized AccumulatorsProfitLossTooltip (#20) * yauheni/78477/update params with buttons for responsive (#17) * yauheni/78477/update params with buttons for responsive * fix styles accordingly to design * buttons gap fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * yauheni/resolve build errors (#21) * yauheni/resolve build errors * optional property for is_checkbox_hidden Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Yauheni/78633/update styles for tick history widget (#22) * yauheni/resolve build errors * yauheni/78633/update styles for tick history widget * yauheni/78633/update styles for tick history widget responsive Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * maryia/78839/complete_sold_labels (#23) * chore: added tolltips for all sold positions & won/lost coloring * feat: finalized AccumulatorsProfitLossTooltip * maryia/improvements for stats and tooltip (#24) * chore: accumulators stats improvements * improvements * maryia/improvements for sold contract label * maryia/78574/add_barriers_to_contract_details * maryia/79085/remove_break_out_history_from_stats_widget (#26) * maryia/79085/remove_break_out_history_from_stats * chore: made purchaseButtonsOverlay flexible * chore: added tests for PurchaseButtonsOverlay * Yauheni/77995/update trade params for stayin breakout (#25) * yauheni/77995/update trade params for stayin breakout * take profit alimngment * buttons styles, take profit alingment * maryia/78574/add_barriers_to_contract_details * stake font and icon fix, go_tp_reports button styles * update contract store from parent Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: maryia-binary <maryia@binary.com> * maryia/fix: styles & fonts for responsive trade types * Maryia/79549/part 1: update tick markers for ACCU in contract details + improvements (#27) * maryia/79549/add_tick_markers_contract_details * chore: improvements for styles in responsive trade types desc * yauheni/79530/remove breakout contract (#28) * yauheni/79530/remove breakout contract * proposal data fields fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * maryia/styling improvements * maryia/fix: forcing Div100vh to re-render when height_offset for responsive has changed * maryia/fix: observables + markers * maryia/chore: prevented barriers, labels and markers from going outside axes (#30) * maryia/79969/set_default_chart_type_and_interval_to_Area_and_1_tick * maryia/chore: changed trade type name to Accumulators * maryia/80163/set growth rate based on default value from BE contracts_for response * yauheni/80091/hide chart mode icon for accumulators (#33) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * maryia/80166/connect_to_available_API (#34) * chore: connected api without contracts_for for now * chore: updated proposal * chore: updated tests for new proposal * maryia/80163/add-growth-rate-to-purchase-button * maryia/refactored purchase button growth_rate text * maryia/chore: removed unused code for outside barriers * maryia/fix: barrier shade color for ongoing contract * feat: restore chart mode set for non accumulators contract after switching (#37) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * yauheni/80158/update ui according to latest design (design flow 1-2) (#36) * icon accumulator change * purchase btn, stats fix * fix styles, flow 1 * accumulator design flow 2 Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Maryia/80686/feat: profit text animation for ongoing contract (#39) * fix: showing profit text next to current spot for open contract * chore: animated profit text * feat: added animated profit text for ongoing contract * test: fixed a test * chore: removed unused variable * fix: maryia/80686/profit text color * fix: maryia/using default growth rate only if no stored growth rate * feat: allow accumulators only for demo account (#40) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Yauheni/80158/update UI according to latest design part 2 (#38) * accu design chart position fix * accu page for reports rendering * reports card design fix * reports card design fix2 * updated design fix * pseudoelement colon fix * emphasizing value fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * maryia/80687/ticks_contract_details (#41) * fix: tick markers in contract details & take profit logics * feat: showing only 10 last ticks for accumulators ongoing contract * chore: display all trade types when list is not empty * style: typo * chore: maryia/added opacity to profit text + connected contracts_for + refactoring * chore: improved tick stream for ACCU in contract details + stats alignment * chore: maryia/handled undefined profit & updated opacity animation timing * chore: temporary dummy api connection * fix: maryia/hide profit if undefined, display if number * revert: dummi api * feat: implement last design part 1 (#43) * feat: implement last design part 1 * fix: test text fix * refactor: stats style for mobile fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Maryia/82425/task highlight crossing tick (#42) * feat: hightlighting crossing tick * feat: sync highlighting of crossing tick based on ticks_history_stats * Maryia/83069/task: replace image with video manual (#44) * feat: replaced manual image with video + responsive stats improvement * test: fixed a test * fix: entry tick marker in dtrader * style: removed extra margin-bottom * feat: implement last design part 2 (#45) * feat: implement last design part 2 * fix: initial growth_rate added * refactor: growth_rate from contract_for delete Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * refactor: accu sold contract tooltip animation change (#49) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Maryia/82257/Contract Details tick markers + AccumulatorsProfitLossText refactoring (#48) * chore: saving canvas context before accu barriers are drawn and restoring when finished drawing * fix: endtime, avoid fetching history in replay, avoid 0 profit animation * chore: forcing chart reload when start_epoch changes to earlier epoch + refactored profit-text * refactor: accumulators-profit-loss-text * refactor: tooltip style and tests (#51) * refactor: tooltip style and tests * refactor: accumulator info text * refactor: profit tooltip text test add * refactor: radiogroupwithinfomobile test added * refactor: tickhistorycounter tests added * refactor: tickcounterbar test added Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Maryia/83311/Refactoring, tests, TS migration (#50) * refactor: purchase-buttons-overlay.spec.js from enzyme to jest * style: removed extra variable * refactor: from accumulator.js with chai to accumulator.spec.js with jest * refactor: removed unused dummy data * test: added tests for accumulators-stats-manual-modal.jsx * chore: improved accumulators-stats-manual-modal * refactor: incapsulated AccumulatorsChartElements in trade.jsx * fix: maryia/circleci eslint error * feat: maryia/added dark theme video manual for stats + fix for circleci * test: maryia/added tests for AccumulatorsInfoDisplay & LabeledQuantityInputMobile * chore: maryia/ address review comments + updated videos * fix: maryia/open positions: auto-select Accumulators if has open ACCU contracts * refactor: accumulatorschartelements test added (#52) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * style: maryia/apply review suggestions * style: maryia/apply review suggestions * refactor: maryia/refactoring + small improvements & adjustments * chore: add built icons file * fix: circleci tests + improvements * chore: refactoring + added loader before video manual first loads * refactor: improvements + addressed review comments * yauheni/qa checks refactoring 1 (#53) * refactor: open recent position after buying contract for mobile * fix: accu card curent stake name field * fix: popover accumulator radio group text and alignment * fix: open position accumulate column name Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * fix: last truncated counter in responsive (#54) * Maryia/83807/stake validation (part 1) (#55) * fix: set growth_rate based on accumulator_range_list (growth_rate_range) received in contracts_for * fix: app crash caused by proposal error * chore: removed unused classname * fix: growth rate title alignment (#56) * fix: growht rate title alignment * refactor: category wrapper odd style Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * maryia/83807/fix: stake validation for ACCU broken because of barriers being set (#57) * fix: stake validation for ACCU broken because of barriers being set * fix: prevent app crash in profit table for unknown contracts * fix: check if selected growth_rate is available on symbol change (#58) * fix: able to buy multiply contract / growth rate fix BO change (#59) * fix: able to buy multiply contract / growth rate fix BO change * refactor: last contract check delete Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * revert: maryia/revert change of last_contract computed * fix: accumulator is shown for real account (#60) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * feat: make cursor not allowd for overlay (#61) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * chore: built icons.js * revert: maryia/ unnecessary bot file change * refactor: contract categories in contract-type-widget.jsx * refactor: according to pr review comments * refactor: open positions + add keys to fix console warning * fix: disable accu for real account, disable button having bought one contract (#62) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * refactor: purchase.jsx * refactor: according to pr reviews * refactor: able to buy contract per every available underlying (#63) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Trigger Build * yauheni/85032/ fix chart issue with dots and circles Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * fix: exit spot styles * refactor: make barrier values string as on BE * fix: unable accumulators for real * maryia/refactor_accu_branch (#66) * refactor: remove unused file * refactor: refactor createTickMarkers * refactor: introduce a local variable * fix: 86705/ticks are not displayed correctly on chart in contract details * maryia/86953/build: bump up deriv-charts version to 1.1.0 + improvement (#68) * build: bump up deriv-charts version * chore: show profit only when barriers are received * test: updated mocked props * build: maryia/removed extra package-lock.jsons * evgeniy /87215/87226/ info description / glitch while switching account (#70) * fix: description * fix: disable trade params while switching account --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * henry/87329/fix: FE not showing error message when accu trading is suspended (#72) * fix: FE not showing error message when accu trading is suspended * test: empty commit --------- Co-authored-by: HENRY <henry@regentmarkets.com> * refactor: glitching fix and deleted odd css (#73) * refactor: glitching fix and deleted odd css * fix: code refactor --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Maryia/86616/feat: calculating accu barriers based on ticks from ticks_history (#71) * feat: calculating accu barriers based on ticks from ticks_history * chore: rounded & refactored accu barriers * refactor: added getAccumulatorBarriers for barrier calculation + fixed a test * chore: improved barriers calculations * refactor: getAccumulatorBarriers docs * refactor: getAccumulatorBarriers * fix: showing barriers only when having have ba…
aizad-deriv
pushed a commit
that referenced
this pull request
Jun 13, 2023
* feat: ✨ account transfer component (demo) * fix: transfer hint message * fix: 🎨 apply comments * refactor: 🎨 remove reducer, simplify transfer logic, improve readability (#34) * fix: update padding of app-icon component (#33) * style: improve styles for account list * style: apply comments * fix: apply comments, refactor account modal in desktop * fix: 🎨 apply comments * feat: add scrolling behaviour to account list in mobile view * fix: apply comments, fix test * refactor: 🔥 remove mobile dialog, refactor scrolling, remove redundant logic * fix: apply comments, refactor tests * test: 🚀 add tests for transfer related components * style: fix style for merged icon * fix: mock loginid * fix: typo, demo icon, transition on closing, blinking icons * perf: disable automatic opening of wallet modal --------- Co-authored-by: Hamid <hamid@regentmarkets.com>
aizad-deriv
pushed a commit
that referenced
this pull request
Jun 19, 2023
…ink (deriv-com#8962) * feat: ✨ account transfer component (demo) * fix: transfer hint message * fix: 🎨 apply comments * refactor: 🎨 remove reducer, simplify transfer logic, improve readability (#34) * fix: update padding of app-icon component (#33) * style: improve styles for account list * style: apply comments * fix: apply comments, refactor account modal in desktop * fix: 🎨 apply comments * feat: ✨ synchronize amount inputs, add transfer button * perf: refactor code * refactor: remove listener, add onScroll to mobile_dialog, remove ref from mobile_dialog * fix: apply comments * fix: reset amount_to if selected transfer_from is a wallet * feat: ✨ account transfer component (demo) * fix: transfer hint message * fix: 🎨 apply comments * refactor: 🎨 remove reducer, simplify transfer logic, improve readability (#34) * fix: update padding of app-icon component (#33) * style: improve styles for account list * style: apply comments * fix: apply comments, refactor account modal in desktop * fix: 🎨 apply comments * feat: add scrolling behaviour to account list in mobile view * fix: apply comments, fix test * refactor: 🔥 remove mobile dialog, refactor scrolling, remove redundant logic * fix: name visibility after closing the modal * perf: improve transition behaviour * test: fix tests * refactor: 🔥 remove mobile dialog, refactor scrolling, remove redundant logic * fix: add missing code * refactor: apply comments * fix: apply comments, refactor tests * test: 🚀 add tests for transfer related components * refactor: roll back Tab component * style: fix style for merged icon * fix: mock loginid * fix: mock account loginid * fix: typo, demo icon * fix: typo, demo icon, transition on closing, blinking icons --------- Co-authored-by: Hamid <hamid@regentmarkets.com>
aizad-deriv
added a commit
that referenced
this pull request
Oct 11, 2023
* feat: add 3 static steps for wallet upgrade * fix: responsive * fix: add dynamic steps * fix: address comments * fix: address comments and combine 3 steps to 1 component * test: add test for wallet-steps component * chore: add deriv ui in package * fix: rename togglewalletsupgrade * fix: use Wizard component * fix: move steps to config * fix: use Modal * fix: remove css * chore: add comments * fix: use walletimage * fix: rename config gile * redeploy: Empty-Commit * fix: cfd sub_account_type * fix: hamid commentz * fix: subtasks * fix: eu content * fix: responsive * fix: test import * fix: css responsive * fix: align icon * fix: retrigger * fix: remove trading * feat: wallet styles (deriv-com#8358) * feat: wallet styles * feat: change name * feat: remove duplicate icons * feat: remove duplicate icons * docs: add sample class to wallet mixin * hamid/wallet-icon-and-small (deriv-com#8391) * feat: wallet-icon * fix: wallet-icon and wallet-small * feat: update styles * feat: update styles * feat: update styles * feat: update styles * feat: export wallet * feat: update type * chore: trigger-test * Sergei / wall 147 / in progress and migrated banner (deriv-com#8201) * feat: create a scratch of desktop upgrade banner * feat: create upgrade wallet banner * feat: add review suggestions and rename WalletsBannerImage component * feat: add images and scratch of components * feat: add some suggestions * feat: add some images * feat: almost complete upgrading banner * feat: finished with ready banner * feat: change title for ready banner * refactor: change icon name * feat: add size for tick * feat: add tests * feat: add some changes from PR review * feat: add changes from review * feat: add some constants * refactor: add React.Fragment * refactor: change images name * feat: add suggestions after review * feat: add switch to wallets-banner component * feat: change short dash to long dash * feat: add logout when click ready banner logout button * feat: fix tests * feat: add 1 more test for logout * george / WALL-520 / create badge component (deriv-com#8384) * feat: ✨ add badge component * perf: ⚡ rename label prop to weight prop * perf: ⚡ add Discriminated unions types, fix colors, replace cheildren with label prop * refactor: ⚡ refactor code * perf: ⚡ add export from components package * refactor: ⚡ refactor badge component, add tests * refactor: ⚡ refactor css * fix: 🐛 fix tests * Farzin/wall 548/Add `GradientBackground` component (deriv-com#8436) * feat(components): ✨ add `GradientBackground` * style(components): 💄 add support for mobile * fix(components): 📝 resolve PR comments * feat(components): ✨ add `Watermark` --------- Co-authored-by: Farzin Mirzaie <farzin@deriv.com> * chore: update feature branch with master (deriv-com#8525) * chore: remove unused icons from wallet folder inside components package (deriv-com#8507) * chore: remove unused icons from wallet folder inside components package * chore: build icons * Aum/WALL-562/create-wallet-icon-component (deriv-com#8501) * feat: created wallet-icon component * feat: integrated wallet-icon with gradient-background-wallet-icon * fix: changed the color positioning for icon gradient * chore: replaced currency prop with icon * chore: removed wallet-small and wallet-icon made by @hamid-deriv * chore: removed dark prop for wallet-icon * refactor: made gradient-background-wallet-icon dynamic and refactored wallet-icon * fix: made changes from comments * chore: renamed gradient-background component to two-point * chore: removed unused code * chore: create component for consent wallet popup (deriv-com#8178) * chore: create component for consent wallet popup * fix: added info text based on clients region and risk status * fix: added test case * fix: make changes based on comments and reviews * fix: added mobile stylings * fix: small tweaks * fix: change svg added small changes to the stylings * fix: commit suggestions * fix: commit resolved messages * fix: commit changes based comments and did code improvements * fix: made changes to information list file * fix: added title border and checkbox function fix * fix: added bold text for low risk cr accounts in modal * fix: replace text for p2p * fix: modal not displaying properly on small screens * fix: issue with small screen final * Sergei / wall 272 / wallet desktop header (deriv-com#8334) * feat: create scratch of the header * feat: add WalletsImage component * feat: add limiting types * feat: trying to add size changing for SVG (not completed) * feat: add some icons * feat: optimise svgs * feat: add buttons * feat: collapsed wallet header * feat: commit to check in test link * feat: add wallet bg with css * feat: add check for dark mode * feat: change color for svg for light/dark themes * feat: add hover on buttons * feat: add some check for demo wallet * feat: delete uploaded icons because these icons already exists * feat: delete currency icons because its already exist * feat: add some svgs * feat: add demo color and mixin * feat: create wallet-currency-card component * feat: divide component to some small components * feat: add status badge * feat: repair background image for appstore * feat: add bg svg * feat: move background image * feat: add disabled buttons * feat: delete unnecessary prop * feat: delete comments * feat: delete some comments * feat: add some test cases * fix: fix one test * feat: change some types and add util function * refactor: delete comment * refactor: delete comment * feat: delete unnecessary icons * feat: add some suggestions * refactor: delete comments * feat: add check for fiat * feat: delete default values for component props * feat: complete tests * refactor: change var name * feat: add 3 more tests * feat: add actions and button types * fix: fix scss var color * feat: move wallet buttons creation function to utils * refactor: delete curly braces * refactor: change import order * refactor: delete line which breaks eslint test * feat: use Badge component * feat: add suggestions * feat: change types and shortcode for some wallets * feat: make account_type prop as optional * feat: empty just to start deployment * feat: change bg color to gray * feat: change getWalletCurrencyIcon and add some icons * feat: empty to restart vercel * feat: update getWalletCurrencyIcon function * feat: format balance money * fix: repair test * fix: move wallet-balance to the right side of the screen * refactor: change opacity * feat: Rostislav / WALL-361 / Cashier Fiat Transfer amount input field (deriv-com#8442) --------- Co-authored-by: George Usynin <103181646+heorhi-deriv@users.noreply.github.com> Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> * chore: stitch banner with popup (deriv-com#8476) * chore: create component for consent wallet popup * fix: added info text based on clients region and risk status * fix: added test case * fix: make changes based on comments and reviews * fix: added mobile stylings * fix: small tweaks * fix: change svg added small changes to the stylings * fix: commit suggestions * fix: commit resolved messages * fix: commit changes based comments and did code improvements * fix: made changes to information list file * fix: added title border and checkbox function fix * fix: added bold text for low risk cr accounts in modal * fix: replace text for p2p * fix: modal not displaying properly on small screens * fix: issue with small screen final * chore: stitch banner with popup * fix: refactor some code * fix: refactor code * fix: test cases * chore: stitching 80% done * fix: fixing all the test cases * fix: commit suggestions * fix: fix test cases and other stuff * fix: remove unused stuff * fix: edit stylings making mobile view look better * fix: added form line height to wallet intro component * fix: refactor somemore * fix: commit suggestions * empty commit * empty commit * retrigger commit * chore: retrigger commit * fix: commit suggestions * fix: circleci error * fix: wallet banner test case * fix: tests * fix: issue with the disabled buttons and checkbox * fix: updated real-wallets-upgrade * fix: circleci error * fix: remove button outline from banner * fix: merge conflicts * fix: resolve circle ci issues * fix: added changes to show the banner * fix: circle ci issues * fix: remove additional button props --------- Co-authored-by: Thisyahlen Nair <thisyahlen@regentmarkets.com> * Aum/wall 278/create wallet card component (deriv-com#8580) * feat: created wallet-card and integrated wallet-icon for small size * refactor: changed height of gradient-background * feat: added states for wallet-card small * feat: added card shine effect to wallet-card for medium and large * feat: wallet-card states completed * fix: rendering values in correct places * refactor: added single prop for handling wallet-card states * fix: applied correct padding and font-size for mobile * feat: included 'added' state for wallet-card * chore: added constants config for wallet-card * chore: applied changes from comments * fix: wallet-card state becomes default for add/added states * refactor: hamid-aum-forked-wallet-card * refactor: enhance-wallet-card * feat: enhance-wallet-card * docs: add comment * revert: revert trader-hub home page * refactor: refactor wallet-icon * fix: resolve comments * fix: fixed some styling * refactor: removed parent hack from scss and fixed all the states * chore: removed mock response file --------- Co-authored-by: Hamid Yaftian <hamid@deriv.com> Co-authored-by: Hamid <hamid@regentmarkets.com> * fix: issues during conflict resolution * fix: fix serve error (deriv-com#8749) * fix: fix serve error * fix: fix serve error * feat: add app-icon and update wallet-icon (deriv-com#8730) * feat: add app-icon and update wallet-icon * chore: clean code * fix: fix eslint error * chore: update pr * feat: update component name * feat: update component name * fix: update component name * chore: retrigger the test * Update packages/appstore/src/assets/svgs/currency/index.tsx * Update packages/reports/src/Containers/statement.tsx --------- Co-authored-by: Nijil Nirmal <62882794+nijil-deriv@users.noreply.github.com> * hamid/wall-432/transfer-account-selector-refactor (deriv-com#8758) * refactor: refactor transfer-account-selector with new components * feat: add is_value prop * fix: enhance app-icon style * fix: enhance app-icon style * fix: enhance modal prop * fix: apply pr commits * feat: use badge component * fix: apply pr commits * feat: add portal_id prop * george / WALL-306 / add wallet cashier modal new (deriv-com#8750) * feat: ✨ add wallet cashier modal * fix: align files with feature branch * Aum/wall 5/the upgrade modal which wallets will be created and linked (deriv-com#8751) * feat: created wallets linking step for wallet upgrade * feat: create responsive wallet-link component * feat: renamed wallet-link to wallet-link-wrapper and completed static UI * feat: created wrapper for the 2nd step in wallet-upgrade * feat: added dependency for hooks to appstore and added useBalance and useWalletMigration hooks * chore: minor UI fixes * fix: fixed scrolling of accounts in mobile view * feat: appended the 2nd step to 1st step * feat: rendering all data for each step during linking * chore: added some mock data * refactor: replaced placeholder card with wallet-card component * fix: removed z-index and fixed shine (trapezoid) element * chore: add types for wallet-card * feat: added types to all the tsx files * fix: fixed some type errors * fix: fixed the active border issue in wallet-card * chore: changed the state of wallet-card in wallet-linking to default * fix: fixed wallet title in mobile mode * fix: changed color for text and fixed clipping of linking step content * fix: fixed scrolling when only one wallet with few accounts is shown * chore: made changes from review suggestions * chore: removing unused classnames * chore: changed order of imports for wallet-link-wrapper * chore: changed height for wallet-linking-step * chore: resolved comments * chore: add USDC crypto mock data * chore: added rebranded icons to components package * fix: fixed the link line units using px * chore: added margin top and bottom to link-wrapper * fix: changed linking step height * fix: fixed the bracket for safari browser * Sergei/wall 273/ (NEW) Complete wallets (deriv-com#8786) * feat: add some changes * feat: add useContentFlag hook * feat: add all files * feat: implement updated WalletIcon component * feat: add deleted test * feat: create success toast message for wallets (deriv-com#8763) * Sergei / wall-578 / (Updated) Pop up for wallet migration failed (deriv-com#8765) * feat: create PR from latest feature branch * feat: delete hooks from appstore (not related to this PR) * feat: add hooks to appstore * hamid/wall-934/fix-type-error (deriv-com#8903) * fix: type errors of balance in wallet * chore: change currency-switcher-account * chore: change _ to - in testid * chore: retrigger the test --------- Co-authored-by: Sergei Baranovski <sergei@deriv.com> * thisyahlen/fix: sorting of wallets list (deriv-com#8926) * fix: sorting and refactor * fix: logout issue * fix: open only 1 wallet at a time * chore: add test for useWalletlist * fix: to fix type for shortcode * fix: test type * fix: comments and suggestions * fix: comments * fix: test * fix: show wallets to only high risk clients * redeploy: codecov * george / WALL-431 / Demo: Input & selector stitching (deriv-com#8794) * feat: ✨ account transfer component (demo) * fix: transfer hint message * fix: 🎨 apply comments * refactor: 🎨 remove reducer, simplify transfer logic, improve readability (#34) * fix: update padding of app-icon component (#33) * style: improve styles for account list * style: apply comments * fix: apply comments, refactor account modal in desktop * fix: 🎨 apply comments * feat: add scrolling behaviour to account list in mobile view * fix: apply comments, fix test * refactor: 🔥 remove mobile dialog, refactor scrolling, remove redundant logic * fix: apply comments, refactor tests * test: 🚀 add tests for transfer related components * style: fix style for merged icon * fix: mock loginid * fix: typo, demo icon, transition on closing, blinking icons * perf: disable automatic opening of wallet modal --------- Co-authored-by: Hamid <hamid@regentmarkets.com> * Rostislav / WALL-454 / Fiat transaction list (post feature branch update) (deriv-com#8753) * refactor: add DeepRequired for use * refactor: prototypes * refactor: better prototypes * refactor: almost done w/o responsive and themes * refactor: tmp number formatting (better use hooks) + minor changes * refactor: added a degree of responsiveness * refactor: line heights and font sizes * refactor: code improvement * refactor: remove duplication in testing component * refactor: adding FiatTransactionList with hardcoded list for now * refactor: deriv/components deps * refactor: added hook for grouped transactions * refactor: add lodash.groupby and moment to hooks deps * refactor: useGroupedFiatTransactions * refactor: visuals pretty much done w the grouping logic * refactor: add spec for hook * refactor: move FiatTransactionList to modal * refactor: filling the gaps for transactions * refactor: API call for transactions added * refactor: add logic for transfer transactions * refactor: minor change * refactor: switched to using WalletIcon * refactor: added is-crypto check for transfer transaction (other) account currency * refactor: transaction list style change fix for later * refactor: transactions_ -> mock_transactions * refactor: types and logic * refactor: better transactions.map(...) * refactor: improved code * refactor: post-feat-branch-merge fixes * refactor: remove unnecessary change * refactor: hardcode app transactions * refactor: remove seemingly redundant useCallbacks * refactor: TODO * refactor: fiat-transaction-list-item.tsx suggestions * refactor: some of the styles suggestions applied * refactor: scss variable * Update packages/appstore/src/components/fiat-transaction-list/fiat-transaction-list.tsx Co-authored-by: Hamid <hamid@regentmarkets.com> * Update packages/appstore/src/components/fiat-transaction-list/fiat-transaction-list.tsx Co-authored-by: Hamid <hamid@regentmarkets.com> * refactor: not styling direct html tags now * refactor: move style import from index.ts to fiat-transaction-list.tsx * refactor: app acc mock name change * refactor: isMobile() -> is_mobile * refactor: separated fetching and grouping * Merge remote-tracking branch 'upstream/feature/wallets_with_traders_hub' into rostislav/WALL-641/transaction-list-item-new * refactor: account balance type fix * fix: tests fix * refactor: switched back to using mock transaction list * refactor: update mock data * refactor: fixes related to appearance * refactor: minor fix * refactor: minor changes * refactor: icons * refactor: changed wallet-icon.tsx + other small changes * refactor: a fix for malta wallets * refactor: a few more appearance changes * refactor: qa appearance fixes * refactor: deriv apps fix * refactor: real page fix * refactor: one more transaction * refactor: + initial deposit for real * refactor: a few more changes to styles * refactor: a few more changes to styles * refactor: z-index shenanigans * refactor: app icon dark theme * refactor: package.json * refactor: (tmp) remove failing test * refactor: return failing test * fix: tests * refactor: svg optimized * refactor: svg fixes --------- Co-authored-by: Hamid <hamid@regentmarkets.com> * synchronize amount inputs, add transfer button (WALL-554) with test link (deriv-com#8962) * feat: ✨ account transfer component (demo) * fix: transfer hint message * fix: 🎨 apply comments * refactor: 🎨 remove reducer, simplify transfer logic, improve readability (#34) * fix: update padding of app-icon component (#33) * style: improve styles for account list * style: apply comments * fix: apply comments, refactor account modal in desktop * fix: 🎨 apply comments * feat: ✨ synchronize amount inputs, add transfer button * perf: refactor code * refactor: remove listener, add onScroll to mobile_dialog, remove ref from mobile_dialog * fix: apply comments * fix: reset amount_to if selected transfer_from is a wallet * feat: ✨ account transfer component (demo) * fix: transfer hint message * fix: 🎨 apply comments * refactor: 🎨 remove reducer, simplify transfer logic, improve readability (#34) * fix: update padding of app-icon component (#33) * style: improve styles for account list * style: apply comments * fix: apply comments, refactor account modal in desktop * fix: 🎨 apply comments * feat: add scrolling behaviour to account list in mobile view * fix: apply comments, fix test * refactor: 🔥 remove mobile dialog, refactor scrolling, remove redundant logic * fix: name visibility after closing the modal * perf: improve transition behaviour * test: fix tests * refactor: 🔥 remove mobile dialog, refactor scrolling, remove redundant logic * fix: add missing code * refactor: apply comments * fix: apply comments, refactor tests * test: 🚀 add tests for transfer related components * refactor: roll back Tab component * style: fix style for merged icon * fix: mock loginid * fix: mock account loginid * fix: typo, demo icon * fix: typo, demo icon, transition on closing, blinking icons --------- Co-authored-by: Hamid <hamid@regentmarkets.com> * feat: added wallets notifications to wallets (deriv-com#8837) * feat: added wallets notifications to wallets * fix: remove commentted code * fix: show notifications for platforms only * fix: change label on CTA * fix: added hooks package * fix: update branch * chore: remove unused code * Hamid/wallet card colors mixin (deriv-com#9008) * feat: update wallet cards color mixin * feat: update wallet colors mixin and wallet modal header * feat: change wallet color in wallet card and icon * chore: retrigger ci tests * feat: update components based on the new gradient color prop * fix: revert index.tsx * fix: update test cases * fix: update test cases * fix: fix pr comments * fix: fix transfer icon bg * feat: replace gradient_for with gradient_*_class props * fix: failed build * fix: fix pr comments * hamid/wall-582/demo-reset-balance-tab (deriv-com#8899) * feat: add demo reset tab component * feat: add redirect to transfer tab setter * fix: add redirect to transfer tab setter * test: add test to demo-reset-balance component * test: add test to demo-reset-balance component * fix: apply pr commits * fix: apply pr commits * feat: apply pr commits * fix: add missing package * fix: use balance store for getting demo wallet balance * chore: retrigger ci tests * chore: retrigger ci tests * fix: change text after transfer success * fix: apply pr commits * fix: apply pr commits * fix: change icon of the success step * feat: update design based on the new changes * Thisyahlen/WALL-1020/ List of wallets according to authorize and balance (deriv-com#9010) * chore: add balance from response, switching and refactor * fix: test and verification only for eu users * fix: tests * fix: modal first, then switch account * fix: refactor logic to hooks * fix: refactor to use wallet_account instead of data * redeploy: vercel * fix: refactor test * fix: tests and address comments * fix: use debounce instead of settimeout * fix: refactor tests and hooks * fix: use landing_company_name instead of shortcode * fix: test title * fix: scroll to active wallet upon click * fix: resolve test and comments * fix: test * fix: tests again * feat: implement withdraw verification reques (deriv-com#9125) * feat: implement withdraw verification reques * feat: update component name * feat: update typo * feat: change icons with new icons design provided * chore: retrigger ci tests * chore: retrigger ci tests --------- Co-authored-by: mahdiyeh-deriv <82078941+mahdiyeh-deriv@users.noreply.github.com> * yashim/feat: add mock server integration phase1 (deriv-com#9003) * feat: add mock server integration * refactor: use session instead of client * fix: persistent mock server enable state * chore: draft * feat: add mock server control panel UI * feat: add clear all functionality * feat: completed login mock * fix: tests * fix: code * feat: add feature toggle * feat: end of day commit * fix: review comments + tests * chore: used deriv-api * fix: typescript error * chore: update package lock --------- Co-authored-by: Dev Sans <yashimwong@gmail.com> * Rostislav / Wall-455 / Transaction list filter (Demo&Real) (deriv-com#9007) * refactor: init pr * feat: adding filter dropdown component * feat: restructuring FiatTransactionList -> TransactionList + added the filter * refactor: localize * refactor: appearance fixes * refactor: further appearance fixes * refactor: grouping transactions now in utils * refactor: minor change * refactor: new hook * refactor: useWalletsList.ts changes by @sergei-deriv * refactor: continuation of the prev commit * refactor: typescript shenanigans * refactor: use wallet list * refactor: moving stuff to hooks * refactor: removed unused stuff for transaction-list.tsx * refactor: improving logic * refactor: test file * refactor: no more circular deps * refactor: improved hook * refactor: test * test: add tests (#10) * test: fix tests * fix: apply comments * fix: apply comments, refactor code * test: fix test * test: reactor code * trigger build * trigger build * refactor: fixing appearance * update feature_branch with master (deriv-com#9220) * fix: close account message doesn't show up (deriv-com#9210) Co-authored-by: niloofar sadeghi <niloofar.sadeghi@re-work.dev> * Jim/WEBREL-667/fix-bug-revealed-during-ts-migration (deriv-com#9216) * revert: revert code changes * fix: fix bug revealed during ts migration * chore: add test cases for line changed --------- Co-authored-by: Niloofar Sadeghi <93518187+niloofar-deriv@users.noreply.github.com> Co-authored-by: niloofar sadeghi <niloofar.sadeghi@re-work.dev> Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> * refactor: mock data change * refactor: finish resolving * refactor: remove package-lock.json changes * refactor: fix tests * refactor: resolve some ts problems * refactor: resolve some ts problems * refactor: one more small fix with the help of @heorhi-deriv * refactor: remove unused @ts-expect-error * refactor: remove fiat-transaction-list.tsx --------- Co-authored-by: George Usynin <103181646+heorhi-deriv@users.noreply.github.com> Co-authored-by: george-usynin-binary <heorhi@binary.com> Co-authored-by: mahdiyeh-deriv <82078941+mahdiyeh-deriv@users.noreply.github.com> Co-authored-by: Niloofar Sadeghi <93518187+niloofar-deriv@users.noreply.github.com> Co-authored-by: niloofar sadeghi <niloofar.sadeghi@re-work.dev> Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> * Sergei / wall 680 / Desktop wallet dark theme (deriv-com#9006) * style: change text color and add bg color for demo wallet in dark mode * feat: add logo for dark theme * feat: add @deriv/hooks to package.json in appstore * chore: empty commit to restart vercel * refactor: wrap TradersHub component by observer * chore: empty commit to restart vercel * feat: change color of button border * update feature_branch with master (deriv-com#9220) * fix: close account message doesn't show up (deriv-com#9210) Co-authored-by: niloofar sadeghi <niloofar.sadeghi@re-work.dev> * Jim/WEBREL-667/fix-bug-revealed-during-ts-migration (deriv-com#9216) * revert: revert code changes * fix: fix bug revealed during ts migration * chore: add test cases for line changed --------- Co-authored-by: Niloofar Sadeghi <93518187+niloofar-deriv@users.noreply.github.com> Co-authored-by: niloofar sadeghi <niloofar.sadeghi@re-work.dev> Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> * feat: fix test for useWalletsList * fix: try to fix useWalletsList test * feat: add type to default_mock_useFetch_response * feat: just add @ts-expect-error * chore: change number to boolean --------- Co-authored-by: mahdiyeh-deriv <82078941+mahdiyeh-deriv@users.noreply.github.com> Co-authored-by: Niloofar Sadeghi <93518187+niloofar-deriv@users.noreply.github.com> Co-authored-by: niloofar sadeghi <niloofar.sadeghi@re-work.dev> Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> * george / wall-14 / fiat deposit (deriv-com#9060) * feat: add fiat deposit iframe * test: fix test * Quick fix for `useWalletList` hook (deriv-com#9256) * fix: useWalletsList.ts * refactor: changes requested by @heorhi-deriv * refactor: changes requested by @sergei-deriv * refactor: remove unnecessary falsy check * feat: added add-wallets section (deriv-com#9018) * feat: added add-wallets section * chore: added carousel and hooks * chore: 90% finish implementation * fix: commit suggestions * feat: done but without test cases * fix: added test cases but wil improve on it * chore: small changes but big impact 😎 * fix: added loading screen to the component * fix: commit suggestions * fix: resolve somemore comments * fix: small changes * fix: circleci * fix: this is the last one i swear * fix: resolved comments * fix: commit suggestions * fix: commit suggestions * fix: oh man oh man oh man * fix: rename UST to USDT * fix: update test cases to reflect on the changes * fix: usd description * fix: commit suggestions * fix: added cursor pointer to wallet cards * fix: small changes * fix: i know its failing thats why im pushing this commit to fix it * fix: i know its failing thats why im pushing this commit to fix it * fix: test cases and vercel * fix: retrigger vercel * fix: make changes for the icon and the position of the arrow btn * fix: test cases * fix: commit suggestions * fix: remove unnecessary files from commit * fix: firefox issues and wallet card btn * fix: commit suggestions * fix: commit suggestions pt.2 * chore: fix test * fix: circle ci issue * fix: circle ci errors * fix: circle ci pt.2 * fix: circle ci pt.3 * fix: removed duplicate entries * chore: update package-lock using npm run bootstrap:dev * Farzin/Putting wallet behind feature flag [WIP] (deriv-com#9236) * refactor(appstore): 🔥 clean-up * refactor(appstore): 🔥 clean-up * refactor(appstore): 🔥 clean-up * refactor(appstore): 🔥 clean-up * refactor(appstore): 🔥 clean-up * refactor(appstore): 🔥 clean-up * refactor(appstore): 🔥 clean-up * refactor(appstore): 🔥 clean-up * refactor(appstore): 🔥 clean-up * refactor(appstore): 🔥 clean-up * refactor(appstore): 🔥 clean-up * refactor(appstore): 🔥 clean-up * refactor(appstore): 🔥 clean-up --------- Co-authored-by: Farzin Mirzaie <farzin@deriv.com> * Sergei / wall-348 / Responsive Wallets: The complete flow (deriv-com#9015) * feat: add wallet cards to carousel * feat: add check for is_mobile * feat: add transition for pagination * feat: add recalculate feature for carousel when the user changes screen size * feat: finish with UI part * feat: create common type for desktop and responsive wallets * feat: add sorting function * refactor: delete wallet word from wallet name * feat: add react-slick library * feat: intermediate result of carousel * feat: intermediate result * feat: delete TWalletType * feat: add useWalletAccount test stub * feat: move styles to AccountWithWallets * refactor: delete comments * feat: delete comments again * feat: add generic type to useRef * refactor: move TWalletAccount to common.types.ts * feat: delete React.memo, doesn't need now * chore: empty commit to restart vercel * feat: change balance type from string to number and repair tests * chore: restore tests * feat: add swipe to slide and make container wider * feat: create separate button component and refactor WalletHeader * chore: empty commit to restart vercel * refactor: delete styles for dots * feat: add tests for wallet-cards-carousel * feat: change wallet-transfer-block tests * feat: add tests for wallet-button component * feat: delete comments from style * feat: delete slick-theme.scss file * feat: move slick.scss file to traders-hub folder * refactor: delete commented lines * feat: make wallet_account optional * refactor: rename hook * feat: add wallets accounts to list of valid logins * feat: allow only one open desktop wallet * feat: repair test * feat: implement some suggestions * feat: rename the hook * refactor: rename useWalletAccounts test file * feat: intermediate result. Have to think about useCallback * feat: move convertWallets to utils * refactor: implemet some suggestions * feat: add TODO * feat: fix wallet-card component to show proper demo badge * chore: empty commit to restart vercel * feat: change library * feat: repair test * refactor: delete comment * feat: change color to prominent for Text components * feat: change jurisdiction to UpperCase * feat: delete test select and add hooks to package.json * feat: add fake accounts because qa29 is unavailable * chore: empty commit to restart vercel * fix: fix console error * feat: imtermediate result * feat: change tabs order * feat: add plus icon for CFDs * feat: add select as for desktop * feat: add compare accounts for fiat and crypto * feat: add comment * feat: add right colors for responsive mode * feat: repair test * style: add some colors * feat: add active_wallet_loginid to client-store * style: add styles for CFD tab * feat: delete filter available_platforms for WalletOptionsAndMultipliersListing * feat: repair test * chore: empty commit to restart vercel * feat: add placeholder * feat: add one todo * chore: empty commit to restart vercel * feat: add is_switching and is_landing_company_loaded flags for placeholder * feat: delete check for is_landing_company_loaded * feat: implement suggestions * feat: add some properties to iseWalletList result * feat: refactor useWalletsList * feat: check for demo icon in useWalletList * feat: refactor progress-bar-onboarding * feat: add carousel and refactor all wallets * feat: comment currency_display_code * feat: change useWalletList hook again * feat: repair wallet-cards-carousel tests * feat: repair tests for wallet-header * feat: add tests for badge in wallet-header * feat: delete unuses type * style: create var for wallets box-shadow * feat: add useActiveWallet hook * feat: refactor code * refactor: some refactor of code * feat: delete using of useActiveWallet from 2 components * feat: add useActiveWallet for CFDsListing and OptionsAndMultipliersListing * feat: repair wallet-content test * feat: repair wallet-header test * feat: rewrite one test case for wallets component * refactor: delete unused import * style: add prominent color for Options & multipliers * chore: empty commit to restart vercel * feat: fix buttons issue * feat: fix logout issue for responsive * chore: delete comments * feat: return original onArrowClickHandler * feat: add needed properties in useWalletTransactions * feat: change currency to wallet_currency * feat: add wallet_currency to useWalletsList * fix: comment AddMoreWallets because it breaks PR when switch to Demo wallet * fix: add check for currencies in useAvailableWallets * feat: add ability to wallet buttons to open modal in responsive mode * refactor: change names for WalletContent props * feat: add open wallet modal for transfer button in CFD section of crypto wallet * feat: add select needed wallet card after redirect from cashier * Kill changes in package-lock * feat: add ts-expect-error to fix CircleCI error * fix: fix CircleCI test * feat: add open wallet modal for OptionsAndMultipliers components * fix: fix wallet-transfer-block test after modification * chore: comment scroll to choosed card * feat: delete autoselect wallet in responsive mode because cashier will be deleted * feat: fix some issues * feat: fix carousel issue * fix: fix tests for CircleCI * feat: delete is_added from useWalletsList * Farzin/Putting wallet behind feature flag [WIP] (deriv-com#9362) * refactor(appstore): 🔥 clean-up * refactor(appstore): 🔥 clean-up * refactor(appstore): 🔥 clean-up * refactor(appstore): 🔥 clean-up * refactor(appstore): 🔥 clean-up * refactor(appstore): 🔥 clean-up * refactor(appstore): 🔥 clean-up * refactor(appstore): 🔥 clean-up * refactor(appstore): 🔥 clean-up * refactor(appstore): 🔥 clean-up * refactor(appstore): 🔥 clean-up * refactor(appstore): 🔥 clean-up * refactor(appstore): 🔥 clean-up * refactor(appstore): 🔥 clean-up * refactor(appstore): 🔥 clean-up * refactor(appstore): 🔥 clean-up --------- Co-authored-by: Farzin Mirzaie <farzin@deriv.com> * fix: import issue in style (deriv-com#9436) * thisyahlen/fix: wallet migration using mock server (deriv-com#9161) * fix: mock config push * chore: mock server works boii * fix: comments and refactor * fix: remove unused import * fix: change refetch interval to 500ms * fix: refactor * fix: refactor v2 * fix: change back to migrated * fix: change to state * fix: test * fix: resolve comments * fix: removed async keyword (deriv-com#9504) * fix: updated deriv/api-types in p2p (deriv-com#9535) * fix: updated deriv/api-types in p2p * fix: added types for notification * fix: test cases * fix: circle ci issues pt.2 * bugfix: logout issue (deriv-com#9466) * bugfix: logout issue * chore: fix code smell * refactor: move token check into the if scope * fix: ternary option for token * chore: reload build --------- Co-authored-by: Mahdiyeh Amirkhani <mahdiyehamirkhani@Mahdiyeh-Amirkhanis-Mac-J79XQHKXVJ.local> * george / wall-1177 / Demo transfer insufficient funds error (deriv-com#9211) * feat: add demo transfer error handlers, add useTransferBetweenAccounts hook * fix: types errors * fix: commit * feat: add transfer hooks * test: add tests * fix: commit * feat: 🎨 refactor code, add useActiveCFDAccounts hook * chore: remove comment * refactor: 🔥 cleanup * fix: useAvaliableWallets hook * fix: typescript errors * test: add tests, apply comments * test: add test, add test accounts * test: fix tests * fix: fix ts errors * fix: apply comments * perf: small improvement * perf: small improvement * fix: resolve conflicts * refactor: improve logic, fix test * chore: remove unused import * feat: add reset balance button handler * fix: currency register * style: fix styles in dark mode * test: fix test * perf: minor improvements * refactor: ⚡ transfer account data transfarmation layer * fix: minor fix * test: fix tests * fix: input error color * refactor: split accounts: trading_accounts and wallets * test: fix test * refactor: improve naming * fix: minor fix * feat: add useExistingCFDAccounts hook * test: fix tests * perf: replace useRequest with usefetch in useExistingCFDAccounts hook * test: fix test * style: fix selected tile style * refactor: apply comments * Aum/FEQ-503/proper-wallet-listing-logic-with-feature-flag (deriv-com#9550) * feat: binding feature flag with API response to show or hide the wallets * fix: fixed wallet-card shine issue * fix: removed extra check for wallets list length in useHasWallet * refactor: moved logic for useHasWallet to useWalletsList * Aum/wall 1332/implementing the colors updating the components (deriv-com#9492) * feat: added wallet-card colors for wallet-migration modal * fix: fixing the colors for the bitcoin gradient * implement migration banner visibility logic (deriv-com#9552) * refactor: implement migration banner visibility logic * test: fix tests * refactor: move has_wallet check to useWalletsList hook * test: remove unused test * test: fix test type * refactor: remove button for test purposes * fix: missing icon * fix: type, sonarcloud issue (deriv-com#9642) * fix: blinking wallet banner, double scroll (deriv-com#9653) * fix: blinking wallet banner, double scroll * fix: blinking wallet banner with no wallets account * refactor: remove has_wallet, add is_migrated check * refactor: improve conditions * feat: add containScroll and clearTimeout (deriv-com#9662) * fix: remove duplicated types * Merge branch 'master' into feature/wallets_with_traders_hub * Aizad-sergei/Fix: :feature/wallets with traders hub (deriv-com#9755) * chore: initial commit * fix: fixed tests * chore: init commit * refactor: move WalletsImage component to separate file * refactor: move wallet_migration type, add TSDoc for it, change ?? to && for authorize checking * refactor: implement suggestions for packages/appstore/src/components/containers * refactor: add button styles to title * refactor: changed EUDisclaimer component * refactor: implement suggestions for packages/appstore/src/components/modals * refactor: reverted changes back * refactor: delete useCallback * refactor: wallet-add-card.spec.tsx * refactor: addmorewallets.tsx,addmorewallets.scss,addmorewallets.spec.tsx,walletaddcard.tsx * refactor: implement suggestions for packages/appstore/src/components * refactor: some more implemented suggestions * feat: optimize svgs for wallets * refactor: minified rest of svgs * refactor: add some more suggestions * refactor: complete with suggestions * feat: add check for stringified object * refactor: real-wallets-upgrade folder * chore: resolve comments from the big man himself: yashim * refactor: implement Maryia suggestions and use svgo for all icons * refactor: use svgo just for icons related to wallets * refactor: rename all variables to snake_case * refactor: optimize listing-container component --------- Co-authored-by: Mahdiyeh Amirkhani <mahdiyehamirkhani@Mahdiyeh-Amirkhanis-Mac-J79XQHKXVJ.local> Co-authored-by: aizad-deriv <aizad@deriv.com> Co-authored-by: Sergei Baranovski <sergei@deriv.com> Co-authored-by: Aizad Ridzo <103104395+aizad-deriv@users.noreply.github.com> * fix: fix test * chore: update embla-carousel-react version to 8.0.0-rc12 in appstore package * fix: unused '@ts-expect-error' directive * chore: resolve comments * fix: conflicts * chore: initial commit (deriv-com#9853) * chore: initial commit * refactor: refactor sonar cloud code smells * refactor: ♻️ remove unused and replace deprecated properties * refactor: extracted out function * refactor: change isMobile to is_mobile from store * refactor: revert useCurrencyConfig usage from api * fix: add imports for routes --------- Co-authored-by: Mahdiyeh Amirkhani <mahdiyehamirkhani@Mahdiyeh-Amirkhanis-Mac-J79XQHKXVJ.local> Co-authored-by: arshad-rao-deriv <muhammad.arshad@deriv.com> * fix: remove wrong import * feat: modify progressBarTracker and renamed this component in CardsSliderSwiper (deriv-com#9954) * Fix Review Comments Wallets Feature branch (deriv-com#9998) * refactor: ♻️ extracted logic to a function in useWalletTransactions * refactor: remove code smells * refactor: ♻️ updated wrapper function name used in test * Fix feature/wallets with traders hub (deriv-com#10041) * refactor: ♻️ extracted logic to a function in useWalletTransactions * refactor: remove code smells * refactor: ♻️ updated wrapper function name used in test * refactor: refactoed code, replaced localize with Localize component * refactor: formatted code * refactor: refactored code, used early return * george / resolve comments for FB1 (feature/wallets_with_traders_hub) (deriv-com#10040) * fix: ♻️ resolve comments * refactor: ♻️ improve modal to show close cross button only * refactor: ♻️ refactor wallet upgrade props * fix: 🐛 fix app loading issue related to can_get_more_cfd_mt5_accounts usage (replace with hook) * fix: modal component (deriv-com#10148) * Rostislav / Wallets feature branch refactors (deriv-com#10178) * refactor * refactor * refactor: code refactoring PR comments (deriv-com#10180) * Arshad/feature/wallets with traders hub fixes (deriv-com#10226) * refactor: code refactoring PR comments * refactor: refactored code review comments * fix: revert icon and content that got overwritten while merge in withdrawal-verification-email.tsx * feat: add conditions to show wallet migration notifications (deriv-com#10280) * fix: top up modal height issue (deriv-com#10279) * lubega/feq 750/fix: withdraw page spacing issue (deriv-com#10302) * fix: 🐛 Account selector alignment fix * fix: 🐛 Withdraw page spacing issue * fix: 🐛 Withdraw page spacing issue * fix: 🐛 Withdraw page spacing issue * nijil/aum/FEQ-739/fix alignment issues for feature branch 1 (deriv-com#10252) * fix: fixed height of pa deposit payment methods dropdown * fix: fixing tabs component for alignment issues * fix: password meter and hint alignment (deriv-com#10285) * fix: fix test for min-max-stake (deriv-com#10316) * fix: bump version of @deriv/deriv-api to 1.0.13 in reports package * Sergei / FEQ 741 / add prevent logout logic as for fb2 (deriv-com#10282) * feat: add logic as for fb2 * fix: fix test for useWalletMigration * fix: reset MT5AccountTypeModal file to the one in master * fix: reset MT5AccountTypeModal file to the one in master * fix: add import for useState hook * Remove unnecessary modal min height param (deriv-com#10355) * fix: Remove unnecessary modal min height param * fix: removed unnecessary prop * aum/WALL-1983/fix-description-font-size-in-empty-state (deriv-com#10334) * fix: fixed font-size for empty-states description * refactor: changed the font-sizes * george / WALL-1985 / fix style issues (PA withdarwal, fiat withdrawals) (deriv-com#10350) * style: 💄 fix style issues * test: 🧪 add test for balance-text * chore: ♻️ fix naming convention for data testid * Merge branch 'feature/wallets_with_traders_hub' of https://github.com/binary-com/deriv-app into pa-aligment * refactor: ♻️ align with master * test: 🧪 refactor test * style: 💄 add spacing * Aizad/WALL-1987/Seeing loading issue during DIEL account creation (deriv-com#10391) * fix: remove console errors on onboarding page * fix: allow onboarding for diel * fix: resolve comments * Rostislav / WALL-1986 / Alignment issues in Transfer limit message (deriv-com#10376) * fix: align * fix: appearance, but different * fix: appearance, but yet again different * refactor: a bunch more blank lines in css for readibility * Sergei / wall 1998 / inputs alignment (deriv-com#10431) * style: change margin * style: add style for mobile * style: change bottom property to top * feat: add is_authorize check (deriv-com#10466) * Rostislav / WALL-1986 (2) / Alignment issues in Transfer limit message (deriv-com#10462) * fix: appearance align with production * refactor: better css * refactor: better css * Nijil/Comment out usage of useWalletList and useWalletMigration (deriv-com#10480) * chore: comment code using useWalletList and useWalletMigration to reduce number of authorize calls * chore: add is_wallet_enabled check from useFeatureFlags hook for WalletModal in ModalManager * chore: consistent TODO comments across all commented out code * chore: Update package-lock * fix: failing test cases Co-authored-by: Sergei Baranovski <sergei-deriv@users.noreply.github.com> --------- Co-authored-by: Sergei Baranovski <sergei-deriv@users.noreply.github.com> * Rostislav / WALL-2011 / Fiat<->Fiat transfer percentage selector removed (deriv-com#10511) * fix: mt5<->fiat no more percentage selector * fix: logic * Revert "Rostislav / WALL-2011 / Fiat<->Fiat transfer percentage selector removed (deriv-com#10511)" (deriv-com#10527) This reverts commit d61b94a. * george / WALL-2020 / transfer modal height (deriv-com#10532) * style: 💄 fix buttons group margin * style: 💄 align style with staging --------- Co-authored-by: Thisyahlen Nair <thisyahlen@regentmarkets.com> Co-authored-by: Hamid <hamid@regentmarkets.com> Co-authored-by: Sergei Baranovski <120570511+sergei-deriv@users.noreply.github.com> Co-authored-by: George Usynin <103181646+heorhi-deriv@users.noreply.github.com> Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> Co-authored-by: Farzin Mirzaie <farzin@deriv.com> Co-authored-by: mahdiyeh-deriv <82078941+mahdiyeh-deriv@users.noreply.github.com> Co-authored-by: aum-deriv <125039206+aum-deriv@users.noreply.github.com> Co-authored-by: Aizad Ridzo <103104395+aizad-deriv@users.noreply.github.com> Co-authored-by: Rostik Kayko <119863957+rostislav-deriv@users.noreply.github.com> Co-authored-by: Hamid Yaftian <hamid@deriv.com> Co-authored-by: Sergei Baranovski <sergei@deriv.com> Co-authored-by: thisyahlen <104053934+thisyahlen-deriv@users.noreply.github.com> Co-authored-by: yashim-deriv <yashim@deriv.com> Co-authored-by: Dev Sans <yashimwong@gmail.com> Co-authored-by: Mahdiyeh Amirkhani <mahdiyehamirkhani@Mahdiyeh-Amirkhanis-Mac-J79XQHKXVJ.local> Co-authored-by: george-usynin-binary <heorhi@binary.com> Co-authored-by: Niloofar Sadeghi <93518187+niloofar-deriv@users.noreply.github.com> Co-authored-by: niloofar sadeghi <niloofar.sadeghi@re-work.dev> Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> Co-authored-by: aizad-deriv <aizad@deriv.com> Co-authored-by: arshad-rao-deriv <muhammad.arshad@deriv.com> Co-authored-by: Arshad Rao <135801848+arshad-rao-deriv@users.noreply.github.com> Co-authored-by: lubega-deriv <142860499+lubega-deriv@users.noreply.github.com> Co-authored-by: Sergei Baranovski <sergei-deriv@users.noreply.github.com>
aizad-deriv
pushed a commit
that referenced
this pull request
Nov 3, 2023
* feat: add key files from prev tech tebt branch * feat: add digits file from prev branch * feat: add contract types file from prev branch * feat: add trade params mobile from prev branch * fix: remove duplicates * Maryia/dtra-401/TS migration: multiplier components (#34) * chore: migrate cancel-deal to ts * chore: migrate expiration & expiration modal * chore: migrated multiplier * chore: migrate stop-loss * chore: migrate take-profit * chore: migrate widgets * build: trigger build with empty commit * Kate / DTRA-398 / TS migration: Widget components in Trader package (#33) * refactor: ts of contract replay widget * refactor: ts of mobile widgets * refactor: ts of chart widgets * refactor: ts of top widgets * refactor: ts of top widgets * refactor: types for widgets * refactor: apply suggestions * refactor: add position prop * fix: extention of the imported file * chore: replace some localizes (#36) * Kate / DTRA-400 / [Refactoring]: delete duplicated unused files from Markers folder in Trader package and migrate to TS marker.jsx (#37) * refactor: marker folder * fix: change file extension in test * Kate / DTRA-404 / [Refactoring]: Divide trade-categories.tsx file and cover changes with tests (#35) * refactor: add rise fall description * refactor: separate stay end high contract description * refactor: separate description of digits contracts * refactor: separate asian reset runhighlow touch contracts * refactor: separate callputspread lb tickhighlow and vanilla contracts * refactor: separate multipliers contract * refactor: add unit tests for contract descriptions * refactor: add more tests * refactor: add tests for touch ans vanilla contracts * refactor: tests for trade categories * refactor: contract description structure * refactor: apply suggestions * refactor: add missing test case * Maryia/DTRA-403/feat: migrate Routes files in Trader package to TS (#38) * feat: migrate routes files to ts * fix: routes extension * refactor: for consistency * refactor: import order * refactor: renamed prop types * refactor: type for consistency * refactor: remove index as key * fix: ts migrate settingsmodal and remove unused file (#39) * fix: ts migrate settingsmodal and remove unused file * fix: failing tests * Kate/ fix: code smells (#40) * fix: code smells * chore: empty commit * fix: function arguments * refactor: tests * fix: codesmells * refactor: code smells * chore: change optional chaining * refactor: tests * refactor: tests for widgets component * fix: tests * fix: conflicts * fix: more conflicts * fix: tests * refactor: add more test cases * fix: types in tests * fix: test extention * fix: return turbos back to types * fix: revert unplanned files * fix: code smells (#42) * fix: test extention * fix: bug with inserting objecting into the backticks * fix: file extention after ts migration * chore: sort imports * chore: revert file * chore: revert wallet changes * chore: remove extra file * chore: apply nit * fix: language switching issue with the chart --------- Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> Co-authored-by: henry-deriv <118344354+henry-deriv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please include a summary of the change and which issue is fixed below:
When you need to add unit test
When you need to add integration test
Test coverage checklist (for reviewer)
Type of change