Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JSHint version to 2.13.6 #5243

Merged
merged 1 commit into from
Jul 9, 2023
Merged

Update JSHint version to 2.13.6 #5243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions lib/ace/mode/javascript/jshint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2392,13 +2392,13 @@ module.exports = slice;
exports.noConflict = function () { global._ = current; return exports; };
}()));
}(this, (function () {
// Underscore.js 1.13.4
// Underscore.js 1.13.6
// https://underscorejs.org
// (c) 2009-2022 Jeremy Ashkenas, Julian Gonggrijp, and DocumentCloud and Investigative Reporters & Editors
// Underscore may be freely distributed under the MIT license.

// Current version.
var VERSION = '1.13.4';
var VERSION = '1.13.6';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the commit title it says 2.13.6 but here it says 1.13.6, is that correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just interesting coincidence. It's version of updated underscore package

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I see, they are different packages all together that just coincidentally are on very similar version numbers, thx


// Establish the root object, `window` (`self`) in the browser, `global`
// on the server, or `this` in some virtual machines. We use `self`
Expand Down Expand Up @@ -4461,7 +4461,7 @@ module.exports = slice;
/*exported console */

var _ = _dereq_("underscore");
_.clone = _dereq_("lodash.clone");
_.clone = _dereq_("lodash.clone");
var events = _dereq_("events");
var vars = _dereq_("./vars.js");
var messages = _dereq_("./messages.js");
Expand Down Expand Up @@ -8930,7 +8930,7 @@ var JSHINT = (function() {
var id = state.tokens.prev;
value = expression(context, 10);
if (value) {
if (value.identifier && value.value === "undefined") {
if (!isConst && value.identifier && value.value === "undefined") {
warning("W080", id, id.value);
}
if (!lone) {
Expand Down Expand Up @@ -13527,7 +13527,7 @@ var errors = {

// Constants
E011: "'{a}' has already been declared.",
E012: "const '{a}' is initialized to 'undefined'.",
E012: "Missing initializer for constant '{a}'.",
E013: "Attempting to override '{a}' which is a constant.",

// Regular expressions
Expand Down Expand Up @@ -15122,7 +15122,7 @@ exports.regexpDot = /(^|[^\\])(\\\\)*\./;
*/

var _ = _dereq_("underscore");
_.slice = _dereq_("lodash.slice");
_.slice = _dereq_("lodash.slice");
var events = _dereq_("events");

// Used to denote membership in lookup tables (a primitive value such as `true`
Expand Down
2 changes: 1 addition & 1 deletion lib/ace/mode/javascript_worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ oop.inherits(JavaScriptWorker, Mirror);
this.options = options || {
// undef: true,
// unused: true,
esnext: true,
esversion: 11,
moz: true,
devel: true,
browser: true,
Expand Down