Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve type getMarkerAtPosition markergroup #5631

Merged
merged 1 commit into from
Aug 26, 2024
Merged

fix: improve type getMarkerAtPosition markergroup #5631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ace.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ export namespace Ace {
export class MarkerGroup {
constructor(session: EditSession, options?: {markerType?: "fullLine" | "line"});
setMarkers(markers: MarkerGroupItem[]): void;
getMarkerAtPosition(pos: Position): MarkerGroupItem;
getMarkerAtPosition(pos: Position): MarkerGroupItem | undefined;
}


Expand Down
2 changes: 1 addition & 1 deletion src/marker_group.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class MarkerGroup {
/**
* Finds the first marker containing pos
* @param {import("../ace-internal").Ace.Point} pos
* @returns import("../ace-internal").Ace.MarkerGroupItem
* @returns {import("../ace-internal").Ace.MarkerGroupItem | undefined}
*/
getMarkerAtPosition(pos) {
return this.markers.find(function(marker) {
Expand Down
Loading