Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Custom Channel Overrides #1372

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Conversation

scaccoman
Copy link

@scaccoman scaccoman commented Jun 27, 2022

This PR implements new custom channel override logic, which seems to be one of the most requested features:

Screenshot 2022-06-27 at 17 47 54

Please see the attached screen recording for a brief demo:
https://user-images.githubusercontent.com/28684618/175990993-94e62021-bdc4-4309-960b-8730cd4bd097.mp4

There are some weird behaviours around disabled segment types, I'm not really sure how it's supposed to work. I would appreciate it if someone more familiar with the project (e.g. @ajayyy) could shed some light.

  • I agree to license my contribution under LGPL-3.0 or my contribution is from another project with a license compatible with LGPL-3.0

@ajayyy
Copy link
Owner

ajayyy commented Jun 27, 2022

Thanks, but now we have two #1261

I do like how the configuration happens in the popup

@scaccoman
Copy link
Author

scaccoman commented Jun 28, 2022

Damn, I should have checked the open PRs before investing time into this one! 😅

I've taken a look at #1261 and I believe it does a better job overall. IMHO, however, it doesn't mean we should scrap this PR. I believe we could easily adapt the popup.ts code to work on top of @zedseven's implementation.
@ajayyy your feedback would be welcome.

@ajayyy ajayyy marked this pull request as draft July 22, 2022 17:57
@eirnym
Copy link

eirnym commented Jan 25, 2024

@scaccoman @ajayyy any news on this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants