Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query by hash prefix #127

Merged
merged 17 commits into from
Sep 4, 2020
Merged

Query by hash prefix #127

merged 17 commits into from
Sep 4, 2020

Conversation

Joe-Dowd
Copy link
Contributor

@Joe-Dowd Joe-Dowd commented Aug 30, 2020 •
edited
Loading

Continued from the work by https://github.com/Zegnat in #86

@Joe-Dowd Joe-Dowd mentioned this pull request Aug 30, 2020
Closed
@Joe-Dowd
Copy link
Contributor Author

branched off #114 so merge that first,

@Joe-Dowd Joe-Dowd mentioned this pull request Sep 3, 2020
Merged
@Joe-Dowd
Copy link
Contributor Author

Joe-Dowd commented Sep 3, 2020 •
edited
Loading

Video id is hashed using 1 pass sha256 hex digest

Interface:
GET /api/skipSegments/:hashPrefix?categories=["sponsor", "intro"]
response:

[
  {
    "videoID": "blah",
    "hash": "jhdshdjsd",
    "segments": ... /* Regular GET skipSegments response */
  }
]

@ajayyy ajayyy changed the base branch from testing to master September 4, 2020 03:45
@ajayyy ajayyy changed the base branch from master to testing September 4, 2020 03:45
@ajayyy ajayyy merged commit 70632dd into ajayyy:testing Sep 4, 2020
This was referenced Sep 4, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajayyy ajayyy ajayyy left review comments

@Zegnat Zegnat Zegnat left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Joe-Dowd @Zegnat @ajayyy