Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nushell.txt to fit nushell #632

Merged
merged 5 commits into from
Nov 19, 2023
Merged

Conversation

hackers267
Copy link
Contributor

@hackers267 hackers267 commented Oct 19, 2023

Change the def-env to def --env to fit the nushell v8.8, because the def-env is deprecated and be removed in v8.8

Fixes #630

Change the `def-env` to `def --env` to fit the nushell v8.8, because the `def-env` is deprecated and be removed in v8.8
README.md Outdated
Comment on lines 18 to 19
<b>Warp is a modern, Rust-based terminal with AI built in so you
and your team can build great software, faster.</b>
Copy link

@marcelarie marcelarie Nov 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not related to the PR, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, modify this just because some error in CI

@ajeetdsouza
Copy link
Owner

Thanks!

@ajeetdsouza ajeetdsouza merged commit f537a4e into ajeetdsouza:main Nov 19, 2023
3 of 4 checks passed
@happysalada
Copy link

is there a chance there can be a new release of zoxide for this before mid december ?
Just asking since this will become a hard deprecation in nushell around that time (most likely).
We can always work around this of course if you are busy.
Thank you for making zoxide!

@ajeetdsouza
Copy link
Owner

Can be done! :)

Sorry this took so long to merge, I've been super caught up with work of late.

@happysalada
Copy link

Hey no worries at all !
Thanks again for your work on this !

@happysalada
Copy link

@ajeetdsouza small bump, the breaking release of nu is about 2 weeks away.

arkrost added a commit to arkrost/dotfiles that referenced this pull request Dec 2, 2023
arkrost added a commit to arkrost/dotfiles that referenced this pull request Dec 3, 2023
@happysalada
Copy link

@ajeetdsouza just a friendly ping in case you have a bit of time this weekend.
I'll probably ping again next week if that's alright with you!

@happysalada
Copy link

@ajeetdsouza another friendly ping. The release containing the breaking change in nushell has just been made.
No worries at all if you have work, i dont plan on upgrading my system too soon personally, but when you have a moment, it would be nice.

@poliorcetics
Copy link

poliorcetics commented Dec 18, 2023

As a workaround for people ending up here:

When you get an error about def-env not working, replace it by def --env:

zoxide init nushell | str replace --all "def-env" "def --env" | save -f ... that way it works automatically and will continue to work on the next zoxide update :)

nagromc added a commit to nagromc/dotfiles that referenced this pull request Jan 22, 2024
This commit should be reverted once ajeetdsouza/zoxide#632 is released.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nushell breaking changes
5 participants