Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support z -- <dir> for zsh and fish #858

Merged
merged 1 commit into from
Jul 20, 2024
Merged

Conversation

Undefined01
Copy link
Contributor

Inspired by @solodov #695, and @LangLangBart junegunn/fzf#3928 (comment), this PR ports the support for z -- <dir> to zsh and fish shell.

This enhancement will provide better compatibility with the cd command. With this change, the syntax cd -- <dir> will continue to function correctly when zoxide overrides the built-in cd using --cmd cd. This also fixes junegunn/fzf#2799 1 where fzf uses cd -- <dir> in the Alt+C key-binding.

Footnotes

  1. The PR to fzf which use builtin cd -- <dir> to avoid conflict is reverted. See fzf#3928

@ajeetdsouza
Copy link
Owner

Thank you!

@ajeetdsouza ajeetdsouza merged commit d655e02 into ajeetdsouza:main Jul 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants