Skip to content

Commit

Permalink
feat: autolabel flag in diagrams that modifies label (mingrammer#482)
Browse files Browse the repository at this point in the history
* autolabel flag in diagrams that modifies label

* update based on review
  • Loading branch information
anovis authored and ajmaradiaga committed Nov 8, 2023
1 parent 4f58dff commit cdbc094
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 5 deletions.
20 changes: 15 additions & 5 deletions diagrams/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ def __init__(
direction: str = "LR",
curvestyle: str = "ortho",
outformat: str = "png",
autolabel: bool = False,
show: bool = True,
graph_attr: dict = {},
node_attr: dict = {},
Expand Down Expand Up @@ -142,6 +143,7 @@ def __init__(
self.dot.edge_attr.update(edge_attr)

self.show = show
self.autolabel = autolabel

def __str__(self) -> str:
return str(self.dot)
Expand Down Expand Up @@ -292,11 +294,23 @@ def __init__(self, label: str = "", *, nodeid: str = None, **attrs: Dict):
self._id = nodeid or self._rand_id()
self.label = label

# Node must be belong to a diagrams.
self._diagram = getdiagram()
if self._diagram is None:
raise EnvironmentError("Global diagrams context not set up")

if self._diagram.autolabel:
prefix = self.__class__.__name__
if self.label:
self.label = prefix + "\n" + self.label
else:
self.label = prefix

# fmt: off
# If a node has an icon, increase the height slightly to avoid
# that label being spanned between icon image and white space.
# Increase the height by the number of new lines included in the label.
padding = 0.4 * (label.count('\n'))
padding = 0.4 * (self.label.count('\n'))
self._attrs = {
"shape": "none",
"height": str(self._height + padding),
Expand All @@ -306,10 +320,6 @@ def __init__(self, label: str = "", *, nodeid: str = None, **attrs: Dict):
# fmt: on
self._attrs.update(attrs)

# Node must be belong to a diagrams.
self._diagram = getdiagram()
if self._diagram is None:
raise EnvironmentError("Global diagrams context not set up")
self._cluster = getcluster()

# If a node is in the cluster context, add it to cluster.
Expand Down
6 changes: 6 additions & 0 deletions tests/test_diagram.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,12 @@ def test_empty_name(self):
with Diagram(show=False):
Node("node1")
self.assertTrue(os.path.exists(f"{self.name}.png"))

def test_autolabel(self):
with Diagram(name=os.path.join(self.name, "nodes_to_node"), show=False):
node1 = Node("node1")
self.assertTrue(node1.label,"Node\nnode1")


def test_outformat_list(self):
"""Check that outformat render all the files from the list."""
Expand Down

0 comments on commit cdbc094

Please sign in to comment.