Updates for RC4 contracts and other improvements #16
Conversation
…en handling take/settle
| @@ -8,7 +8,7 @@ | |||
| "deploy": "graph deploy --node https://api.studio.thegraph.com/deploy/ ajna", | |||
| "create-local": "graph create --node http://localhost:8020/ ajna", | |||
| "remove-local": "graph remove --node http://localhost:8020/ ajna", | |||
| "deploy-local": "graph deploy --node http://localhost:8020/ --ipfs http://localhost:5001 ajna", | |||
| "deploy-local": "graph deploy --node http://localhost:8020/ --ipfs http://localhost:5001 ajna -l rc4", | |||
There was a problem hiding this comment.
This arg sets the tag, making deployment non-interactive. Extremely helpful for fix/build/deploy test cycle.
There was a problem hiding this comment.
Nice improvement, makes sense.
| # updated upon ApproveLpTransferors and RevokeLpTransferors | ||
| type LPTransferors @entity { | ||
| # LP transferors approved by a lender for a pool, updated upon Approve/RevokeLpTransferors | ||
| type LPTransferorList @entity { |
There was a problem hiding this comment.
The plural entity name caused a bug trying to query the autogenerated collection.
… operations in LiquidationAuction
| pool.poolSize = wadToDecimal(poolLoansInfo.poolSize) | ||
| pool.loansCount = poolLoansInfo.loansCount | ||
| pool.maxBorrower = poolLoansInfo.maxBorrower | ||
| pool.inflator = wadToDecimal(poolLoansInfo.pendingInflator) | ||
|
|
There was a problem hiding this comment.
Should this also be setting inflatorLastUpdate?
There was a problem hiding this comment.
Yes, but we can't get it without adding a call to Pool.inflatorInfo. We could assume it changes with every pool action instead of most pool actions, and pass block height as an argument. But due to the limited utility, I think I'd rather remove it from the entity. Thoughts?
There was a problem hiding this comment.
Well isn't it useful for knowing when interest rates will change? Might be important for determining plans
There was a problem hiding this comment.
No, the inflator is decoupled from the rate update. Inflator updates with most pool interactions. Interest rate updates every 12 hours or more, depending on MAU and TU.
There was a problem hiding this comment.
Removed in 8d343ce.
src/utils/constants.ts
Outdated
| export const ZERO_BI = BigInt.zero() | ||
| export const ONE_BI = BigInt.fromI32(1) | ||
| export const TEN_BI = BigInt.fromI32(10) | ||
| export const ONE_RAY_BI = BigInt.fromString("1000000000000000000000000000") |
There was a problem hiding this comment.
nit: can remove ONE_RAY_BI
| @@ -217,7 +225,7 @@ export function mintPosition(lender: Address, pool: Address, tokenId: BigInt, to | |||
| handleMint(newMintEvent) | |||
| } | |||
|
|
|||
| export function assertPosition(lender: Address, pool: Address, tokenId: BigInt, tokenContractAddress: Address): void { | |||
| export function assertPosition(lender: Address, pool: Address, tokenId: BigInt, tokenContractAddress: Address): void { | |||
RC4 changes
DecreaseLPAllowance.MoveLiquidityevent emits LP amounts.Flashloanevent and track total amount of quote token/collateral flashloaned in each pool.ResetInterestRateevent.auctionStatusPoolInfoUtils to get auction prices, which were unavailable in RC3.Bug fixes
AuctionSettleevent was not saving updates toLiquidationAuctionentity.Other improvements
Bucketentity, as requested by BlockAnalytica. Using a local JSON price file to do the conversion.interestRatewithborrowRateandlendRateafter introducing a way to query lender interest margin.Pooland some liquidation auction entities for improved DX.