Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes #17

Merged
merged 5 commits into from
May 26, 2023
Merged

Bug fixes #17

merged 5 commits into from
May 26, 2023

Conversation

EdNoepel
Copy link
Contributor

@EdNoepel EdNoepel commented May 26, 2023 •
edited
Loading

  • Fixed issue with debt going negative after repayment.
  • Prevent kickTime and other liquidation fields from being reset to 0 upon settlement.
  • Fix some array management issues.

@EdNoepel EdNoepel requested a review from MikeHathaway May 26, 2023 02:08
MikeHathaway
MikeHathaway approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@MikeHathaway MikeHathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Repay test is failing because we're missing a mockGetBorrowerInfo prior to the mock event creation. I can push a PR or commit fixing this, but otherwise happy to merge

@EdNoepel
Copy link
Contributor Author

LGTM. Repay test is failing because we're missing a mockGetBorrowerInfo prior to the mock event creation. I can push a PR or commit fixing this, but otherwise happy to merge

I'll take care of it; thank you.

@EdNoepel
Copy link
Contributor Author

LGTM. Repay test is failing because we're missing a mockGetBorrowerInfo prior to the mock event creation. I can push a PR or commit fixing this, but otherwise happy to merge

I'll take care of it; thank you.

Done in 0aa792d

@EdNoepel EdNoepel merged commit 54e96b4 into develop May 26, 2023
@EdNoepel EdNoepel deleted the 2415 branch July 20, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeHathaway MikeHathaway MikeHathaway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EdNoepel @MikeHathaway