Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes #19

Merged
merged 3 commits into from
Jun 1, 2023
Merged

Bug fixes #19

merged 3 commits into from
Jun 1, 2023

Conversation

EdNoepel
Copy link
Contributor

@EdNoepel EdNoepel commented Jun 1, 2023 •
edited
Loading

  • Fix bug initializing lendRate upon pool creation
  • Eliminate ONE_WAD_BD constant, which was misused in a few places
  • Fix bug updating pool contract's collateral token balance

@EdNoepel EdNoepel changed the title fix bug initializing lendRate upon pool creation Bug fixes Jun 1, 2023
MikeHathaway
MikeHathaway approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@MikeHathaway MikeHathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EdNoepel EdNoepel merged commit b81cd18 into develop Jun 1, 2023
@EdNoepel EdNoepel deleted the lendrate-bugfix branch June 1, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeHathaway MikeHathaway MikeHathaway approved these changes

@0xCommanderKeen 0xCommanderKeen Awaiting requested review from 0xCommanderKeen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EdNoepel @MikeHathaway