Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use data source templates for pools #2

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Conversation

MikeHathaway
Copy link
Contributor

@MikeHathaway MikeHathaway commented Mar 9, 2023

Updates subgraph.yaml to instantiate Pool's according to a data source template. This is done to enable tracking of events across multiple pools when we don't know the address of a pool ahead of time (since new pools will be added continuously), avoiding issues from conflicting event handling.

More information is available in the documentation here: https://thegraph.com/docs/en/developing/creating-a-subgraph/#data-source-templates-for-dynamically-created-contracts

@MikeHathaway MikeHathaway requested a review from EdNoepel March 9, 2023 19:50
Copy link
Contributor

@EdNoepel EdNoepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I notice we're still using a pre-rc2 address. After this is merged, I suppose my first task could be updating from rc1 to rc3.

@EdNoepel EdNoepel merged commit 96a8635 into develop Mar 10, 2023
@EdNoepel EdNoepel deleted the dynamic-data-sources branch March 10, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants