Move addresses and start blocks into networks config #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeHathaway
reviewed
Jun 5, 2023
| @@ -12,8 +12,8 @@ | |||
| "test": "graph test" | |||
| }, | |||
| "dependencies": { | |||
| "@graphprotocol/graph-cli": "0.37.6", | |||
| "@graphprotocol/graph-ts": "0.29.1" | |||
| "@graphprotocol/graph-cli": ">=0.37.6", | |||
There was a problem hiding this comment.
Do we want to automatically update? May be issues with breaking changes
There was a problem hiding this comment.
Pinning them had the opposite problem. Tim tried to build, but one of the deps for the older version no longer existed. As a result, he was unable to install the pinned versions.
There was a problem hiding this comment.
Imagine that should be resolved by our usage of the lockfile? It was removed entirely from the NPM mirrors?
MikeHathaway
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ETH_RPC_URLenvironment withETH_NETWORK, which includes the network name prefix. Updated documentation accordingly.subgraph.ymland intonetworks.json'Note that network now must be specified in the build process. Updated README to explain this.