Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RC5 support and indexed testnet container #21

Merged
merged 6 commits into from
Jun 9, 2023
Merged

RC5 support and indexed testnet container #21

merged 6 commits into from
Jun 9, 2023

Conversation

EdNoepel
Copy link
Contributor

@EdNoepel EdNoepel commented Jun 8, 2023 •
edited
Loading

Changes

  • RC5 updates, mostly for grant fund changes.
  • Created new docker compose to index a local ganache testnet. Cleaner than meddling with docker networking between two compose files, and reduces conflict between container used for SDK unit tests.
  • Checked back in addresses and block heights with subgraph.yaml. The build process overwrites them, and it is needless tedium deleting the data before every PR.

EdNoepel
EdNoepel commented Jun 8, 2023
View reviewed changes
src/utils/constants.ts
export const grantFundAddressTable = new TypedMap<string, Address>()
grantFundAddressTable.set('goerli', Address.fromString('0x54110a15011bcb145a8CD4f5adf108B2B6939A1e'))
grantFundAddressTable.set('goerli', Address.fromString('0xd364766E1D431e0bb99705c8eb0e6665C3b32eB5'))
grantFundAddressTable.set('ganache', Address.fromString('0xE340B87CEd1af1AbE1CE8D617c84B7f168e3b18b'))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On testnet deployment, AJNA token and GrantFund are deployed first, so the address will likely always be the same.

@EdNoepel EdNoepel requested a review from MikeHathaway June 8, 2023 07:45
@EdNoepel EdNoepel requested a review from ith-harvey June 8, 2023 20:35
ith-harvey
ith-harvey approved these changes Jun 8, 2023
View reviewed changes
Copy link

@ith-harvey ith-harvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran docker-compose -f ganache-indexer.yml up locally and it worked after authenticating.

Looks like extraordinary methods are removed.

MikeHathaway
MikeHathaway approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@MikeHathaway MikeHathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EdNoepel EdNoepel merged commit 305c1b0 into develop Jun 9, 2023
@EdNoepel EdNoepel deleted the rc5 branch June 9, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ith-harvey ith-harvey ith-harvey approved these changes

@MikeHathaway MikeHathaway MikeHathaway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EdNoepel @MikeHathaway @ith-harvey