Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate several fields which change every block #22

Merged
merged 3 commits into from
Jun 19, 2023
Merged

Eliminate several fields which change every block #22

merged 3 commits into from
Jun 19, 2023

Conversation

EdNoepel
Copy link
Contributor

Changes

  • Remove from schema several fields which are dependent upon the block timestamp, thus cannot be served from database. Specifically, removed debt amounts and auction prices. Intentionally left a few pool-level fields in, notably the LUP.
  • Renamed the ganache container for the local testnet compose, as not to conflict with the SDK container.
  • During testing, uncovered a bug involving incorrect collateralRemaining amounts in liquidation. Discovered code was double-updating both collateralRemaining and debtRemaining. Removed the explicit subtraction logic in favor of reading updated values from contract after handling the event.

@EdNoepel EdNoepel requested a review from MikeHathaway June 16, 2023 04:34
MikeHathaway
MikeHathaway approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@MikeHathaway MikeHathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EdNoepel EdNoepel requested a review from 0xCommanderKeen June 16, 2023 22:22
@EdNoepel EdNoepel merged commit 2087938 into develop Jun 19, 2023
@EdNoepel EdNoepel deleted the 1320 branch July 20, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeHathaway MikeHathaway MikeHathaway approved these changes

@0xCommanderKeen 0xCommanderKeen Awaiting requested review from 0xCommanderKeen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EdNoepel @MikeHathaway