Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace feeRate with borrowFeeRate and depositFeeRate #23

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Conversation

EdNoepel
Copy link
Contributor

Previous implementation of feeRate did not work. Replaced with:

  • borrowFeeRate - origination fee
  • depositFeeRate - charged to lenders when depositing below HTP

Also updated interest rate change event entity to show these fees before and after an interest rate change, since both are dependent on interest rate.

@EdNoepel EdNoepel requested a review from MikeHathaway June 21, 2023 22:01
@EdNoepel EdNoepel marked this pull request as draft June 21, 2023 22:07
@EdNoepel EdNoepel marked this pull request as ready for review June 21, 2023 22:10
Copy link
Contributor

@MikeHathaway MikeHathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EdNoepel EdNoepel requested a review from 0xCommanderKeen June 22, 2023 12:38
@EdNoepel EdNoepel merged commit 7ad8e14 into develop Jun 26, 2023
@EdNoepel EdNoepel deleted the feerate-fix branch June 26, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants