Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GrantFund fixes and cleanup #32

Merged
merged 17 commits into from
Jul 20, 2023
Merged

GrantFund fixes and cleanup #32

merged 17 commits into from
Jul 20, 2023

Conversation

EdNoepel
Copy link
Contributor

@EdNoepel EdNoepel commented Jul 18, 2023 •
edited
Loading

Changes

  • Fixed array management issues causing empty collections in GrantFund-related entities.
  • Get GrantFund address from events instead of network lookup table.
  • Fix issue converting between "signed" and "unsigned" BigInts. Discovered two BigInts may be equal, yet may convert to different bytes, as they may be right-padded (little endian) with zeros. This padding breaks ID lookups.
  • Renamed standardProposals to just proposals, and eliminated some unused logic involving determining proposal mechanism.
  • Adjusted some modules needed to get Matchstick unit tests working on my laptop.

Tested on parvati.

@EdNoepel EdNoepel marked this pull request as draft July 18, 2023 02:57
@EdNoepel EdNoepel force-pushed the grantfund-debugging branch from 515ef01 to 1146b54 Compare July 18, 2023 03:03
@EdNoepel EdNoepel marked this pull request as ready for review July 18, 2023 03:18
@EdNoepel EdNoepel requested a review from MikeHathaway July 18, 2023 03:18
@EdNoepel EdNoepel changed the title GrantFund fixes GrantFund fixes and cleanup Jul 18, 2023
MikeHathaway
MikeHathaway approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@MikeHathaway MikeHathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EdNoepel EdNoepel requested a review from prateek105 July 19, 2023 14:06
prateek105
prateek105 approved these changes Jul 20, 2023
View reviewed changes
Copy link

@prateek105 prateek105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@EdNoepel EdNoepel merged commit 2a90e09 into develop Jul 20, 2023
@EdNoepel EdNoepel deleted the grantfund-debugging branch July 20, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeHathaway MikeHathaway MikeHathaway approved these changes

@prateek105 prateek105 prateek105 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EdNoepel @prateek105 @MikeHathaway