Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

associate bucket with Pool entity #41

Merged
merged 2 commits into from
Aug 2, 2023
Merged

associate bucket with Pool entity #41

merged 2 commits into from
Aug 2, 2023

Conversation

EdNoepel
Copy link
Contributor

@EdNoepel EdNoepel commented Jul 28, 2023 •
edited
Loading

Currently two queries are needed to inspect the Pool associated with a Bucket. Enabling a single query to get pool data is useful for a few cases:

  • identifying pools with deposit in first bucket
  • showing available collateral sitting in pools ready to be traded
  • revealing pools with free collateral placed in bucket 7388 as a result of liquidation

@EdNoepel
Copy link
Contributor Author

EdNoepel commented Jul 28, 2023 •
edited
Loading

Production Ajna Dapp does not show bucket info, but BlockAnalitica likely uses this, and should review.

MikeHathaway
MikeHathaway approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@MikeHathaway MikeHathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EdNoepel EdNoepel merged commit bf64ab8 into develop Aug 2, 2023
@EdNoepel EdNoepel deleted the bucket-pool branch August 2, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeHathaway MikeHathaway MikeHathaway approved these changes

@0xCommanderKeen 0xCommanderKeen Awaiting requested review from 0xCommanderKeen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EdNoepel @MikeHathaway